Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
2671
Archived fixes / Re: call_lang_hook: Missing debug info
« on October 8th, 2012, 05:11 AM »
Should it include the full paths or what, exactly?
Remember, the language hooks get a full path to play with, not just the plugin id and relative path.
Remember, the language hooks get a full path to play with, not just the plugin id and relative path.
2672
Archived fixes / Re: Delete media: 'No' button does not work
« on October 7th, 2012, 07:59 PM »
Hmm, this is a curious one. The event that is supposed to be called is essentially the right one - it selects the a that makes up the close button and sends the click() event to it, but for some reason it's not triggering the click event that is actually bound to that element.
2673
Archived fixes / Re: Moving text within a post
« on October 7th, 2012, 07:57 PM »
Still doing it, btw.
2674
Features / Re: New revs
« on October 7th, 2012, 07:17 PM »
(1 file, 1KB, 1 line)
Revision: 1736
Author: arantor
Date: 07 October 2012 18:16:52
Message:
! Theoretically prevent mass duplication of language loading. Essentially when using a non-English language, by default there is a call to load English first so that missing strings don't cause errors. But in the admin search in particular, it calls multiple times - and since the previous load was not English, the subsequent call is for English. IOW, if the current call is a fallback call, don't bother if already loaded (since we would have hit English first anyway). This should not break anything else... (Load.php)
----
Modified : /trunk/Sources/Load.php
Revision: 1736
Author: arantor
Date: 07 October 2012 18:16:52
Message:
! Theoretically prevent mass duplication of language loading. Essentially when using a non-English language, by default there is a call to load English first so that missing strings don't cause errors. But in the admin search in particular, it calls multiple times - and since the previous load was not English, the subsequent call is for English. IOW, if the current call is a fallback call, don't bother if already loaded (since we would have hit English first anyway). This should not break anything else... (Load.php)
----
Modified : /trunk/Sources/Load.php
2675
Archived fixes / Re: Admin search issues
« on October 7th, 2012, 07:17 PM »
The mass extra loading should be fixed in r1736.
2676
Features / Re: New revs
« on October 7th, 2012, 07:07 PM »
(1 file, 3KB)
Revision: 1735
Author: arantor
Date: 07 October 2012 18:06:27
Message:
! Hopefully fix my old bug related to DNS lookups, and introducing IPv6 support for it at the same time. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Revision: 1735
Author: arantor
Date: 07 October 2012 18:06:27
Message:
! Hopefully fix my old bug related to DNS lookups, and introducing IPv6 support for it at the same time. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
2677
Archived fixes / Re: DNS lookup can sometimes throw errors
« on October 7th, 2012, 07:06 PM »
Hopefully fixed in r1735
2678
Features / Re: Plugin revs
« on October 7th, 2012, 05:51 PM »
(1 file, 1KB, 1 line)
Revision: 53
Author: arantor
Date: 07 October 2012 16:50:34
Message:
! [Topic Solved] Fix a stupid bug with permissions not being properly checked in thread views. (TopicSolved-Display.php)
----
Modified : /topic_solved/src/TopicSolved-Display.php
Revision: 53
Author: arantor
Date: 07 October 2012 16:50:34
Message:
! [Topic Solved] Fix a stupid bug with permissions not being properly checked in thread views. (TopicSolved-Display.php)
----
Modified : /topic_solved/src/TopicSolved-Display.php
2679
Bug reports / Re: Double space bug in thoughts + others
« on October 7th, 2012, 05:47 PM »
The first half of this stuff is actually a duplicate of http://wedge.org/pub/bugs/7253/thoughts-don-t-handle-entity-content-properly/
2680
Archived fixes / Re: SMF bug 4870 (incorrectly capitalised month names)
« on October 7th, 2012, 05:46 PM »
Fixed in r1734.
2681
Features / Re: New revs
« on October 7th, 2012, 05:45 PM »
(3 files, 1KB)
Revision: 1734
Author: arantor
Date: 07 October 2012 16:45:02
Message:
! SMF bug 4870: incorrectly capitalised dates. In our case, if setlocale is used, trust the locale database as being correct (because it is likely to be correct). If setlocale is not used, trust the language strings we have for things. Interestingly, French already behaved this way anyway since the old option was already off in French. (Subs, index language file)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Revision: 1734
Author: arantor
Date: 07 October 2012 16:45:02
Message:
! SMF bug 4870: incorrectly capitalised dates. In our case, if setlocale is used, trust the locale database as being correct (because it is likely to be correct). If setlocale is not used, trust the language strings we have for things. Interestingly, French already behaved this way anyway since the old option was already off in French. (Subs, index language file)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
2682
Archived fixes / Re: template_post_header_after: Invalid markup
« on October 7th, 2012, 04:15 PM »
Yup, I couldn't find a matching opener, but I also moved a few things around for proper consistency in r1733.
2683
Archived fixes / Re: template_post_name_email: Invalid marjkup
« on October 7th, 2012, 04:15 PM »
Fixed in r1733, thanks!
2684
Features / Re: New revs
« on October 7th, 2012, 04:14 PM »
(2 files, 2KB)
Revision: 1733
Author: arantor
Date: 07 October 2012 15:13:26
Message:
! Certain navigation links were hidden if the user was a guest, even if guests had the permission to do what the navigation menu was pointing to. (MessageIndex.php)
! Fixed some validation errors, thanks live! (Post.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/Post.template.php
Revision: 1733
Author: arantor
Date: 07 October 2012 15:13:26
Message:
! Certain navigation links were hidden if the user was a guest, even if guests had the permission to do what the navigation menu was pointing to. (MessageIndex.php)
! Fixed some validation errors, thanks live! (Post.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/Post.template.php
2685
Archived fixes / Re: Database column type 'decimal' ignored
« on October 7th, 2012, 02:59 AM »
Float is inherently unreliable beyond a certain point (2^52 for purely whole numbers, but it depends what you're trying to store)
You probably could get away with floats if you were really pushed, but the correct thing to do is use a varchar unless you're planning on doing something that expressly needs it as a number like sorting or searching where distance is a factor.
You probably could get away with floats if you were really pushed, but the correct thing to do is use a varchar unless you're planning on doing something that expressly needs it as a number like sorting or searching where distance is a factor.