Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
2401
The Pub / Re: Practical plugins problem with WeCSS
« on November 16th, 2012, 05:37 AM »
Oh, this gets better and better.
So, I'm using live627's dateinput in the calendar, and I call add_plugin_css_file('Wedgeward:Calendar', 'css/dateinput', true); which goes and gets it. In this particular case, I'm inside a given board.
And it generates this filename:
Code: [Select]
The calendar, dateinput and chrome24 bits I'm cool with. But I have no way of indicating, as far as I know, anything about the others. This is going to generate a very large shit-ton of files, and I don't know anything about stopping it.
It may or may not be members only, it may or may not be admin only, it may not even have a board when it's called.
So, I'm using live627's dateinput in the calendar, and I call add_plugin_css_file('Wedgeward:Calendar', 'css/dateinput', true); which goes and gets it. In this particular case, I'm inside a given board.
And it generates this filename:
http://localhost/wedge/css/calendar-dateinput-chrome24-member-m1-b1-c1-admin-local-global-replace-1353039526.css.gzThe calendar, dateinput and chrome24 bits I'm cool with. But I have no way of indicating, as far as I know, anything about the others. This is going to generate a very large shit-ton of files, and I don't know anything about stopping it.
It may or may not be members only, it may or may not be admin only, it may not even have a board when it's called.
2402
Features / Re: Calendar
« on November 16th, 2012, 04:12 AM »
To be brutally honest, getting into making such a distinction is out of the scope of the plugin. The point of the UI was mostly to build a structure around having such things, making things like language specific packs is deliberately kept out of scope. I wasn't concentrating in figuring out whether or not I should keep individual days or not, just that the system allowed for it to be easy.
SMF bundles them together; it has little choice. I have a bit more choice but ultimately the way to do it is to make language/country packs of holidays and have a collection of very basic stuff in the core - building the UI above is merely a transition to that.
SMF bundles them together; it has little choice. I have a bit more choice but ultimately the way to do it is to make language/country packs of holidays and have a collection of very basic stuff in the core - building the UI above is merely a transition to that.
2403
Features / Re: Calendar
« on November 16th, 2012, 03:39 AM »
It really isn't going to happen for the preset holidays as per the above. Adding that level of complexity to outweigh the very very small amount of code for the presets isn't worth the effort. Especially since they're not in the database and the only thing would be to edit the code of the plugin to remove the definitions.
Adding pruning for custom events... I'm not sure that's really necessary. If the admin cares enough to prune the events they added themselves, that's up to them. But people do go back and look through previous months in the calendar - doing the pruning you're suggesting pretty much eliminates anything before the previous month or so.
Adding pruning for custom events... I'm not sure that's really necessary. If the admin cares enough to prune the events they added themselves, that's up to them. But people do go back and look through previous months in the calendar - doing the pruning you're suggesting pretty much eliminates anything before the previous month or so.
2404
Plugins / Re: Request for 'Media Album Custom Fields' plugin
« on November 16th, 2012, 01:20 AM »
They can be, but I'd almost be tempted to suggest this as a core feature.
2405
Features / Re: Calendar
« on November 16th, 2012, 12:18 AM »
Seems that's the most logical way to handle it (in all respects)
2406
Features / Re: Calendar
« on November 15th, 2012, 10:31 PM »
No... people who've responded is people who've clicked 'Yes, I'm coming', 'No, I'm not coming' or 'I'm not sure yet', as in they've actively made some action to indicate interest.
2407
Features / Re: Calendar
« on November 15th, 2012, 09:19 PM »
I don't see why it couldn't be either way - either have it as 'anyone can attend' or 'only these people can attend'. I was using RSVP as sort of an umbrella term for both.
2408
Features / Re: Calendar
« on November 15th, 2012, 08:28 PM »
Oh, I see what you mean. What I'd do in that scenario is tie it more to people who've actually responded to the RSVP (in case they have to change)... would that work for people?
2409
Archived fixes / Re: Missing likes.png file
« on November 15th, 2012, 08:26 PM »
How did I manage not to commit that one? >_> It's in my local repo, just not added!
I'll commit it when I next commit to trunk, but I'd note that all it is is just a heart image for the admin front page.
I'll commit it when I next commit to trunk, but I'd note that all it is is just a heart image for the admin front page.
2410
Features / Re: Calendar
« on November 15th, 2012, 02:50 PM »
I already anticipated that in fact, there are hooks already available for extending this screen ;) I haven't decided what to keep as 'core' yet though I might just keep these ones for now.Quote Check the calendar settings page, it's quite clear that you can put things in the info centre if you want ;)Quote That's not actually a big deal to make happen.Quote Wouldn't you just use the normal notifications on this one?
What I'd do, though, is certainly tie it in with the RSVP stuff...
"Placing it on the front page/info centre? Check. Even including upcoming birthdays and events if I remember rightly." We use Simple Portal for this so I don't know if the SMF calendar is capable of doing this simply.
We have one board for all events, so would prefer to restrict the boards into which events can be posted e.g. by controlling the boards that appear in the "Post In:" dropdown.
So could there be a "Subscribe to this event" button? The thread starter (or mod / admin) could then create a post and then choose to email it to all subscribers e.g. via an extra item in "Additional Options".
What I'd do, though, is certainly tie it in with the RSVP stuff...
2411
Plugins / Re: Converting WedgeDesk
« on November 15th, 2012, 02:47 PM »
That's still the case but the plan is to change it. To be honest, though, it needs much more work than what it's had so far. Like gutting and starting over.
2412
Features / Re: Calendar
« on November 15th, 2012, 12:22 PM »Talk like a pirate day :P
2413
Features / Re: Plugin revs
« on November 15th, 2012, 05:29 AM »
(10 files, 26KB)
Revision: 58
Author: arantor
Date: 15 November 2012 04:28:29
Message:
! [Calendar] Major overhauls. Some minor error fixes, overhauled the way predefined holidays work (meaning they are translatable and easily disableable), layout fixes, no longer using the sidebar but what is IMO a better layout. It's still very, very broken. Posting of regular events doesn't work at all right now. DO NOT INSTALL THIS YET. (all files)
----
Modified : /calendar/Calendar.php
Modified : /calendar/Calendar.template.php
Modified : /calendar/CalendarPost.php
Modified : /calendar/ManageCalendar.php
Modified : /calendar/ManageCalendar.template.php
Modified : /calendar/Subs-Calendar.php
Modified : /calendar/calendar.css
Added : /calendar/lang/CalendarHolidays.english.php
Modified : /calendar/lang/ManageCalendar.english.php
Modified : /calendar/plugin-info.xml
@ Yup. It's very broken still, and that's entirely my fault from how I yanked it out of SMF/Wedge originally, but it's getting there. Plenty more to do yet.
Revision: 58
Author: arantor
Date: 15 November 2012 04:28:29
Message:
! [Calendar] Major overhauls. Some minor error fixes, overhauled the way predefined holidays work (meaning they are translatable and easily disableable), layout fixes, no longer using the sidebar but what is IMO a better layout. It's still very, very broken. Posting of regular events doesn't work at all right now. DO NOT INSTALL THIS YET. (all files)
----
Modified : /calendar/Calendar.php
Modified : /calendar/Calendar.template.php
Modified : /calendar/CalendarPost.php
Modified : /calendar/ManageCalendar.php
Modified : /calendar/ManageCalendar.template.php
Modified : /calendar/Subs-Calendar.php
Modified : /calendar/calendar.css
Added : /calendar/lang/CalendarHolidays.english.php
Modified : /calendar/lang/ManageCalendar.english.php
Modified : /calendar/plugin-info.xml
@ Yup. It's very broken still, and that's entirely my fault from how I yanked it out of SMF/Wedge originally, but it's getting there. Plenty more to do yet.
2414
Features / Re: Calendar
« on November 15th, 2012, 05:04 AM »
Just going to leave this here :whistle:
2415
Archived fixes / Re: sb refresh does not update scrollbar
« on November 15th, 2012, 05:03 AM »
I have another example of this. I'm rewriting the calendar stuff (not ready to comment yet)
The existing code in SVN is broken in various ways, but in template_edit_holiday() (in ManageCalendar.template.php), you'll see some inline JS.
Replace it with:
Code: [Select]
Switch months, to something like February. Boom, no scrollbar. Sorry about the code, but it's late, and I'm very fed up this evening, since every little thing seems to take 4 times longer to follow it all down the respective rabbit holes. (Oh, and the old code doesn't work because the old method of pushing new Options doesn't work for some reason.)
The existing code in SVN is broken in various ways, but in template_edit_holiday() (in ManageCalendar.template.php), you'll see some inline JS.
Replace it with:
add_js('
var monthLength = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];
function generateDays()
{
var days = 0, selected = 0, dayElement = $("#day"), year = $("#year").val(), monthElement = $("#month")[0];
monthLength[1] = (year % 4 == 0 && (year % 100 != 0 || year % 400 == 0)) ? 29 : 28;
selected = dayElement.val();
dayElement.empty();
days = monthLength[monthElement.value - 1];
for (i = 1; i <= days; i++)
dayElement.append(\'<option value="\' + i + \'">\' + i + \'</option>\');
if (selected < days)
dayElement.val(selected);
$("#day").sb();
}');Switch months, to something like February. Boom, no scrollbar. Sorry about the code, but it's late, and I'm very fed up this evening, since every little thing seems to take 4 times longer to follow it all down the respective rabbit holes. (Oh, and the old code doesn't work because the old method of pushing new Options doesn't work for some reason.)