Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
2176
Features / Re: New revs
« on December 22nd, 2012, 10:21 PM »
(4 files, 2KB)

Revision: 1807
Author: arantor
Date: 22 December 2012 21:21:07
Message:
! Actually declare functions to their correct scope, and we::analyze is called statically so indicate it is. (Class-System.php)

! No need for the loadUserSettings function any more, might as well just do it where it needs to be done. (Load.php, index.php, SSI.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/index.php
2177
Features / Re: Badges and the displaying thereof
« on December 22nd, 2012, 10:16 PM »
Well, it was abandoned because of the author having personal issues to deal with and he just disappeared after that.

I'm not sure that what we have right now is exactly the equal of Stars and Badges, but I'm not sure that's necessarily a bad thing. You don't have quite the flexibility that S&B gives, but there is enough for most cases.
2178
The Pub / Re: Getting ready for an alpha release: WeCSS/Wess improvements
« on December 22nd, 2012, 07:47 PM »
Quote
Hey I caught you posting your commit to another board and then merging it before I had time to do it eheh ;)
I've been doing that for ages.
Quote
Also, while we're at it... Maybe we should also move $user_settings into we::$settings..? (Or something with another name, in case it's confusing.)
Well, I've thought before about removing that entirely, but it serves an interesting use that loadMemberData doesn't; it allows for putting any columns or values into the members table and retrieving it for the current user essentially for free. I would encourage it to be part of the we object somewhere, we::$settings maybe, but don't forget that we also need to contend with $options which is also user-centric.

I'd probably find another name for it, but not sure what.
2179
Features / Re: New revs
« on December 22nd, 2012, 07:39 PM »
(11 files, 2KB)

Revision: 1806
Author: arantor
Date: 22 December 2012 18:37:58
Message:
! Bits and pieces for the changes to banning. Just so that I have everything in sync with how it all works now and that I don't have *everything* to commit all at once. Remember: is_activated is going to be more than 20 for bans now, not more than 10. (wedge_api.php, Class-System.php, ManageMembers.php, Profile-Actions.php, Profile-View.php, Security.php, Subs-Auth.php, Subs-Login.php, Subs-Members.php, Subs-Post.php, Suggest.php)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/other/tools/wedge_api.php
2180
The Pub / Re: Getting ready for an alpha release: WeCSS/Wess improvements
« on December 22nd, 2012, 05:37 PM »
It's probably going to be OK - and we can always do profiling later on to figure out where the issues are if need be.
2181
The Pub / Re: Getting ready for an alpha release: WeCSS/Wess improvements
« on December 21st, 2012, 11:26 PM »
Well, $context['user'] is basically a link to $user_info,

Most of the time that we::$user is set anywhere, that would usually imply the we object should be doing that itself rather than something outside setting it.
2182
The Pub / Re: Getting ready for an alpha release: WeCSS/Wess improvements
« on December 21st, 2012, 08:29 PM »
I tend to think of everything as functions one way or another ;)
2183
The Pub / Re: Getting ready for an alpha release: WeCSS/Wess improvements
« on December 21st, 2012, 07:43 PM »
Don't worry about compatibility. This is strictly about cleanliness vs performance, and cleanliness is better IMO so if you're feeling up for it, get rid of it for good.

Yes, calling a static function is not cheap but I don't believe it's significantly slower than calling a normal function.
2184
Features / Re: Badges and the displaying thereof
« on December 21st, 2012, 07:35 PM »
Yeah, there's a mod for it but it's not particularly nice and long since unsupported by its author.
2185
The Pub / Re: Getting ready for an alpha release: WeCSS/Wess improvements
« on December 21st, 2012, 07:28 PM »
There aren't that many is_ entries.

query_see_board and all its friends are actually only really used in loadUserSettings and possibly loadPermissions - once they're defined, they're registered to the wesql class and that's pretty much it.
2186
The Pub / Re: Getting ready for an alpha release: WeCSS/Wess improvements
« on December 21st, 2012, 06:19 PM »
Yeah, I'd say that was probably OK ;)
2187
Off-topic / Re: How to Apply Thermal Paste the Kentucky Way
« on December 21st, 2012, 01:04 AM »
It was a little bit defensive - but only a little.
2188
Off-topic / Re: How to Apply Thermal Paste the Kentucky Way
« on December 21st, 2012, 12:34 AM »
Heh, I can understand that. After all, the person in question was not born in Kentucky... so it's sort of a moot point. I get where the joke's going though.
2189
Off-topic / Re: How to Apply Thermal Paste the Kentucky Way
« on December 21st, 2012, 12:00 AM »
Hey, I let someone in Kentucky modify my laptop - and it worked better than ever before!
2190
The Pub / Re: Getting ready for an alpha release: WeCSS/Wess improvements
« on December 20th, 2012, 09:43 PM »
Note for later: inside allowedTo(), make sure to statically store the response from we::is_admin(), because it will be faster than making the function round trip every time.