Wedge

20 files, 4KB

Revision: 1821
Author: arantor
Date: 01 January 2013 17:23:05
Message:
! Clean-up of legacy code. (ManageBoards.php, ManageMembergroups.php, ManageNews.php, ManagePermissions.php, ManageSmileys.php)

! Add the membergroups settings to the admin search. (ManageMembergroups.php, Admin.php)

! Fix collision with jQuery UI and Wedge's menu by renaming Wedge's menu (so that other plugin authors can use jQuery UI without problems). (GenericMenu.template.php, index.template.php, script.js)

! Drop the old group key option from the theme settings, convert it to a normal setting and inherit the sorting from the other sources. (Settings.template.php, Boards.php, Home.php, ManageMembergroups.php, Welcome.php, SSI.php, Subs-Membergroups.php, InfoCenter.template.php, language files: Help, ManageMembers, Themes)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/Themes/default/scripts/script.js

Random question: should the membergroup legend use the same ordering? I'm thinking the answer should be yes.

4 files, 1 added, 221KB[1]

Revision: 1820
Author: arantor
Date: 01 January 2013 04:56:49
Message:
! UI for customising badge order and visibility. It's not perfect, it could use some UI loving in places (e.g. replacing the little handle square with something nicer), but it works and doesn't throw errors. As stated elsewhere, yes, it adds a complete copy of jQuery UI to the repo, but 1) this is only used in the admin area, not every page load, and 2) it means that if others do want to use it in their own plugins, it's available. (ManageMembergroups.php, ManageMembergroups.template.php, mana.css, jquery-ui-1.8.24.js, ManageMembers language file)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Added : /trunk/Themes/default/scripts/jquery-ui-1.8.24.js
Modified : /trunk/Themes/default/skins/mana.css

1.	This is almost entirely due to jQuery UI.

So I spent some time experimenting, knowing how it was set up, knowing how it was implemented I made some changes to allow for configuration of order - that was earlier today.

Now the UI. Yes, this uses jQuery UI. If someone wants to write a smaller version of ui.sortable, fine, but I'm happy with this working the way it does.

The idea is this way you can configure the order by dragging the badges around, and you can set whether badges are visible all the time, or whatever.

That's the thing, I'm not really the delayed gratification type. I like to see visible signs of progress as I go. The thought of spending two weeks staring at a piece of crap code[1] and without anything to show for it except a strong dislike of anyone else's code... yeah, it's as frustrating as it sounds.

After two weeks of attacking it, stripping it down to half size, I realised it could be done further but it would at that point be quicker just to start fresh, which I did.

1.

In his defence, he's written it as a C-style PHP script, not as a PHP destined one, so using p_ and v_ prefixes to indicate that things are pointers and local vars, not to mention dancing around returning 1 and 0 everywhere rather than actually returning values from functions. But it's still frustrating to have to clean up, especially the crazy ass indentation.

Well, I found another bug that I've caused by my removal of loadUserSettings, which I've fixed locally, but ever since we was introduced, stylesheets are compiled but there's nothing browser specific in them, meaning menus don't have a background (which makes then practically unusable), the error log counter etc. is invisible, the background to the page is not a nice gradient but instead just blue, etc.

As far as my last point goes, yes, I could just ignore the whole package thing and just remove the add plugin setup, instead of faffing around understanding the zip format and making a nice class instead of the crap I found online (I think you'd rather I committed something around 80KB instead of a 199KB library, for example) and I'm just pissed off with how much work has gone into it with no visible benefits yet.

Given that it appears to be run through the LSB code which is 5.3+ only and it's even specifically referred to in the Zend PHP 5.3 certification as such...

The maximum is 30 days, yes. That just seemed like a meaningful value.Start new topics on the bits you're not clear on. As I said, the ban stuff is... unfinished.Considering that I totally rewrote how the questions work between how SMF did it and how Wedge does it, the odds of it keeping an SMF bug are somewhat limited...