Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
2026
Plugins / Re: Passworded Boards
« on January 9th, 2013, 06:44 AM »
Sure, that's a given, but what I'm thinking is a plugin that is not aware of password boards will potentially not respect it... I don't know how it works but the screenshots seem to suggest query_enter_board otherwise grants access, so a plugin that does as it should and uses QEB is going to be able to access things even without the password.
2027
Features / Re: New revs
« on January 9th, 2013, 05:53 AM »
(3 files, 2KB)
Revision: 1834
Author: arantor
Date: 09 January 2013 04:51:49
Message:
! Supporting testing of IP addresses in ban system. Still not finished, but this is the next bit. (Security.php)
! First soft ban support, disabling search if the user is soft banned. Yes, even for IP addresses. Yes, that's right, I actually gave in and allowed Annoy User support for IP addresses. There. (Search.php, Search2.php, Security.php)
----
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Security.php
Revision: 1834
Author: arantor
Date: 09 January 2013 04:51:49
Message:
! Supporting testing of IP addresses in ban system. Still not finished, but this is the next bit. (Security.php)
! First soft ban support, disabling search if the user is soft banned. Yes, even for IP addresses. Yes, that's right, I actually gave in and allowed Annoy User support for IP addresses. There. (Search.php, Search2.php, Security.php)
----
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Security.php
2028
Plugins / Re: Passworded Boards
« on January 9th, 2013, 05:37 AM »
You did a good job, be proud of it! :)
The only downside I can think of doing it that way is that other plugins won't necessarily behave. If it's enforced by munging query_ magic, other plugins can't help but behave.
It's sort of why I've been thinking it might have to be considered as core unless we stay resolute and firm against the people who think it's a good idea!
The only downside I can think of doing it that way is that other plugins won't necessarily behave. If it's enforced by munging query_ magic, other plugins can't help but behave.
It's sort of why I've been thinking it might have to be considered as core unless we stay resolute and firm against the people who think it's a good idea!
2029
Features / Re: New revs
« on January 9th, 2013, 04:33 AM »
(3 files, 1KB)
Revision: 1833
Author: arantor
Date: 09 January 2013 03:32:36
Message:
! Renamed the spam_settings hook to settings_spam because other pages are going to be hookable and they should really have a consistent naming structure. (ManagePlugins.php, ManageSettings.php)
! Speaking of which, ban settings are also hookable, through the settings_bans hook. (ManageBans.php, ManagePlugins.php)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Revision: 1833
Author: arantor
Date: 09 January 2013 03:32:36
Message:
! Renamed the spam_settings hook to settings_spam because other pages are going to be hookable and they should really have a consistent naming structure. (ManagePlugins.php, ManageSettings.php)
! Speaking of which, ban settings are also hookable, through the settings_bans hook. (ManageBans.php, ManagePlugins.php)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
2030
Plugins / Re: Passworded Boards
« on January 9th, 2013, 02:59 AM »
As I said in my thoughts, I'm jealous of this. The UI is so elegant (I'm assuming you didn't try to fix up feeds? Don't know about search.)
Not sure how I would have done it had I attempted it, I think I'd have skipped trying to show the nice UI and simply pretended the board didn't exist (user group can see, but cannot enter) and done it by having the plugin fudge query_enter_board and query_see_topic if necessary afterwards.
I did consider adding it as a core feature for those who feel they need it, but I think it's better as a plugin, and if it's like this, it's a great job :)
Not sure how I would have done it had I attempted it, I think I'd have skipped trying to show the nice UI and simply pretended the board didn't exist (user group can see, but cannot enter) and done it by having the plugin fudge query_enter_board and query_see_topic if necessary afterwards.
I did consider adding it as a core feature for those who feel they need it, but I think it's better as a plugin, and if it's like this, it's a great job :)
2031
Archived fixes / Re: Jumpy layout.
« on January 9th, 2013, 02:23 AM »
I can actually reproduce it on very rare occasion in Chrome. I've only thought it's actually related to the way the browser handles the radial gradient, because it's always looked to me as though it's moving in a circle fashion to get into position.
2032
Archived fixes / Re: Jumpy layout.
« on January 9th, 2013, 01:24 AM »
Does it happen in other browsers?
And, no, it really won't become the 'main browser' on Windows. As it stands IE has been overtaken by Chrome more than once...
And, no, it really won't become the 'main browser' on Windows. As it stands IE has been overtaken by Chrome more than once...
2033
Archived fixes / Re: Jumpy layout.
« on January 9th, 2013, 12:40 AM »
It's done that since forever, fairly sure it's deliberate? (Nao would know.)
Certainly there's magic involved in the sidebar and whether you're using the browser at more or less than 1000 pixels (less than that, the sidebar is collapsed to under the posts)
Certainly there's magic involved in the sidebar and whether you're using the browser at more or less than 1000 pixels (less than that, the sidebar is collapsed to under the posts)
2034
Archived fixes / Re: Admin Centre item goes to wrong place?
« on January 8th, 2013, 11:08 PM »
Aside from the third-party bit, I'm not convinced what Tapatalk offers is any better than a good mobile theme in the first place... other than having a consistent UI across sites.
2036
Features / Re: New revs
« on January 8th, 2013, 05:21 AM »
(1 file, 1KB)
Revision: 1831
Author: arantor
Date: 08 January 2013 04:21:06
Message:
! Really not sure how I missed this one. The code isn't tested, that should be obvious, but mostly because to properly test it, I need to finish rewriting it >_> (Security.php)
----
Modified : /trunk/Sources/Security.php
Revision: 1831
Author: arantor
Date: 08 January 2013 04:21:06
Message:
! Really not sure how I missed this one. The code isn't tested, that should be obvious, but mostly because to properly test it, I need to finish rewriting it >_> (Security.php)
----
Modified : /trunk/Sources/Security.php
2037
Features / Re: New revs
« on January 8th, 2013, 05:20 AM »
(7 files, 15KB)
Revision: 1830
Author: arantor
Date: 08 January 2013 04:18:25
Message:
! Update the manage-mail area to use a proper button in place of a bare link, fixes a side issue with event-overridden links, but also looks more consistent. (ManageMail.php, ManageMail.template.php)
! The is-email-banned checks now should be querying the new bans system rather than the old, and it seems to work for both soft and hard bans (soft bans just prevent registration and guest posting using them, hard bans properly ban the session and leave a nice little banned cookie around), for all kinds of crazy things (exact match, wildcarded, entire domains, including handling GMail style dot removal and label use, and entire TLDs or parts thereof). Of course, the big work is done in Security.php, but the other places had their calls updated; we don't differentiate between 'cannot register' and 'cannot guest post' in terms of bans these days, it's really not needed. There is still work to do with the ban system; IP addresses need filtering out too, and then I need to replace updateBanMembers() with a version that works in the new banned world, but it's getting there. Then it needs MOAR testing. (Activate.php, Post2.php, Report.php, Security.php, Subs-Members.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ManageMail.template.php
There is a lot left to do as I indicated, but most of the updateBanMembers calls were done in the admin panel where I can field it more easily; there's no need to call it when evaluating a ban for regular members as such - only need to evaluate the current user and fix their ban status.. ohcrap a typo I just realised.
Revision: 1830
Author: arantor
Date: 08 January 2013 04:18:25
Message:
! Update the manage-mail area to use a proper button in place of a bare link, fixes a side issue with event-overridden links, but also looks more consistent. (ManageMail.php, ManageMail.template.php)
! The is-email-banned checks now should be querying the new bans system rather than the old, and it seems to work for both soft and hard bans (soft bans just prevent registration and guest posting using them, hard bans properly ban the session and leave a nice little banned cookie around), for all kinds of crazy things (exact match, wildcarded, entire domains, including handling GMail style dot removal and label use, and entire TLDs or parts thereof). Of course, the big work is done in Security.php, but the other places had their calls updated; we don't differentiate between 'cannot register' and 'cannot guest post' in terms of bans these days, it's really not needed. There is still work to do with the ban system; IP addresses need filtering out too, and then I need to replace updateBanMembers() with a version that works in the new banned world, but it's getting there. Then it needs MOAR testing. (Activate.php, Post2.php, Report.php, Security.php, Subs-Members.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ManageMail.template.php
There is a lot left to do as I indicated, but most of the updateBanMembers calls were done in the admin panel where I can field it more easily; there's no need to call it when evaluating a ban for regular members as such - only need to evaluate the current user and fix their ban status.. ohcrap a typo I just realised.
2038
Archived fixes / Re: Remove drafts
« on January 7th, 2013, 11:43 PM »
I'm just replacing the mail queue one now, I realise it doesn't solve the problem but it's been bugging me for ages that it's inconsistent visually ;)
Also, what do you mean 'far away UK'? It's an hour behind you :P
Also, what do you mean 'far away UK'? It's an hour behind you :P
2039
Archived fixes / Re: Remove drafts
« on January 7th, 2013, 11:38 PM »
After trawling the source, I can only find one other place where we use a 'return ask' as the event on a text link, and that fails too. There are plenty of return reqWin() events, but that's cool because we want to override those.
There is an instance of a window.open but I'm sure that'll get replaced eventually anyway (it's in the moderation centre)
I'll note there are places there probably *should* be an extra such event (e.g. marking everything read) anyway.
Makes me wonder whether instead we should just be using buttons for anything like that though.
There is an instance of a window.open but I'm sure that'll get replaced eventually anyway (it's in the moderation centre)
I'll note there are places there probably *should* be an extra such event (e.g. marking everything read) anyway.
Makes me wonder whether instead we should just be using buttons for anything like that though.
2040
Features / Re: New revs - Public comments
« on January 7th, 2013, 11:30 PM »
Then it's fine :)
I'm looking at it in terms of the modder approach; I want to be able to just build stuff and rely on it working, I don't want to have to debug a ton of stuff to write a simple plugin - it sort of defeats the purpose ;)
I'm looking at it in terms of the modder approach; I want to be able to just build stuff and rely on it working, I don't want to have to debug a ton of stuff to write a simple plugin - it sort of defeats the purpose ;)