Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
1966
Plugins / Re: Post Fields
« on January 13th, 2013, 07:32 PM »
Well, we did explain how it was going to work ages ago when we accepted the fact that themes cannot have total control over everything if you ever have any illusions of having plugins ;)
OK, here's the run down: everything's built out of subtemplates. We have not yet established whether we're going to allow separate physical themes that can replace the subtemplates with their own, though there are certain things that are controllable by the themes - for example, the markup that makes cat_bar and title_bar areas is not true markup; templates output <we:cat> and <we:title> for those, and the skin itself can set what HTML should be used there.
A plugin provides its own subtemplates for things it wants to use where not covered by any of the existing subtemplates in the system. It should of course use the same classes and markup as the default subtemplates, and a skin has all the ability of CSS to restyle that, just as it would be able to reskin the default theme itself.
OK, here's the run down: everything's built out of subtemplates. We have not yet established whether we're going to allow separate physical themes that can replace the subtemplates with their own, though there are certain things that are controllable by the themes - for example, the markup that makes cat_bar and title_bar areas is not true markup; templates output <we:cat> and <we:title> for those, and the skin itself can set what HTML should be used there.
A plugin provides its own subtemplates for things it wants to use where not covered by any of the existing subtemplates in the system. It should of course use the same classes and markup as the default subtemplates, and a skin has all the ability of CSS to restyle that, just as it would be able to reskin the default theme itself.
1967
Plugins / Re: Post Fields
« on January 13th, 2013, 06:57 PM »
It's not set up like that, the template has nothing whatsoever to do with.
Each page is made up of a number of small units, the new area is a new sub-template added in between the other sub-templates. It's all controlled by the plugin saying 'hey, I want to add this sub-template to the list of templates, before that one/after that one'.
The problem with doing it any other way is that it gets very unwieldy very quickly. Either you make the theme capable of handling almost anything you can imagine, which makes the theme slow and massive, or you allow plugins to take responsibility for their own display which is what we're doing.
Each page is made up of a number of small units, the new area is a new sub-template added in between the other sub-templates. It's all controlled by the plugin saying 'hey, I want to add this sub-template to the list of templates, before that one/after that one'.
The problem with doing it any other way is that it gets very unwieldy very quickly. Either you make the theme capable of handling almost anything you can imagine, which makes the theme slow and massive, or you allow plugins to take responsibility for their own display which is what we're doing.
1968
Plugins / [Plugin] Re: Notifications system (1.0)
« on January 13th, 2013, 03:52 PM »
I think it's kind of hard to judge this without actually trying to make something myself with it.
Mind you, I've been of the opinion that we might need to add something along these lines into the core sometime.
Mind you, I've been of the opinion that we might need to add something along these lines into the core sometime.
1969
The Pub / Re: I just discovered a trick
« on January 13th, 2013, 03:02 PM »
The other thing is to add an item of text|description though this makes me wonder about blocking | in things like board names that can be made into selectors
1971
The Pub / Re: Microsoft to turn off Windows Messenger on 15 March
« on January 13th, 2013, 06:21 AM »
Well, there is, but it doesn't show their email address as such.
It's a tough one to call, but it's late here and I think I'm going to sleep on this before trying to figure out exactly what to do with it.
It's a tough one to call, but it's late here and I think I'm going to sleep on this before trying to figure out exactly what to do with it.
1972
The Pub / Re: Microsoft to turn off Windows Messenger on 15 March
« on January 13th, 2013, 06:07 AM »
Also, just thought about this... what if people use it to indicate their email in case people want to contact them? Would that not necessarily be a valid reason to leave it?
Just instead direct it to point to a mailto link?
Just instead direct it to point to a mailto link?
1973
Features / Re: New revs
« on January 13th, 2013, 05:58 AM »
(3 files, 2KB)
Revision: 1844
Author: arantor
Date: 13 January 2013 04:55:24
Message:
! OK, Nao, I'm sorry, but I couldn't let this one go on any more. Yes, it adds 140 bytes or thereabouts to the MAIN CSS file, but I couldn't figure out a shorter way of doing it (didn't bench it with gzip) and it does add 4 bytes per link affected (which is not ALL links, but only links with bare URLs). I was getting fed up of the side bugs this left behind with respect to URLs in posts being copy/pasted and subsequently broken, and the fact that email notifications of posts or PMs would be broken by the stripping of the tags, so now we shorten URLs with CSS3 instead. There is a minor optimisation of the parse loop and a little other reduced code. Personally I think it's worth it (especially as I actually prefer the way the layout puts the ellipsis at the end rather than in the middle) (install.sql, Subs-BBC.php, index.css)
----
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/root/install.sql
@ I don't *really* mind if this is reverted but I'd rather have CSS behaviour than hard-coded behaviour that is otherwise unalterable. Also note that iurl and url behaviours are now back in step (it would have been possible to post a long URL with iurl tags that wouldn't get shortened for display)
Revision: 1844
Author: arantor
Date: 13 January 2013 04:55:24
Message:
! OK, Nao, I'm sorry, but I couldn't let this one go on any more. Yes, it adds 140 bytes or thereabouts to the MAIN CSS file, but I couldn't figure out a shorter way of doing it (didn't bench it with gzip) and it does add 4 bytes per link affected (which is not ALL links, but only links with bare URLs). I was getting fed up of the side bugs this left behind with respect to URLs in posts being copy/pasted and subsequently broken, and the fact that email notifications of posts or PMs would be broken by the stripping of the tags, so now we shorten URLs with CSS3 instead. There is a minor optimisation of the parse loop and a little other reduced code. Personally I think it's worth it (especially as I actually prefer the way the layout puts the ellipsis at the end rather than in the middle) (install.sql, Subs-BBC.php, index.css)
----
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/root/install.sql
@ I don't *really* mind if this is reverted but I'd rather have CSS behaviour than hard-coded behaviour that is otherwise unalterable. Also note that iurl and url behaviours are now back in step (it would have been possible to post a long URL with iurl tags that wouldn't get shortened for display)
1974
The Pub / Re: Microsoft to turn off Windows Messenger on 15 March
« on January 13th, 2013, 05:52 AM »
So what's the allowed format for that username? If I can find that out, plus a place where it should link to, I can add Skype and drop MSN with minimal effort.
1975
The Pub / Re: Microsoft to turn off Windows Messenger on 15 March
« on January 13th, 2013, 05:37 AM »
Did you check out that fun part of the Custom Profile Fields? Aside from the fact I moved it, I gutted the original fixed fields in SMF and made them all into templates in the CPF, meaning that you can add whichever ones you want, easily, with sane presets on everything.
Removing the MSN entry is basically removing a few lines of code and the image, adding the Skype one is marginally more effort since I need to know what the format should be for Skype items (is it just an email address?)
Removing the MSN entry is basically removing a few lines of code and the image, adding the Skype one is marginally more effort since I need to know what the format should be for Skype items (is it just an email address?)
1976
The Pub / Re: Microsoft to turn off Windows Messenger on 15 March
« on January 13th, 2013, 04:44 AM »
Yes, I saw that. All I'm seeing is 'I need to drop the template for MSN in the Custom Fields and add a Skype template instead'.
1977
Features / Re: New revs
« on January 13th, 2013, 04:18 AM »
(1 file, 5KB)
Revision: 1843
Author: arantor
Date: 13 January 2013 03:17:25
Message:
! Added another interesting nasty that's crossed my radar to the block list. Seems to be an XRumer knock-off that's doing the rounds. (Security.php)
! Removal of the old ban trigger hit updater. We're not logging ban trigger hits any more, because it wasn't used much if at all by most users, and when you have users who are a pain, it's best to not spend any more time on them than you have to. (Security.php)
! Ban system can now apply bans to hostnames if hostname lookups are enabled. (Security.php)
----
Modified : /trunk/Sources/Security.php
@ I know it's all one file but they're thematically separate commits, just packaged for better value and Wedgey goodness. Think I might treat myself to a cupcake for this one.
Revision: 1843
Author: arantor
Date: 13 January 2013 03:17:25
Message:
! Added another interesting nasty that's crossed my radar to the block list. Seems to be an XRumer knock-off that's doing the rounds. (Security.php)
! Removal of the old ban trigger hit updater. We're not logging ban trigger hits any more, because it wasn't used much if at all by most users, and when you have users who are a pain, it's best to not spend any more time on them than you have to. (Security.php)
! Ban system can now apply bans to hostnames if hostname lookups are enabled. (Security.php)
----
Modified : /trunk/Sources/Security.php
@ I know it's all one file but they're thematically separate commits, just packaged for better value and Wedgey goodness. Think I might treat myself to a cupcake for this one.
1978
Other software / Re: Discussing Wedge on simplemachines.org
« on January 13th, 2013, 01:06 AM »AFAIK I was the first dev that was purely there for the design skills, to focus on that, and primary because I made the Core and Curve designs - but ALSO because I had proved my PHP skills in writing TinyPortal.
That cannot be said for recent years team jumping, and its a shame. It proves my point that these teams and the desire to be higher up kills the peer mentality, it makes people look more at what they ARE(as in position) than it what they CAN.
1979
Archived fixes / Re: Error in Error log?
« on January 13th, 2013, 01:03 AM »
There's two consequences to SMF's original bug. The point of the ../ test is to prevent people going up and outside the SMF tree to view files, e.g. viewing non SMF files. Then the other test is to ensure that files requested are inside the SMF tree, either inside $boarddir or $sourcedir, as people can and do have the Sources dir outside webroot. The idea is that you need both tests to prevent people doing things like /home/user/smf/../../../etc/passwd - which would be fairly bad if it could be exploited. It can be... defeated... under certain circumstances which is a type of directory traversal.
There is a secondary bug that the Settings.php can be accessed by this, when it shouldn't.
I fixed it to force use of realpath to canonicalise everything so there's no ability to use ../ to escape anything. The thing is, on my localhost which uses current SVN, it works just fine. Is your $sourcedir outside of where $boarddir is?
Thing is, by definition $boarddir is the parent of templates and it should allow for that...?
There is a secondary bug that the Settings.php can be accessed by this, when it shouldn't.
I fixed it to force use of realpath to canonicalise everything so there's no ability to use ../ to escape anything. The thing is, on my localhost which uses current SVN, it works just fine. Is your $sourcedir outside of where $boarddir is?
Thing is, by definition $boarddir is the parent of templates and it should allow for that...?
1980
Archived fixes / Re: Gallery and Permissions Error
« on January 13th, 2013, 12:37 AM »
Could be that the album is just configured oddly...