This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
1681
Features: Forward thinking / Re: HTML5 support
« on February 6th, 2013, 02:16 AM »
Essentially it was some nonsense about automated tools generating code and if there was a generator indicated, it would relax certain validation rules or something. Nao mentioned it, I just threw my hands up with a WTF gesture and am presently waiting for the powers that be to get their heads out of their posteriors.
Yes, I'm sure there are errors. But hey, it's alpha software, with new commits most days, there ARE going to be issues, especially when using a tool that by its own admission is probably buggy, against a standard that won't be a standard for another year at least if ever...
Yes, I'm sure there are errors. But hey, it's alpha software, with new commits most days, there ARE going to be issues, especially when using a tool that by its own admission is probably buggy, against a standard that won't be a standard for another year at least if ever...
1682
Features: Forward thinking / Re: HTML5 support
« on February 6th, 2013, 02:05 AM »
OK so I hit up the w3.org validator which by its *own* admission is experimental.Quote Yeah, there isn't. We do it at header level (the best place for it)
All the rest are img elements not having (empty) alt attributes. Which is the issue we're waiting for them to change their mind on again. Essentially the argument relates to whether an alt attribute is 'required' or merely 'recommended' (but thus optional), and when a meta generator tag is present, it changes whether it is required or not. But they're only just opening a discussion to discuss reconsidering their position, so it might take a while.
No Character encoding declared at document level
All the rest are img elements not having (empty) alt attributes. Which is the issue we're waiting for them to change their mind on again. Essentially the argument relates to whether an alt attribute is 'required' or merely 'recommended' (but thus optional), and when a meta generator tag is present, it changes whether it is required or not. But they're only just opening a discussion to discuss reconsidering their position, so it might take a while.
1683
Features: Forward thinking / Re: HTML5 support
« on February 6th, 2013, 02:03 AM »
According to what validator, exactly?
Have they changed their minds (again) about what is valid and what isn't? As it is, we're waiting for them to change their minds, yet again, about certain attributes being required when a certain meta tag is (or is not) present.
Have they changed their minds (again) about what is valid and what isn't? As it is, we're waiting for them to change their minds, yet again, about certain attributes being required when a certain meta tag is (or is not) present.
1684
Features: Forward thinking / Re: jQuery support
« on February 5th, 2013, 04:43 PM »
They appear to have agreed with you about the bug. :)
1685
Development blog / Re: It only took two guys two years...
« on February 5th, 2013, 02:58 AM »
I would strongly suggest not using WP with Wedge. The two will not play nicely and in all honesty there will end up being little reason to have WP when Wedge will be able to cover the bases (and do it *much* more efficiently)
1686
Features / Re: New revs
« on February 5th, 2013, 12:11 AM »
(4 files, 9KB)
Revision: 1901
Author: arantor
Date: 04 February 2013 23:10:51
Message:
+ You can now like thoughts. It may require some more testing and likely some visual tweaks (e.g. making the link smaller maybe) but aside from slight ugliness of the code, it seems to work as expected. (Display.php, Home.php, Like.php, Home.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/Home.template.php
Revision: 1901
Author: arantor
Date: 04 February 2013 23:10:51
Message:
+ You can now like thoughts. It may require some more testing and likely some visual tweaks (e.g. making the link smaller maybe) but aside from slight ugliness of the code, it seems to work as expected. (Display.php, Home.php, Like.php, Home.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/Home.template.php
1687
Features: Forward thinking / Re: jQuery support
« on February 4th, 2013, 11:27 PM »So... This is a totally undocumented bug. I don't know if I should care to 'report' it. I've read a bug report from v1.8 saying that the jQuery team has deprecated { async: false } in $.ajax, just because they didn't like that, basically... Apparently to them, it's important that 'A'jax is always 'A'synchronous, so synchronous calls should be done from a function called $.sjax... Lol. Well, anyway, the stuff is still there, and usable and all, but it simply doesn't return a proper responseXML. Only a responseText. So I thought about it and looked into the Wedge codebase, this is the only place where I'm doing a synchronous call, and turning it into an asynchronous call would be disastrous. So, you know what I did...?
I just rewrote Ajax.php to return a simple text string. Voilà. And it makes script.js a bit shorter, too... It's not as clean as before, but anyway we already discussed returning JSON instead of XML for all calls, haven't worked on that because it's a lot of work for a result that may not be that rewarding, but at least in that particular case, getting rid of XML felt good... ;)
Posted: February 4th, 2013, 11:25 PM
Also, you're not the Wesley Crusher of gzipping, you're the Data of gzipping. Being the Wesley Crusher makes you the smart-arse no-one likes (and one person even told him to his face that it's a good thing he's cute otherwise he could be obnoxious), whereas being the Data of gzipping means it's cool to be intense about it.
1688
About 50 minutes ago I realised it was 40 minutes until I should be going to bed, and I wondered how much of this I could conceivably pull off in 40 minutes.
Well, I got entrenched in a little bit more debugging than I'd hoped, but here's what I managed in that time. (The DB stuff works, the changes to the like handler work, now just need to add a button for it :whistle: (Nao, can you add the thumb up and maybe even thumb down icons to the icons that can be used in buttons please? I don't like touching that, it's an optimisational thing) Heck even the likes popup works.)
Code is a shade ugly and there's some slightly nasty abuses going on that proper refactoring should avoid (like where the likes handling takes place, right now Home just wholesale includes Display.php to get the likes handler)
Well, I got entrenched in a little bit more debugging than I'd hoped, but here's what I managed in that time. (The DB stuff works, the changes to the like handler work, now just need to add a button for it :whistle: (Nao, can you add the thumb up and maybe even thumb down icons to the icons that can be used in buttons please? I don't like touching that, it's an optimisational thing) Heck even the likes popup works.)
Code is a shade ugly and there's some slightly nasty abuses going on that proper refactoring should avoid (like where the likes handling takes place, right now Home just wholesale includes Display.php to get the likes handler)
1689
Features / Re: New revs
« on February 4th, 2013, 04:07 AM »
(14 files, 6KB)
Revision: 1896
Author: arantor
Date: 04 February 2013 03:05:37
Message:
! Legacy code, missing check being called properly, stupid function not working as intended. (Security.php)
! One less variable injected inline. Potentially more could be done here but it's not pleasant. (Post.template.php, post.js)
! Profile now displays banned status properly, and some language cleanup as a result. (Profile-View.php, Profile.template.php, language files: index, Profile)
! Deleting accounts should clean up matching bans that would no longer apply. (Subs-Members.php)
! Newsletters shouldn't be touching the existing table, as such. If they're banned through username or their email, their account should be full banned anyway, no need to requery for that stuff, at least not there. (ManageNews.php)
! The old ban tables are now gone. Good bye. Good riddance. (install.sql, Class-DBPackages.php, ManageMaintenance.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/post.js
Modified : /trunk/root/install.sql
@ Yes, this is almost entirely ban related. But since each of the different bits is a small part of the whole I delineated it, more for my reference later. (Thumbs down for Caesarness: the tables were not to survive. They have been tossed to the lions, who found them a bit chewy.)
Revision: 1896
Author: arantor
Date: 04 February 2013 03:05:37
Message:
! Legacy code, missing check being called properly, stupid function not working as intended. (Security.php)
! One less variable injected inline. Potentially more could be done here but it's not pleasant. (Post.template.php, post.js)
! Profile now displays banned status properly, and some language cleanup as a result. (Profile-View.php, Profile.template.php, language files: index, Profile)
! Deleting accounts should clean up matching bans that would no longer apply. (Subs-Members.php)
! Newsletters shouldn't be touching the existing table, as such. If they're banned through username or their email, their account should be full banned anyway, no need to requery for that stuff, at least not there. (ManageNews.php)
! The old ban tables are now gone. Good bye. Good riddance. (install.sql, Class-DBPackages.php, ManageMaintenance.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/post.js
Modified : /trunk/root/install.sql
@ Yes, this is almost entirely ban related. But since each of the different bits is a small part of the whole I delineated it, more for my reference later. (Thumbs down for Caesarness: the tables were not to survive. They have been tossed to the lions, who found them a bit chewy.)
1690
Features / Re: New revs - Public comments
« on February 3rd, 2013, 11:00 PM »@Lorenzo> I'm surprised a CDN not advertised on jquery.com would offer it..? Anyway, isn't this only for cloudflare customers?
Who's going to change it anyway..? A plugin? Bad semantics, bad karma!
e.g. the draft auto-save, things like that.
Haven't looked at all the functions that could benefit from being moved there.
Yep yep yep, my you're scaring me! :lol:
- txt.done in spellcheck.js -- however, I'd advise against adding it for one reason: if you're not using the default language, you'll get another instance of your language name in the spellcheck JS URL,
I don't think there's anything preventing that one from being passed on.
- the YUI uploader -- we need to rewrite it to use HTML5, by the way...
- the upshrink description for toggles could be a 'default' instead of being explicitly set (it's the only text string that's actually sent to them, except from a few "-" here and there.) Either with something like altExpanded: 'default', or not setting it at all in the HTML -- although we'd have to ensure that it 'works' on all toggles that don't specify an alt. It's important to check on this one -- it's on every single page! :)
- message_txt_delete in wedgeAttachSelect is a given :)
- register.js always uses the same regTextStrings, with the Register page adding a few strings compared to the Reminder page. We could, instead of sending the text strings, send a boolean determining whether register.js will use one set of strings or the other.
Do you want to do them all, or split the job, or let me do them?
Whichever you prefer. Right now I'm busy at work on splitting skeleton stuff anyway.
Posted: February 3rd, 2013, 10:44 PM
* Naoism: comment typos. Also, Pete, you must have a 4K screen if you're able to read that MessageIndex comment without scrolling... ;) (MessageIndex.php, Pin.php)
1691
Features / Re: New revs
« on February 3rd, 2013, 04:29 AM »
(13 modified, 2KB)
Revision: 1893
Author: arantor
Date: 03 February 2013 03:27:05
Message:
! Did I mention that I love the @language embedding into script files? Set a default string from index, set it once and never have to explicitly set it again in any of the multiple places it is called (unless you *really* want to). All this for the 'delete item' help text on the auto suggest... it's the same everywhere, so just embed it in to the suggester as a default! It bugged me, mkay? (all files)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/ManageMedia2.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/scripts/pm.js
Modified : /trunk/Themes/default/scripts/suggest.js
@ And since it's now embedded in the suggest file, it will not only be gzipped and cached, it no longer has to be inlined into all the pages it's in, or declared in those pages where used. I would imagine that's actually a tidy little saving everywhere that uses the auto suggester, all in all. Every little helps.
Revision: 1893
Author: arantor
Date: 03 February 2013 03:27:05
Message:
! Did I mention that I love the @language embedding into script files? Set a default string from index, set it once and never have to explicitly set it again in any of the multiple places it is called (unless you *really* want to). All this for the 'delete item' help text on the auto suggest... it's the same everywhere, so just embed it in to the suggester as a default! It bugged me, mkay? (all files)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/ManageMedia2.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/scripts/pm.js
Modified : /trunk/Themes/default/scripts/suggest.js
@ And since it's now embedded in the suggest file, it will not only be gzipped and cached, it no longer has to be inlined into all the pages it's in, or declared in those pages where used. I would imagine that's actually a tidy little saving everywhere that uses the auto suggester, all in all. Every little helps.
1692
Features / Re: New revs
« on February 3rd, 2013, 03:19 AM »
10 files, 2KB[1]
Revision: 1892
Author: arantor
Date: 03 February 2013 02:19:04
Message:
! Removal of the old ban code. There's still the profile stuff to fix, but this is the old ban panel gone, including cleaning up the language strings as far as I can for now. (I think.) (ManageBans.php, ManageBans.template.php, language files: Admin, Errors, Help, ManageBans)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/Themes/default/languages/ManageBans.french.php
Revision: 1892
Author: arantor
Date: 03 February 2013 02:19:04
Message:
! Removal of the old ban code. There's still the profile stuff to fix, but this is the old ban panel gone, including cleaning up the language strings as far as I can for now. (I think.) (ManageBans.php, ManageBans.template.php, language files: Admin, Errors, Help, ManageBans)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/Themes/default/languages/ManageBans.french.php
| 1. | Massive block delete is very small in SVN terns. |
1693
The Pub / Re: Wedge templating for designers
« on February 3rd, 2013, 12:59 AM »
I can see entirely where you're coming from - I always have been able to. The problem is that your envisioning of it does not tie up to the reality of how it works - even you yourself see that it's impossible for a theme to have total control over mods because of keeping up with mod changes.
There is actually *more* power in Wedge's theme engine than in SMF's, vastly more, and it enables plugins to be more flexible by moving blocks of content around, inserting new blocks of content between them. None of that's changed. And plugins have more ability to play nicely with themes now.
I guess what frustrates me about this topic is that we seem to be retreading the same ground every 6 months and nothing has changed in that time, at least not in the practical world.
Your ideas are grand, but unfortunately I don't see how they can possibly stand up to real world use. That's fine if what you're doing is solely for your own use, when you don't have to care about real world users, but we have to.
Go and look at al the platforms out there, every single forum system has the same problems, and the same problems creep into WordPress too... and I hope you're not going to tell me that WordPress is 'less flexible' than SMF because we both know that's not true either. WP gives theme authors the nearest thing to total control and that causes almost as much of a mess for plugins as what SMF does. More, in some respects, because it can be hard to nail down and make sense of it.
I'm sorry, I have to ask this because it's been bugging me: if you understand we have a firm direction (and one that hasn't changed in over a year, I might add), why keep bringing these things up every few months? You don't want to change our minds, you say, and yet by bringing it up again and again, you're trying to. Or at least, I don't understand why you're bringing it up again and again, when you know it's not going to change.
We did take in to account what you were saying; that's how the template skeleton came into being at all. It was the only way we could think of to find any kind of compromise between the two because we believe the two need to work together - and it's the nearest we've got to that point. I'm sorry that you're so unable to understand that we have to have this compromise between the two but that's the curse of working on something that is intended for widespread distribution, not a hobby project.[1]
There is actually *more* power in Wedge's theme engine than in SMF's, vastly more, and it enables plugins to be more flexible by moving blocks of content around, inserting new blocks of content between them. None of that's changed. And plugins have more ability to play nicely with themes now.
I guess what frustrates me about this topic is that we seem to be retreading the same ground every 6 months and nothing has changed in that time, at least not in the practical world.
Your ideas are grand, but unfortunately I don't see how they can possibly stand up to real world use. That's fine if what you're doing is solely for your own use, when you don't have to care about real world users, but we have to.
Go and look at al the platforms out there, every single forum system has the same problems, and the same problems creep into WordPress too... and I hope you're not going to tell me that WordPress is 'less flexible' than SMF because we both know that's not true either. WP gives theme authors the nearest thing to total control and that causes almost as much of a mess for plugins as what SMF does. More, in some respects, because it can be hard to nail down and make sense of it.
I'm sorry, I have to ask this because it's been bugging me: if you understand we have a firm direction (and one that hasn't changed in over a year, I might add), why keep bringing these things up every few months? You don't want to change our minds, you say, and yet by bringing it up again and again, you're trying to. Or at least, I don't understand why you're bringing it up again and again, when you know it's not going to change.
We did take in to account what you were saying; that's how the template skeleton came into being at all. It was the only way we could think of to find any kind of compromise between the two because we believe the two need to work together - and it's the nearest we've got to that point. I'm sorry that you're so unable to understand that we have to have this compromise between the two but that's the curse of working on something that is intended for widespread distribution, not a hobby project.[1]
| 1. | I do not wish to be rude, but I don't know how else to classify bloQs or ViennaBBS or whatever it is called, it seems like it is a fine hobby project, which is a great thing in itself, but that has never really been our goal with Wedge if we're honest. |
1694
The Pub / Re: Wedge templating for designers
« on February 2nd, 2013, 11:37 PM »
So, essentially, what you're saying is, that as a theme designer, you want to not only control the look and feel of the core but have the theme able to control the look and feel of plugins too. Have ever so much fun with that. There are hundreds of mods on the sm.org mod site... you are potentially saying you want a theme to have the option of supporting each of them, individually, in potential... because there aren't so many issues with performance, or reliability or tracing bugs that can happen with that or anything.
Let's take a practical example. Would you, as a theme developer consider manually replacing the output of - say - the most popular shoutbox, most popular portal, and most popular gallery?
You have a core theme and you have a theme changing the look and feel. Are you seriously going to want to support things like the portal, gallery and shoutbox in the theme?
Do you remember the themes that had custom code just for TP support and how many issues that caused? This is no different in any practical respect...
Let's take a practical example. Would you, as a theme developer consider manually replacing the output of - say - the most popular shoutbox, most popular portal, and most popular gallery?
You have a core theme and you have a theme changing the look and feel. Are you seriously going to want to support things like the portal, gallery and shoutbox in the theme?
Do you remember the themes that had custom code just for TP support and how many issues that caused? This is no different in any practical respect...
1695
Features: Forward thinking / Re: jQuery support
« on February 2nd, 2013, 10:31 PM »
jQuery's documentation has always been a bit sub-par, I thought. Using .prop consistently, if it's an option, would likely be easier.