Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
1636
The Pub / Re: Infinite Scroll
« on February 10th, 2013, 07:00 PM »
Just as a thought, how about a compromise of 'load the next x items AJAXively' as a button, without having to actually go to the next page?
1637
Features / Re: AJAX Likes
« on February 10th, 2013, 06:56 PM »
Guess I need to AJAXify thought likes now too? :angel:
:^^;: Means extra bytes on the front page... since I'd need to put them inside a container, they currently aren't in one the way they were for the post likes. And the code will be different in terms of finding the ID, but that's no biggie.
Posted: February 10th, 2013, 06:40 PM
:^^;: Means extra bytes on the front page... since I'd need to put them inside a container, they currently aren't in one the way they were for the post likes. And the code will be different in terms of finding the ID, but that's no biggie.
1638
Archived fixes / Re: Remove drafts
« on February 10th, 2013, 06:35 PM »
This one is definitely solved ;)
1639
Archived fixes / Re: Admin Centre item goes to wrong place?
« on February 10th, 2013, 06:33 PM »
I've fixed the underlying issue (in case anywhere else wants to define a custom_url for their admin area) and will commit in the next commit.
1640
Archived fixes / Re: Plugin execution
« on February 10th, 2013, 06:23 PM »
OK, so the core bug is fixed, around double language handling.
What say we move the response prefix debate to another thread?
What say we move the response prefix debate to another thread?
1641
Archived fixes / Re: parse_bbc_inline does not process colors
« on February 10th, 2013, 06:22 PM »
The inline parser isn't called much IIRC... every hit seems related to thoughts.
I'd argue we don't need colour there anyway.
I'd argue we don't need colour there anyway.
* Arantor is very tempted to call this WILLNOTFIX.
1642
Archived fixes / Re: Tabs in code tags
« on February 10th, 2013, 06:20 PM »
Guessing this one is solved now.
1643
Archived fixes / Re: Long cache keys make the cache fail.
« on February 10th, 2013, 05:48 PM »
Looking at the cache dir this would appear to be solved now.
1644
Features / Re: Every byte is sacred, every byte is good.
« on February 10th, 2013, 05:12 PM »First dilemma: is it worth adding 30 bytes of (a single download) to ALL users (including guests), to save 70 bytes (PER PAGE) for logged in users?
Right now, the stats are 12 Guests, 4 Users (2 Spiders) -> 10 regular guests to 4 users.
However, 30 bytes to a one-off download to save 70 bytes for registered users, this seems like a very worthwhile saving in total.
Second dilemma: I added an additional trick to save *25 bytes* per page load for *logged in users* who have *not yet set a thought* (that would represent, I think, a majority of them.) Instead of showing "Click here to set your first thought", I'm showing nothing, and then script.js fills in the text by itself. This adds approximately 8 bytes of overhead to the script file. Is it worth adding a single download of 8 bytes for everyone (including guests) to save 25 bytes per page for a majority of members?
1645
Features / Re: Pages: [1] 2 3 styling
« on February 10th, 2013, 03:14 AM »
Something like the following perhaps.
This is a bit more drastic a change, so here's the full .pagesection nav declaration.
Code: [Select]
The link colour is intended to be the same as normal link colour but that's not actually a variable, might be worth making it one in common.css. I just reused post_bg/post_bg2 because it's convenient.
There is a subtle advantage to doing this - the extra spacing is more fat-finger-friendly on mobile.
This is a bit more drastic a change, so here's the full .pagesection nav declaration.
nav
float: left
padding: .3em 0 .3em
a[data-href]
font-weight: 700
a extends .notewarn
@if ie[-9]
background-color: $post_bg2
@else
gradient: $post_bg2, $post_bg
@endif
color: #47a !important
nav > strong extends .notewarn
@if ie[-9]
background-color: #d97b33
@else
gradient: lighten(#d97b33, 10%), darken(#d97b33, 10%)
@endifThe link colour is intended to be the same as normal link colour but that's not actually a variable, might be worth making it one in common.css. I just reused post_bg/post_bg2 because it's convenient.
There is a subtle advantage to doing this - the extra spacing is more fat-finger-friendly on mobile.
1646
Features / Re: Pages: [1] 2 3 styling
« on February 10th, 2013, 03:07 AM »
This is ultimately what I had in mind.
All I've done is modified the CSS, adding this to index.css's declaration of .pagesection nav
Code: [Select]
Then removed the [] from the template. I think it would be nice to apply the same type of styling to the rest of the links.
(The reason 'go down' is like it is, is because it was already defined as strong anyway)
#d97b33 by the way is the colour of the board link, yes, technically I could have used $board_col in the CSS but this is experimental :P
All I've done is modified the CSS, adding this to index.css's declaration of .pagesection nav
strong extends .notewarn
@if ie[-9]
background-color: #d97b33
@else
gradient: lighten(#d97b33, 10%), darken(#d97b33, 10%)
@endifThen removed the [] from the template. I think it would be nice to apply the same type of styling to the rest of the links.
(The reason 'go down' is like it is, is because it was already defined as strong anyway)
#d97b33 by the way is the colour of the board link, yes, technically I could have used $board_col in the CSS but this is experimental :P
1647
Features / Re: AJAX Likes
« on February 9th, 2013, 07:40 PM »
Most of the work was already done anyway. It really was a case of writing the JS for it and just tidying up and minor bug fixes.
* Arantor has had a busy day, bug fixes, some software reviewing, writing this, arranging theatre tickets, assembling a chair... and I only got out of bed a few hours ago...
1649
Features / Re: New revs
« on February 9th, 2013, 06:21 PM »
(6 files, 3KB)
Revision: 1909
Author: arantor
Date: 09 February 2013 17:19:56
Message:
! Stats shouldn't be including liked thoughts as part of top liked posts. (Stats.php)
! Legacy function call removal. (Post.template.php)
! The sessrewrite should be called a little more often, because there are times when PURLs won't be active but the rewriting buffer is still needed (i.e. for the scripturl injection) (Subs-Template.php)[1]
! Likes are now magically AJAXive. I apologise in advance for the number of new bytes in topic view. Testing would be appreciated. There's also probably a better way to do this in terms of finding the right selector, too. (Like.php, Msg.template.php, topic.js)
----
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/scripts/topic.js
Revision: 1909
Author: arantor
Date: 09 February 2013 17:19:56
Message:
! Stats shouldn't be including liked thoughts as part of top liked posts. (Stats.php)
! Legacy function call removal. (Post.template.php)
! The sessrewrite should be called a little more often, because there are times when PURLs won't be active but the rewriting buffer is still needed (i.e. for the scripturl injection) (Subs-Template.php)[1]
! Likes are now magically AJAXive. I apologise in advance for the number of new bytes in topic view. Testing would be appreciated. There's also probably a better way to do this in terms of finding the right selector, too. (Like.php, Msg.template.php, topic.js)
----
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/scripts/topic.js
| 1. | It was breaking my likes code, because <URL> was getting into the AJAX response because although clean_output was called appropriately, the buffer rewrite was not happening because I roll with PURLs disabled. And that IS how I roll. |
1650
Features / Re: AJAX Likes
« on February 9th, 2013, 06:28 AM »
Eh, I wrote likes months and months ago. I even wrote it so it would return a template to inject with all the appropriate markup to just insert with a little jQuery - I just haven't ever gotten around to implementing it for some insane reason.