Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
1396
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 1st, 2013, 03:58 PM »
Quote
On my sites I have only the 2  the quick ( field) and link to the Advanced! I think?
That would be because you haven't turned on simple search ;) But there are consequences elsewhere, e.g. PM searching.
1397
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 1st, 2013, 03:43 PM »
Quote
Something that comes to mind in the SMF simple and advanced search is that the simple search will deend on what page or section of the form you are in while search, and the advanced seach, will search the complete sites database.
Nope. You're confusing simple search and quick search. Quick search is the thing on every page.

Simple search and advanced search are a very separate beast. On an SMF install, Admin > Forum > Search > Settings > Enable simple search. Then go to the search page, you'll see only a very tiny thing, plus a link to the 'advanced' search.

I've stripped out the separation, so there's quick search and advanced search only.

You're right, in that quick search will limit to what it does based on where you are, and this is also something I'm going to fix, but not right now.
1398
The Pub / Re: Language editing inside Wedge
« on March 1st, 2013, 02:21 PM »
Quote
- License agreement editor shows 3 line breaks for French even though I only added two br tags. The difference with the English file is, I actually inserted a linebreak before adding the two br tags, so I guess Wedge is converting linebreaks to br's... Is it as intended..?
The underlying editing code (i.e. the likes of Class-Editor itself, plus stuff like un_preparsecode, un_htmlspecialchars and friends) expects never to deal with line breaks. No post has line breaks in it, because preparsecode strips them and converts to <br>s (and this needs to stay, too)
Quote
- Finding the wysiwyg editor in that area is amusing...
Well, there's no reason not to have it, if the WYSIWYG editor is reliable. I did not do any tests specifically with WYSIWYG, I merely added the correct code and in theory it should work *shrug*
Quote
Doesn't that bother you..??
It would if I ever, ever used the WYSIWYG editor... :whistle:
Quote
- 'Master values' pages could use more styling... I know it's a WIP, but I'm thinking 'Master values' should be in italics.
Well, there's master and current and both could easily be made italic. It's the sort of thing that I got fed up with it for, I didn't really know what to do with the UI going forward.
Quote
- Also, err... I'm assuming eventually one will be able to edit these, right..? :^^;:
Um, yes :lol:
Quote
- Suggesting that the E-mail templates links point to the page for the current language being edited. (It's already in the URL -- lid=french/english.)
What I meant to do was add another layer of linktree to point to the specific template.
Quote
- Search engine doesn't work, it redirects to the admin homepage. Reminder: I have pretty URLs enabled... Maybe related. Even the variable separators have ampersands instead of semi-colons... (??!!)
As per r1961's changelog: "Also note the search function doesn't work yet either." ;) The reason for the form conversion nonsense is because the <form> is literally just <form> at the moment, so not content with the fact there's no backend to search, there's a broken front-end too! But as per r1961, it was because I'd been staring at the code for days that I was just blinded by what I wanted to do with it, you know?
Quote
- I forgot... Do you still plan to allow for caching English + French next, or something...? I don't remember.
It's the plan. It's just a plan at this stage though.
1399
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 1st, 2013, 04:33 AM »
r1965 contains the revamped search stuff. Pictures includes in New Revs thread if you're curious.

That's interesting, Maxx, I like it. I don't know about moving search to the sidebar (or the footer, depending on circumstance!) but it's a possibility.
1400
Features / Re: New revs
« on March 1st, 2013, 04:32 AM »
I'm pretty sure I haven't broken anything, and on the contrary improved a few things. Even though it's only one set of functionality, I'm going to break it down because it has lots of itty bits.

(21 modified, 8KB)

Revision: 1965
Author: arantor
Date: 01 March 2013 03:30:39
Message:
- Search no longer needs its own menu item (Subs.php, index.css, index language file)
! There's no need for a silly toggle, especially now the option doesn't exist. (ManageSearch.php, install.sql, Help and Search language files)
! While I'm on the manage-search settings page, let's also drop a related setting into the mix, whether to display a CAPTCHA to guests doing searches. We already have the option, just making it more prominent. (ManageSearch.php)
! Link to the advanced search on the front page (index.template.php, index.css)
! Removing hidden parameter we don't need any more (index.template.php, SSI.php)
! Actually removing this simple/advanced nonsense. It made almost no difference anyway outside of the UI. (Search.php, Search2.php, PersonalMessage.php, Class-UnitTest_tidyhtml.php)
! Cleaned up and harmonised the searching templates, yes they actually look consistent now, check the advanced search vs PM search for yourself on the site before this commit is added to wedge.org if you don't believe me! (Search.template.php, PersonalMessage.template.php, sections.css)
! Turned over some of the PM search strings to the main search language file. Didn't go through everything but hit up the most obvious ones for now. (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage language file)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/root/install.sql


! Also, I did NOT remove the image from the menu sprite, just the CSS declaration for it.
1401
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 1st, 2013, 12:20 AM »
Quote
So, really, it's hard to say that it can be put into Wedge's official package 'as is'...
I already made us some arty stuff by making a new font, maybe I need to make new smileys too!
Quote
I'm not a huge fan of text links, really it depends on what you want to do, and whether you find a suitable alternative.
Neither am I, but let's try it and see where we go from there.
1402
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on February 28th, 2013, 11:42 PM »
Quote from spoogs on February 28th, 2013, 11:37 PM
:+1:
I always HATED that search menu button as well
For my next trick, I want to nominate that smiley for core too.
1403
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on February 28th, 2013, 11:29 PM »
I'll do this tonight then :)
1404
The Pub / Re: XenForo wins
« on February 28th, 2013, 11:28 PM »
I didn't mean in the language cache stuff. I mean here for all translations (because we will need to cope with other languages as well!) so we'll need to check there, and it could field French too. Don't know yet. Needs way more thought to handle it, but I'm less inclined to put that in Wedge core because it's not that useful for general admins.
1405
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on February 28th, 2013, 11:26 PM »
I really didn't think we needed as much as that personally, I was just going to put the link to the search page under it and see how that works out ;)
1406
The Pub / Re: XenForo wins
« on February 28th, 2013, 10:53 PM »
Quote
Also, when you removed the package files, did you thoroughly check for unused text strings...?
I did actually remove a little more after that in r1959, but once I get the plugin server architecture sorted out, there's little reason to keep the rest of that language file at all.
1407
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on February 28th, 2013, 10:48 PM »
Hm, I don't know about that, but I can certainly add the other stuff in and go from there. :)
1408
The Pub / Re: XenForo wins
« on February 28th, 2013, 10:45 PM »
Quote
Last post I read was your reply on how you found my "click paragraph to add a floating textarea box" idea was interesting and original. Which I appreciated, because yeah that's precisely what it is, an original idea... ;)
:) Credit where credit is due.
Quote
What I've always hated in this center/centre, is that you can't access moderator posts from there, so it makes absolutely no sense to me... And I think I read about you complaining that board moderators couldn't access it, either. If that's the case, indeed it's quite silly...
On second thoughts, let's not go to Camelot, it is a silly place. ;)
Quote
I stopped midway through it. I still have the file opened, waiting for completion, but I just can't find the will to get into it. And because of that, and the fact that you removed a lot of entries and did it for French files too, I'm also lost on whether there are actually entries I should translate, or not, in every commit you made.
I saw that, and honestly I wouldn't be that worried. There's two choices - I can either work on a proper language tool for here (though given my lack of enthusiasm for the inline one in Wedge...) or I can just shove stuff through Google Translate as a working one and it get fixed later. Up to you. I don't mind doing stuff like that if it would be useful.
1409
The Pub / Re: XenForo wins
« on February 28th, 2013, 10:37 PM »
Quote
Oh, this reminds me that I have to read the rest of that huge vB topic like you asked me, Pete...
Eh, the salient points of that thread are: 1) threaded replies are technically feasible but the UI implementation sucks, 2) the moderation centre as a UI system sucks and we can do a bunch better with a 'board' of some fashion. Exactly what that entails I don't know yet.
Quote
Plus I'm totally (totally..) lost with respect to French translations.
I wish I knew French :( But maybe this is the impetus I need to build a proper translation tool for use here to manage even that.
1410
The Pub / Re: XenForo wins
« on February 28th, 2013, 10:07 PM »
I can't comment on that, I don't know the history, nor have I spent time reviewing vB 4 or 5 from a user aspect yet (you can find my thoughts on vB 3.8 around here though)