This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
1366
Features / Re: New revs
« on March 4th, 2013, 08:00 PM »
(20 files, 12KB)
Revision: 1971
Author: arantor
Date: 04 March 2013 18:57:32
Message:
+ Updating user agreement nonsense. There is no admin UI for it at present, mainly because there are some fun kinks I need to work out with it but in the meantime I want to get this all committed so it's recorded. (all files)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
@ It may look as if I had forgotten to update active_state_change in a bunch of places. The point of so doing is to update it when it reached an *active* state change, i.e. some change that would make the account active. I think this all works, but it is not exactly tested yet. I also figured that an admin would be approving a user and ignore the need to reagree in the interim.
Revision: 1971
Author: arantor
Date: 04 March 2013 18:57:32
Message:
+ Updating user agreement nonsense. There is no admin UI for it at present, mainly because there are some fun kinks I need to work out with it but in the meantime I want to get this all committed so it's recorded. (all files)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
@ It may look as if I had forgotten to update active_state_change in a bunch of places. The point of so doing is to update it when it reached an *active* state change, i.e. some change that would make the account active. I think this all works, but it is not exactly tested yet. I also figured that an admin would be approving a user and ignore the need to reagree in the interim.
1367
Features / Re: New revs
« on March 4th, 2013, 07:40 PM »
(8 modified, 3KB)
Revision: 1970
Author: arantor
Date: 04 March 2013 18:39:37
Message:
! $scripturl removal stuff, just a little bit more. (Help.php, Home.php, Mailer.php, ManageBoards.php, Register.template.php)
! Separate mail errors into their own log category. (Errors.php, Subs-Post.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Revision: 1970
Author: arantor
Date: 04 March 2013 18:39:37
Message:
! $scripturl removal stuff, just a little bit more. (Help.php, Home.php, Mailer.php, ManageBoards.php, Register.template.php)
! Separate mail errors into their own log category. (Errors.php, Subs-Post.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
1368
Features / Re: Maybe it's the rum talking... (language editing for plugins)
« on March 4th, 2013, 07:23 PM »
I'm not sure you *can* flush the other caches as such.
But I guess we can put a big old button on the front page or something for real admins (actual group 1 members, not just people with other access rights to the admin panel)
As far as everything in the error log, it will dump the error into the error log using English (if it's an actual PHP error), or whatever language the user is using when the error is logged.
But I guess we can put a big old button on the front page or something for real admins (actual group 1 members, not just people with other access rights to the admin panel)
As far as everything in the error log, it will dump the error into the error log using English (if it's an actual PHP error), or whatever language the user is using when the error is logged.
1369
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 4th, 2013, 07:14 PM »
Doable, sure. Practical? No. Even with the number of boards we have here at present, it would be a very large popup.
1370
The Pub / Re: Spell checker
« on March 4th, 2013, 07:08 PM »
I'm in the midst of some other stuff but maybe I'll get to it.
1371
Features / Re: Maybe it's the rum talking... (language editing for plugins)
« on March 4th, 2013, 07:06 PM »Doesn't that only do the file cache, really...? At least that's what the option is advertising itself as doing.
My concern is that making it too easy to clear the cache will add a lot of load unnecessarily. The language cache for example should only be needed if people touch the files directly, which will be us and upgrading only in theory.
Also, I noticed that the error log is in English, while my page is in French... Is it as desired? I thought the error messages were logged as language-independent strings, but maybe that's only the case of Dragooon's error log implementation in SMG/Aeva Media..?! Can't remember.
1372
The Pub / Re: Spell checker
« on March 4th, 2013, 07:03 PM »
Well, switching to enchant is hard because I cannot seem to get WampServer to behave and use enchant dictionaries.
Back in the early SMF days it was pretty much needed because there weren't browser-backed dictionaries at all back then. Now it's largely unnecessary because browsers do have it (though in IE's case it needs to be done with a plugin)
Other systems are dropping it, I'd personally rather we did the same. Given how many wanted it gone back then, I can't imagine there would be a great increase the other way.
Back in the early SMF days it was pretty much needed because there weren't browser-backed dictionaries at all back then. Now it's largely unnecessary because browsers do have it (though in IE's case it needs to be done with a plugin)
Other systems are dropping it, I'd personally rather we did the same. Given how many wanted it gone back then, I can't imagine there would be a great increase the other way.
1373
Features / Re: Maybe it's the rum talking... (language editing for plugins)
« on March 4th, 2013, 06:49 PM »Actually, I think it'd be nice to have a general 'flush cache' button or menu entry, accessible from any non-admin page if you're an admin. (Or something...)
I wouldn't encourage it everywhere.
1374
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 4th, 2013, 06:43 PM »
action=search2 is the actual search handler, the bit that does it. Quick search will just take you directly to the search results.
action=search is the main search form where you can set options. The popup is essentially going to be have some of this.
action=search is the main search form where you can set options. The popup is essentially going to be have some of this.
1375
Off-topic / Re: Spirate
« on March 4th, 2013, 05:14 PM »
8th or 9th, more like.
I know us creative types can be tempestuous, it goes with the territory but still...
I know us creative types can be tempestuous, it goes with the territory but still...
1376
Features / Re: Maybe it's the rum talking... (language editing for plugins)
« on March 4th, 2013, 05:13 PM »
Yup, the whole point of the language stuff is that it reflects a delta from the master files only. That's all you really need.
I'm just trying to think of ways to make it easier for plugins.
I could have done the caching by way of using the natural cache system but I actually concluded that would make more of a mess in the long run and I wanted to keep performance tight. But yes, I'll add some way to flush the language files cache for you.
And yes, I know there's a need for a bbcode editor :P It's on my todo list!
I'm just trying to think of ways to make it easier for plugins.
I could have done the caching by way of using the natural cache system but I actually concluded that would make more of a mess in the long run and I wanted to keep performance tight. But yes, I'll add some way to flush the language files cache for you.
And yes, I know there's a need for a bbcode editor :P It's on my todo list!
1377
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 4th, 2013, 05:08 PM »
No, what XF has is fine. My objection to the popup was mostly around usability and obviousness related to hover. But if you're already clicking to set focus, it's pretty clear you do want to use it so the popup under it is fine.
1378
Off-topic / Re: Spirate
« on March 4th, 2013, 04:51 PM »
As far as I know, no action was ever taken.
And yes, Bloc disappeared. He'll be back eventually.
And yes, Bloc disappeared. He'll be back eventually.
1379
Features / Re: Maybe it's the rum talking... (language editing for plugins)
« on March 4th, 2013, 04:51 PM »
I don't personally care about the exchange mechanism. I just have an issue with dumping 650KB of data *per language* into the database in quite literally thousands of rows, especially when for the most part people aren't going to change large chunks of it.
There's also little reason to use XML itself, all we need is the ability to have named keys with potentially a named array of contents, which is easily doable in JSON.
For script tags, sure, though I remember it being a good idea even for HTML 4 pages back in the day, even though the script tag is fully declared up front as being CDATA in the spec. I see little reason why it should be an issue now.
There's also little reason to use XML itself, all we need is the ability to have named keys with potentially a named array of contents, which is easily doable in JSON.
For script tags, sure, though I remember it being a good idea even for HTML 4 pages back in the day, even though the script tag is fully declared up front as being CDATA in the spec. I see little reason why it should be an issue now.
1380
Features / Re: Maybe it's the rum talking... (language editing for plugins)
« on March 4th, 2013, 04:23 PM »
It did occur to me, however I see no need to complicate Nao's and my lives any more than necessary with language changes!
That, and the fact that chunking up the DB like that is messy especially when a large block of the default stuff will never change anyway. Though it would solve some of the adding-language-files issues.
But really the suggestion wasn't about moving everything to the database, but just allowing plugins to prepopulate stuff so it gets picked up downstream easily.
That, and the fact that chunking up the DB like that is messy especially when a large block of the default stuff will never change anyway. Though it would solve some of the adding-language-files issues.
But really the suggestion wasn't about moving everything to the database, but just allowing plugins to prepopulate stuff so it gets picked up downstream easily.