Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
1336
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 01:40 PM »
Ideally, yes. Probably even enabled by default if I'm honest. The feature is a big draw for some and given the "only triggers on @" there's not even a performance concern.

Interesting question, what would happen with the above sentence as typed?
1337
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 01:34 PM »
I see that as being a great way to generate support requests if experience Is anything to go by, e.g. SMF "Core Features"
1338
Off-topic / Re: Spirate
« on March 9th, 2013, 05:38 AM »
Even if they are using 2.0 themselves, their copyright in the footer is actually wrong.

The thing is... they didn't know they were doing something illegal, were served a legal notice, attempted to be closed down - and they came back without fixing the problem! To me that crosses the line of 'didn't know we were doing something wrong' to 'we know we're doing something wrong but are going to do it anyway'.
1339
http://www.theregister.co.uk/2013/03/08/twitter_oauth_leaked_keys/

Slap upside the back of the head for Twitter devs.
1340
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 8th, 2013, 10:09 PM »
* Arantor does the 'core feature' chant...

...once we figure out where to put it to give it due prominence.
1341
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 8th, 2013, 09:49 PM »
Awesome :)
1342
Features / Re: Mini-skeletons
« on March 8th, 2013, 04:04 PM »
I don't really mind how it's done as long as it can be done - if the mobile mode can remove the given blocks from the msg skeleton, we can remove the tests in the msg template for 'not mobile'. (Which has the happy side effect of removing the 'if is member' test because if they're not a member, they won't have the other stuff to display anyway)
1343
The Pub / Re: Remove \
« on March 8th, 2013, 04:01 PM »
Quote
There's overhead if the recipient deletes their PMs, of course...
I'm not sure about that. I'm not sure how much the PM housecleaning actually works.
Quote
But yes -- this and that: very unlikely to have an impact at all... Removable.
I already did it :P
Quote
Anything you do is worthwhile! All right?
I did want to have something more meaningful than a couple of bug fixes and a shit-ton of $scripturl removal, but there it is.
1344
Features / Re: New revs
« on March 8th, 2013, 03:59 PM »
(64 modified, 24KB)

Revision: 1983[1]
Author: arantor
Date: 08 March 2013 14:57:27
Message:
! Msg skeleton needs more bones. (Msg.template.php, skeleton.xml)
! Revert back to ENT_QUOTES on saving things. Up-side is that everything works again, but at the cost of some more bytes. But we don't mess about with security matters. (Display.php, Post2.php, JSModify.php, topic.js)
! Better formatting in language area and cleaning up old rubbish. (ManageLanguages.template.php, ManageLanguages.php, ManageSettings language file)
! Spacinazi. (Class-FTP.php, Security.php, Subs-Plugins.php)
! Groups display needs to include properly formatted IP. (Groups.php)
! MOAR DETH TO $scripturl. Nothing seems to be broken but that doesn't mean something isn't. Also note that redirectexit() doesn't need to be given a $scripturl to redirect to an internal URL. (smfinfo.php, UnitTest.template.php, install.php, Admin.php, Boards.php, Class-Editor.php, Dlattach.php, Groups.php, Load.php, ManageAttachments.php, ManageBans.php, ManageErrors.php, ManageLanguages.php, ManageMail.php, ManageMaintenance.php, ManageMembergroups.php, ManageMemberOptions.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManagePlugins.php, ManagePosts.php, ManageRegistration.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, Aeva-Embed.php, Aeva-Foxy.php, Aeva-Gallery2.php, ManageMedia.php, ManageMedia2.php, ManageMedia3.php, Memberlist.php, ModerationCenter.php, Modlog.php, MoveTopic.php, PackageGet.php, Poll.php, Post.php, Post2.php, Profile-Actions.php, Profile-Modify.php, Profile-View.php, Profile.php, Subs-Auth.php, Subs-BoardIndex.php, Subs-Menu.php, Subs-Template.php, Themes.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Sources/media/ManageMedia2.php
Modified : /trunk/Sources/media/ManageMedia3.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/scripts/topic.js
Modified : /trunk/Themes/default/skins/skeleton.xml
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/unittest/templates/UnitTest.template.php
Modified : /trunk/root/install.php
 1. What ho said the t'ing with the three 'bonce', do not meddle with things you don't understand... (I'm an Iron Maiden fan, deal with it.)
1345
Features / Re: Mini-skeletons
« on March 8th, 2013, 03:31 PM »
I don't really know what I want specifically, just some method of being able to exclude blocks from the skins based on being mobile or not. Don't really mind how.

In the meantime, I think I'm going to commit the changes I have for this.
1346
The Pub / Re: Remove \
« on March 8th, 2013, 03:23 PM »
Quote
As for saved PMs, I'm still unsure, but it is true that PMs never represent more than 10% of the overall post count in any given forum (usually...?), so it's never going to be the 'bottleneck'.
There is precisely zero overhead of retaining saved PMs vs not doing so. It's almost entirely a UI consideration.
Quote
Please try and commit today Pete, I've been holding up for your revs, and I'd like to commit some stuff before I'm leaving tonight -- a rewrite of the device-pixel-ratio fallback in Class-CSS, as well as the (finally!) completed EmailTemplates translation, and a few other minor fixes.
I wanted to do something useful and worthwhile, and I have 50+ files to commit...
1347
The Pub / Re: Remove \
« on March 8th, 2013, 05:39 AM »
I have an enormous commit already in progress, but I'll see if I can squeeze that in. Oh, and the commit also fixes the bug regarding titles so they'll all be properly escaped again.
Posted: March 8th, 2013, 05:36 AM

(But considering that r1983 is next and that's the year I was born, I don't want to mess with a half assed commit :lol:)
1348
Features / Re: New revs
« on March 7th, 2013, 11:52 PM »
(25 files, 13KB)

Revision: 1982 - Chippin' around - kick my brains around the floor / These are the days it never rains but it pours[1]
Author: arantor
Date: 07 March 2013 22:50:34
Message:
! $scripturl removal, yay. (all files except EmailTemplates.english.php)
! Spacinazi. (EmailTemplates.english.php, ManageLanguages.template.php)
----
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/Mailer.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMedia.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
 1. Certainly apt given this commit and the fact it's only part of a larger beastie in getting rid of $scripturl.
1349
Features / Re: Mini-skeletons
« on March 7th, 2013, 02:54 PM »
Putting it into context:

Code: [Select]
<msg_author>
<msg_author_title />
<msg_author_avatar />
<msg_author_group />
<if !SKIN_MOBILE>
<msg_author_badge />
<msg_author_blurb />
<msg_author_postcount />
<msg_author_icons />
<msg_author_cf />
<msg_author_warning />
</if>
</msg_author>

Everything else relates to actual content in $msg so it wouldn't necessarily be done at the skeleton level, and once the is_mobile test is outside of the main functions, the 'post was not made by a guest' text can be removed too because all the other texts (they have badges, they have icons etc.) will all return false anyway because those values just won't be set for guest posts.

What could always be done is instead of creating a global $msg, it could always be part of $context, e.g. $context['current_msg'] or somesuch.
1350
The Pub / Re: Spell checker
« on March 7th, 2013, 02:48 PM »
Certainly that's feasible, using some kind of tagging.
Quote
I really like the 'did you mean' bit, but it's true that it's not exactly realistic to fill a DB table with thousands of words just to build a dictionary that's suitable to the forum.
True, it's not. As a plugin it might be but it'll be one hefty ol' plugin. Scanning every post in the DB is not a lightweight task at any time, nor is keeping it up to date.
Quote
Also, I'd like to point that in the time since I reawakened this topic, we got two extra votes for the 'don't remove' side, namely from kimikelku and Maxx, but it's too late to remove the spellcheck button portion, anyway.
I would wonder if the question was misinterpreted a bit.