Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
1306
Other software / Re: Discussing Wedge on simplemachines.org
« on March 11th, 2013, 07:40 PM »
That does not appear to have stopped them so far...
1307
Other software / Re: Discussing Wedge on simplemachines.org
« on March 11th, 2013, 07:00 PM »
smCore is dead unless someone picks it up. Except anyone who does is likely going to start over anyway. So yes, it is dead.
1308
Plugins / Re: The whole "core feature" thing
« on March 11th, 2013, 06:42 PM »
I don't want to make you lose your repository if it's at all possible :(
1309
Plugins / Re: The whole "core feature" thing
« on March 11th, 2013, 06:35 PM »
I don't really want to have to rewrite all of loadPluginSource, loadPluginTemplate, loadPluginLanguage[1], add_plugin_css_file[2] and add_plugin_js_file[3] but I don't see any alternative, because the core equivalents of these also aren't suitable, without rewriting the plugin anyway, to the point it might as well be a straight include...

ALL of those require the files to be in the plugins folder. Which I really don't want for the aforementioned reason.
 1. Though that needs an overhaul to handle the caching stuff
 2. Which is buggy because it hasn't kept up with the changes related to CSS files
 3. Which may also be buggy, not sure
1310
Plugins / Re: The whole "core feature" thing
« on March 11th, 2013, 06:25 PM »
Oh, yes, they're quite different, it's just that with plugin vs core, there is a semantic implication that is quite important.

If something is perceived to be a plugin, even if it isn't, it will have behaviours ascribed to it. Plugins can generally be removed with impunity and generally have no significant side effects (unless you remove, forcibly, something that is a major dependency, but even then going to the plugin manager page will do some clean up on that). Bundled-and-not-disableable plugins are still 'plugins' and could be abused in the same fashion.

Unless we do something that pulls them out of the plugin area and pushes them into another folder, e.g. in Sources, but that raises a ton of other issues (since the language loader etc. won't like it)

And people, seeing something in the 'plugin' folder might assume, however incorrectly, that it can be removed.

Which means we have one of two problems: trusting users not to do something stupid, or redesigning 'plugins' to be 'core plugins' (which means they can't be removed, but also are able to properly use some form of source, template and language loader, since none of the current options will work) which still means separate maintenance that is neither a conventional plugin or a core feature.

Which would you prefer?
1311
Plugins / Re: The whole "core feature" thing
« on March 11th, 2013, 06:06 PM »
See, if I'm honest I'm seeing things standing at a crossroads, as I mentioned recently, where I'm looking at adding CMS stuff and essentially building towards making the forum a key thing - but not necessarily the core of the site, meaning that you could build a site that was a blog and a gallery without being a forum.

I won't deny that I can envisage a place and a time where we head towards what smCore were building.
1312
Plugins / Re: The whole "core feature" thing
« on March 11th, 2013, 06:01 PM »
Would you be inclined them to break more 'core' features into modules like that?
1313
Plugins / Re: The whole "core feature" thing
« on March 11th, 2013, 05:57 PM »
I would sort of like more voices on this though (especially Nao's)

I'm going on my experiences with SimpleDesk and the consequences of poorly thought out decisions that sounded good at the time and I'm sure you can see why I'm eager not to repeat that. However... I'm not totally opposed to the idea, it's just not my first choice, if that makes sense.
1314
Plugins / Re: The whole "core feature" thing
« on March 11th, 2013, 05:47 PM »
Quote
deleting a couple of essential files being one of them.
Oh, sure. But that takes a certain amount of something really bad going on, or wilful intent to damage.
Quote
Currently the notifications system is based on hooks, if you want to integrate into core how would you deal with that?
Wouldn't be hooks. It would just be straight loadSource and direct invocation of things, plus the hooks provided by the notification system etc. would be part of the big list in ManagePlugins.
1315
Plugins / Re: The whole "core feature" thing
« on March 11th, 2013, 05:30 PM »
Quote
I really think a separate topic for this is a better idea rather than Arantor barging in all the threads and beating the drum :P.
:lol:
Quote
1) Make them plugins included by default and enabled, similar to how Joomla does a lot of it's things (or even vBulletin I think?)
It isn't how vB 3 works. Maybe 4 or 5 do, but 3 doesn't.


OK, let's nail down first of all what is or is definitely not a matter of semantics, i.e. technical matters.

It means we have a little more work to do on boot than we would on an otherwise fresh out of the box system, because fresh out of the box, it realises no plugins are enabled, and has to do precisely nothing about that fact.

The other thing is, there are ways to disable it and cause the house of cards to crash down if it remains as part of the plugin system. The system is designed around trying to be resilient, e.g. disabling in the event of inability to access the folder/plugin-info.xml file, and it will forcibly disable from that point onwards. But if you have plugins linked to it, they're going to fail (though the plugin manager will attempt to deal with that too, but only in the admin panel, not more generally)

The other problem is that whatever gets made as a plugin will get less attention than the core itself when it comes to bug fixing. Just because it's consolidated in a single place, unless that place is in the core properly, it's likely to get overlooked. I found this more than once. Sad, but true, and a lesson well learned from SimpleDesk - the amount of bugs I discovered through that bastard front page plugin was incredible.

Even if it a plugin that is shipped, forcibly enabled and impossible to disable without manually fudging the DB and so on, it could still cause problems if it does ever get disabled.

But I agree on the 'being a good example'.
Quote from spoogs on March 11th, 2013, 05:17 PM
Hmmmmmm

I'd argue that if its included it may as well be a feature (especially if enabled by default). Including a plugin by default for the 2nd reason you mention (example of how plugins can be made) was done in SimpleDesk and I can't say it went down as expected, it turns out that it may as well had been a feature in the end.
Oh yes, that bastard front page. I spent far too long making that >_< It would have been better as a core feature, off by default in hindsight. But essentially that's a minor feature.
Quote from spoogs on March 11th, 2013, 05:17 PM
If it is a core feature that I dont want to use then I can disable it, fine no issues there; However it is a plugin that I dont want to use I just dont want it installed at all even if disabled.
This, ultimately. The technical issues are all surmountable, but the semantics and perception are much, much harder to move.

Particularly in the case of the notifications system, which to me is not just a core feature but it's a core feature you'd never want to disable, in which case there's no need to provide the infrastructure that gives the chance of it being disabled. That's the real advantage of it being a core feature, and I don't like having to run around pretending to the outside world that something is other than what it is.
1316
Plugins / [Plugin] Re: Improved attachments upload
« on March 11th, 2013, 05:26 PM »
Quote
Did that happen after I restored your admin access, maybe..? Otherwise it must be a very old discussion, and I remember having the plugin enabled here...
Dunno, not sure.
Quote
It got disabled when I changed its name, but I'm pretty sure I re-enabled it...
Others are disabled, e.g. Users Online Today.
Quote
That 'last' param in the URL... Is it only checked against correctly...?
It should be a num_replies parameter?
Quote
Oh, don't talk down to your elders! I'm young enough to remember things! Well, at least part of the things! What was I talking about, already..?
I guess it's just one of my bugbears that I've gone on about it at times and don't see a solution other than what I'd proposed but you weren't keen on it.
Quote
Well, in some situations I suppose you wouldn't mind...
In some you wouldn't, true, but in those cases the board would be set up to show attachments to guests, i.e. you'd intended to make it the case.
Quote
I'm of the opinion that this should be done at post time... i.e. if you post an attachment from within a certain topic, get the topic, then the board, get its group list, attach these groups to the item's permissions.
Eeek, no. What if you later want to change permissions? You'd have to update all the related items.
Quote
Or we could just store the id_board in the item table, yeah, and do a {query_see_board} on that.
Which is 50% of what I originally suggested.

We would need two columns: type and contextual id. For album items, this would be 'album' and the album id. For regular attachments this would be 'board' and the board id. Or topic id, actually, since there's per-topic privacy.

Then in the file server, you'd fetch the item, figure out what it wants to do to authenticate, check it, and if all good, serve it. The trick is making it extensible.

I don't remember why you weren't keen on it though.
1317
Plugins / [Plugin] Re: Improved attachments upload
« on March 11th, 2013, 04:59 PM »
Quote
Hmm, didn't get a "new post" warning when sending the last one, even though I'd posted another... Maybe because it was one of mine..?
Hmm, it should still have warned. Something is very much amiss.
Quote
(Eh..?!)
There's a bug report somewhere around here of someone using the select+drag of text to move it around, except the event was captured by the drag 'n' drop.
Quote
It's not an *architectural* issue (what's to be afraid of? Creating a generic "Attachments" album where all attachments will go..?
The problem that I mention isn't that at all, I wouldn't mind but I have mentioned it multiple times now.

If you have an attachments system like that, you need to be able to reference the topic it came from, not so much for 'which topics use this' but 'can the person see this attachment'. Would really suck if attachments could be leeched without having proper board access.

Right now, access to a given file is based on its album. But that doesn't work for attachments whose access rights are implicitly different. Thus you need to be able to indicate where a given media item is supposed to get its authentication from, be that an album or thread access. Or, indeed, anything else you care to think of, e.g. helpdesk attachments.

I did suggest one method of doing this but you weren't very keen on it.
1318
Plugins / [Plugin] Re: Improved attachments upload
« on March 11th, 2013, 04:51 PM »
And even if it does become a core feature, it won't work nicely through externals because core feature implies not being bridged through the plugin manager... so it would need to be a separate tree anyway.
Quote
I don't even know what bug you're talking about.
There was certainly a bug with it affecting events and at least once it was disabled for that reason.

It is currently disabled but there's other reasons why that might be (as other plugins are also disabled without any reason I'm aware of for that)
1319
Plugins / Re: Hooking into e-mail templates
« on March 11th, 2013, 04:41 PM »
That's the great thing about having this caching mechanism, it allows me to explore all kinds of craziness like this ^_^
1320
Plugins / Re: Hooking into e-mail templates
« on March 11th, 2013, 04:36 PM »
Well, it's more complex than that because generally you'd have a single file for email templates within a plugin (keeping them all together), and you'd want to exclude that from the list that the language area generates - which includes all files with the filename.language.php setup in every folder of every active plugin (it's good like that)

But unless you tell the language editor about the file it's still going to include it, even if it turns out there are no usable language strings there if that makes sense.

The splice-into-DB still needs to be done, IMO, for strings that would like to be available very commonly (e.g. that would like to be part of index)