Wedge

Well, it was the 'desc' translations rather than the actual bodies, but I never understood the pressing need for entities. To my mind, UTF-8 content is going to be UTF-8 content in the database anyway, and it's not going to have every non ASCII character entity-encoded. Since there are plenty of cases of non-preset content being injected, there are always going to be cases where UTF-8 content will be transposed into emails, and that must by definition be working - because if it wasn't, there would be a ton of complaints - but there aren't.

So it's a non-issue from my perspective.I didn't catch it when reviewing the diff because WinMerge doesn't get uppity about that - it does show the encoding in the footer but I don't really take notice of that because it's something I don't normally need to look at.

:lol:

Yeah, that's the plan. I'm working on the fallback right now. I'm not sure how Brazilian is going to work, whether I need to figure out some 'language invoking another language' but I can't see any way that can meaningfully work all that well.

English UK falling back to English US works well enough, and I'm fine with English US being a master fallback, but other than that, I don't see a way that isn't horrific and troublesome. I'll finish up the loading of English US as a fallback.

Also, EmailTemplates.french.php doesn't work properly; the accented characters are encoded in ANSI, not UTF-8. I've fixed it locally and will commit it with my next commit.

(3 files, 1KB)

Revision: 2007[1]
Author: arantor
Date: 19 March 2013 04:18:59
Message:
+ Language editing works. Doesn't work for plugins, but otherwise it works. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


@ It's not pretty but it works as far as I can tell. I have to admit I'm not very happy, nor very proud of this, it's kind of ugly. And it can't even sanitise content - because raw HTML does get used in some strings and there's not a lot we can do that about.

1.

Did you ever hear what I told you? Did you ever read what I wrote you? Did you ever listen to what we played? Did you ever let in what the world said? Did we get this far just to feel your hate? Did we play to become only pawns in the game? How blind can you be, don't you see? You chose the long road, but we'll be waiting Bye Bye Beautiful, from Dark Passion Play, 2007

You have nothing to be ashamed of here :) In fact you're one of the few people I've seen who could keep it going who's still around.

Ah, but it is. This is something that appears to have been largely unnoticed in the comments, despite my spelling it out rather clearly.

Your project revolves around development of a piece of software. I know there is a strange culture attached to that idea, but hear me out. You have a project around a piece of software. And THIS is a person you are giving the keys to the kingdom to. Are you seriously telling me you do not see why this is a problem?

For those playing along at home, let me explain why this is a problem.

1) Technical competence. The mod proves, as if there were any real doubt, that Lab is not - in my opinion - up to that responsibility.

2) Inability to handle criticism. The same argument could be levelled at me, but if you notice, someone deconstructing my work on a technical basis doesn't yield emotional responses. Personal attacks will. Ad-hominems presented as 'legitimate criticism' will. People going around and telling me that I'm wasting my time because I should be doing something better will too.[1] A developer who cannot handle legitimate criticism of what they have written is a poor developer.

3) Questionable ethics. Selling paid plugins is always an interesting question. What it means is that you have to bring your A game to the party. If your A game is up to scratch, it's all fair in love and war. Your paid work will be representative of your better, if not your best, work.

This raises several issues. Firstly, not even running his own paid mod site. It's not difficult to run such a site, and takes a competent developer a couple of days at most to get something set up. The fact he isn't even running his own mod site out of the box is a fairly worrying item anyway, just as much as I took vbgamer to task for not using his own storefront or downloads systems on his own site. Just as, while I'm being fair to everyone, Nibogo wasn't using his own gallery for serving gallery images - I haven't checked to see if he is now using his own but even after he brought his own out, he was still using Aeva.

So a mod developer that isn't running his own site - especially for something he'd already put '3 years' into - should be a huge warning sign.

More importantly, his work should be up to the standard of the SMF trunk that he is supposed to be committing to. If his commits there are up to scratch, why is sub-par work being put into a paid mod? Conversely, if his commits are only up to the standard of his paid work, why is he still a developer?

Even more importantly, how did no-one on the team realise his status essentially as 'liability' before he got into the position of being a developer?-sigh- The fact you still fail to understand the point of what Norv has been saying is not even funny any more, it's just sad.

In almost any other open source project, and doubly so for corporations, is that you have people contributing to the cause. If they're not contributing to the cause and driving it forwards, they are dead weight. Corporations have a concept of revenue-per-staff member. If you have too many people not generating forward progress (or, for businesses, profit), they are a hindrance and should be removed. Now, before the argument of 'but how does <insert department> remain in the company' comes in, there will always be a need for a set of support services. But they are to *support* the business.

Why is SM NPO any different?

It is a project designed to support the development of a free and open source forum system, yes?

Support means to provide the environment, tools and facilities required to make it work - just as IT provides the machines, Facilities provides the desks and power, HR orchestrates people. These groups do not dictate the direction the business takes - the people running the show and generating growth do that.

1.	Because it's calling my judgement into question, and if you don't trust my judgement, why are you hassling me?

True, it wouldn't - but I was referring to the fact that if they were on the sidebar, that would be at the very bottom of the page for me since I always have the sidebar folded below. The other problem is that it might be possible to have them aligned oddly depending on exactly what order they're in the sidebar.

Yes, but on full reply it tells you the shortcuts ;)

The thing for keys is that the value as they stand didn't seem to me to be very key-like in structure. Text keys are next to useless in this case, as are keys on things like flags for the simple reason that unless they're decently selective, they're just bloat.

The email_last_sent and email_period might be indexable, but I don't know. Some stuff I can usually get a feel for indexes while writing it, other stuff I want to see in action to judge how useful an index would be - and this certainly is the case.