Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
1202
Features / Re: Additional formatting of user names
« on March 22nd, 2013, 03:40 AM »
Also, here's a quick thing I've done, changing the formatting of names for both people on your contact list and people who are online but hidden. While I've shown it here for the 'viewing given topic' item, the same icons and so on are used in the info centre in what I have.
The idea is that there's now no formatting on the name itself and that part can be delegated safely elsewhere in the system. I did have trouble finding an icon that made sense for hidden though!
The idea is that there's now no formatting on the name itself and that part can be delegated safely elsewhere in the system. I did have trouble finding an icon that made sense for hidden though!
1203
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 22nd, 2013, 03:11 AM »
Also, the x/y position is off; when using main reply, non-WYSIWYG, the suggester position is the bottom left of the textarea.
1204
Features / Re: Additional formatting of user names
« on March 22nd, 2013, 03:09 AM »
Actually, that's a *very* good point.
Right now we inject the colours inline. What we should be doing is converting them to a class, e.g. groupnn where nn is the group id, then passing the styling in through a dynamic include (like menu items and languages do)
This would offer up all kinds of options to admins for styling, in theory. And it'd probably save bandwidth if you have multiple instances of the same groups on the page.
Now that I think about it, there is an extra saving - it doesn't even need to be pulled every page, as such. You still need to get the groups of everyone, of course, but you wouldn't need to get the group details every page. Every little bit helps :)
You would have to flush the CSS cache, at least wherever it is that the group styling would be, but that's a minor detail by comparison.
@Nao, what do you reckon?
Right now we inject the colours inline. What we should be doing is converting them to a class, e.g. groupnn where nn is the group id, then passing the styling in through a dynamic include (like menu items and languages do)
This would offer up all kinds of options to admins for styling, in theory. And it'd probably save bandwidth if you have multiple instances of the same groups on the page.
Posted: March 22nd, 2013, 02:17 AM
Now that I think about it, there is an extra saving - it doesn't even need to be pulled every page, as such. You still need to get the groups of everyone, of course, but you wouldn't need to get the group details every page. Every little bit helps :)
You would have to flush the CSS cache, at least wherever it is that the group styling would be, but that's a minor detail by comparison.
@Nao, what do you reckon?
1205
Features / Quick popup actions
« on March 22nd, 2013, 01:38 AM »
Been thinking about this a bit lately. We have a very lovely popup that we can put things in but right now all it's used for is modal popups of things and a few subsidiary information things.
It occurs to me we could use it for more, scenario depending - for example, the login button needn't necessarily take us to a full new page, we could show the login form with the popup. Or even sending PMs directly from the display view.
At least, that's the theory. Before I tackle this, I want to get a feel for whether it's worth the effort - since there's quite a bit to unravel to make this work.
Amongst other things, the event handling on the popup would need fixing (@Nao, this might be a job for you rather than me if we go down this road - right now, forms injected into #helf aren't actually accessible amongst other things), and some of the layout would need revisiting - for example the login page would need to not output its <we:cat> header if called AJAXively but it should output it if not called AJAXively, and stuff like that. Don't even get me started how messed up the send PM thing is!
We'd also have to make sure that these pages didn't themselves have a reqWin call, of course (popup of a popup == badness in a can)
I've attached a mash-up of what it might look like.[1]
It occurs to me we could use it for more, scenario depending - for example, the login button needn't necessarily take us to a full new page, we could show the login form with the popup. Or even sending PMs directly from the display view.
At least, that's the theory. Before I tackle this, I want to get a feel for whether it's worth the effort - since there's quite a bit to unravel to make this work.
Amongst other things, the event handling on the popup would need fixing (@Nao, this might be a job for you rather than me if we go down this road - right now, forms injected into #helf aren't actually accessible amongst other things), and some of the layout would need revisiting - for example the login page would need to not output its <we:cat> header if called AJAXively but it should output it if not called AJAXively, and stuff like that. Don't even get me started how messed up the send PM thing is!
We'd also have to make sure that these pages didn't themselves have a reqWin call, of course (popup of a popup == badness in a can)
I've attached a mash-up of what it might look like.[1]
| 1. | The missing header issue is not just on Opera, it's all browsers. Something about the way we:cat is styled is broken but I don't know what it is off hand. But it wouldn't look right even if it weren't transparent. |
1206
Features / Additional formatting of user names
« on March 22nd, 2013, 01:10 AM »
So, as you'll have seen, we already grab the colour of a member's group to override the colour of links to their name, and it occurs to me that we could add other formatting pretty minimally.
The obvious cases are bold, italics, shadows, with maybe things like sparkle effects as well as icons for the groups. I'm thinking about trying to cover all the things people want, and do so easily.
The biggest objection in the past for formatting names with bold and italic is because the who's online does this as well, but I see no reason why we couldn't replace that with an image for contact/hidden respectively.
That would free us up to do all kinds of neat things that a surprising number of people ask for - and we can do it in a way that doesn't cause any additional issues in the long run, which sounds like a win-win to me.
Thoughts?
The obvious cases are bold, italics, shadows, with maybe things like sparkle effects as well as icons for the groups. I'm thinking about trying to cover all the things people want, and do so easily.
The biggest objection in the past for formatting names with bold and italic is because the who's online does this as well, but I see no reason why we couldn't replace that with an image for contact/hidden respectively.
That would free us up to do all kinds of neat things that a surprising number of people ask for - and we can do it in a way that doesn't cause any additional issues in the long run, which sounds like a win-win to me.
Thoughts?
1207
Features / Re: New revs
« on March 21st, 2013, 11:48 PM »
(6 modified, 18 added, 41KB)
Revision: 2015[1]
Author: arantor
Date: 21 March 2013 22:42:32
Message:
! I forgot that the installer doesn't normally load English as a fallback - but now it does, especially in case of other languages that don't have a complete language pack. On top of that, (crudely) display the flags to users when selecting their language, updating the mapping of Accept-Language to language packs, and fix the fact that the installer wanted jQuery 1.5.2 but that the selectbox needs a higher version, and just for fun, actually display the language's *name* rather than its internal code to users. (install.php)
! I have no idea why the expiry date is 1997 except for it's the date used on the PHP example page. Set it to something a little more... appropriate. (current-version.php, install.php, Errors.php, Subs-Template.php)
! Accuracy update. (ManagePlugins language file)
! Hopefully the rest of English UK (*.english-uk.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Subs-Template.php
Added : /trunk/Themes/default/languages/ManageMedia.english-uk.php
Added : /trunk/Themes/default/languages/ManageMembers.english-uk.php
Added : /trunk/Themes/default/languages/ManagePaid.english-uk.php
Added : /trunk/Themes/default/languages/ManagePermissions.english-uk.php
Added : /trunk/Themes/default/languages/ManagePlugins.english-uk.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Modified : /trunk/Themes/default/languages/ManagePlugins.french.php
Added : /trunk/Themes/default/languages/ManageScheduledTasks.english-uk.php
Added : /trunk/Themes/default/languages/ManageSettings.english-uk.php
Added : /trunk/Themes/default/languages/ManageSmileys.english-uk.php
Added : /trunk/Themes/default/languages/ManageTopics.english-uk.php
Added : /trunk/Themes/default/languages/Media.english-uk.php
Added : /trunk/Themes/default/languages/ModerationCenter.english-uk.php
Added : /trunk/Themes/default/languages/Packages.english-uk.php
Added : /trunk/Themes/default/languages/PersonalMessage.english-uk.php
Added : /trunk/Themes/default/languages/Profile.english-uk.php
Added : /trunk/Themes/default/languages/Reports.english-uk.php
Added : /trunk/Themes/default/languages/Search.english-uk.php
Added : /trunk/Themes/default/languages/Security.english-uk.php
Added : /trunk/Themes/default/languages/Themes.english-uk.php
Modified : /trunk/other/xml/current-version.php
Modified : /trunk/root/install.php
Revision: 2015[1]
Author: arantor
Date: 21 March 2013 22:42:32
Message:
! I forgot that the installer doesn't normally load English as a fallback - but now it does, especially in case of other languages that don't have a complete language pack. On top of that, (crudely) display the flags to users when selecting their language, updating the mapping of Accept-Language to language packs, and fix the fact that the installer wanted jQuery 1.5.2 but that the selectbox needs a higher version, and just for fun, actually display the language's *name* rather than its internal code to users. (install.php)
! I have no idea why the expiry date is 1997 except for it's the date used on the PHP example page. Set it to something a little more... appropriate. (current-version.php, install.php, Errors.php, Subs-Template.php)
! Accuracy update. (ManagePlugins language file)
! Hopefully the rest of English UK (*.english-uk.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Subs-Template.php
Added : /trunk/Themes/default/languages/ManageMedia.english-uk.php
Added : /trunk/Themes/default/languages/ManageMembers.english-uk.php
Added : /trunk/Themes/default/languages/ManagePaid.english-uk.php
Added : /trunk/Themes/default/languages/ManagePermissions.english-uk.php
Added : /trunk/Themes/default/languages/ManagePlugins.english-uk.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Modified : /trunk/Themes/default/languages/ManagePlugins.french.php
Added : /trunk/Themes/default/languages/ManageScheduledTasks.english-uk.php
Added : /trunk/Themes/default/languages/ManageSettings.english-uk.php
Added : /trunk/Themes/default/languages/ManageSmileys.english-uk.php
Added : /trunk/Themes/default/languages/ManageTopics.english-uk.php
Added : /trunk/Themes/default/languages/Media.english-uk.php
Added : /trunk/Themes/default/languages/ModerationCenter.english-uk.php
Added : /trunk/Themes/default/languages/Packages.english-uk.php
Added : /trunk/Themes/default/languages/PersonalMessage.english-uk.php
Added : /trunk/Themes/default/languages/Profile.english-uk.php
Added : /trunk/Themes/default/languages/Reports.english-uk.php
Added : /trunk/Themes/default/languages/Search.english-uk.php
Added : /trunk/Themes/default/languages/Security.english-uk.php
Added : /trunk/Themes/default/languages/Themes.english-uk.php
Modified : /trunk/other/xml/current-version.php
Modified : /trunk/root/install.php
| 1. | The time-traveling is just too dangerous. Better that I devote myself to study the other great mystery of the universe: women! (I couldn't let 2015 go by without a BTTF reference! |
1208
Features / Re: Miscellaneous/WIP screenshots
« on March 21st, 2013, 11:26 PM »
I don't know how many of you remember the installer actually offers a language selection.
I did some work on that bit today so it actually displays the flag and language name - amongst fixing up detection of default language based on what your browser is set to do.
I did some work on that bit today so it actually displays the flag and language name - amongst fixing up detection of default language based on what your browser is set to do.
1209
Features / Re: New revs
« on March 21st, 2013, 08:05 PM »
(12 added, 18 modified, 24KB)
Revision: 2014
Author: arantor
Date: 21 March 2013 19:04:12
Message:
! Missing static variable. (Display.php)
! Fallback measures weren't quite correct in language loading in the event of certain combinations of default language. (Load.php)
! Required custom fields on the registration page should include required field indication. (Profile.php)
! While we're on the subject, CAPTCHA and question fields should also be indicated as required to the browser. Yes: competent browsers won't even send the page off the first place until these are filled in, which might save some page requests. (GenericControls.template.php)
! No point indicating the rel="search" if the user can't see it. (index.template.php)
! Legacy strings go bye-bye. (Error, Login language files)
! Accuracy tweaks (Install, ManageMaintenance language files)
! Oops, missed some other things that should have been entitised. (Notifications language file)
! 'New posts while you were...' warnings should have been number-context strings. (Post.php, Post language file)
! More UK translation. Some of these are ugly placeholders, bah. (*.english-uk.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Added : /trunk/Themes/default/languages/Install.english-uk.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Install.french.php
Added : /trunk/Themes/default/languages/Login.english-uk.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Added : /trunk/Themes/default/languages/ManageBans.english-uk.php
Added : /trunk/Themes/default/languages/ManageBoards.english-uk.php
Added : /trunk/Themes/default/languages/ManageMail.english-uk.php
Added : /trunk/Themes/default/languages/ManageMaintenance.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Added : /trunk/Themes/default/languages/Modlog.english-uk.php
Added : /trunk/Themes/default/languages/Notifications.english-uk.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/languages/Notifications.french.php
Added : /trunk/Themes/default/languages/Post.english-uk.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Added : /trunk/Themes/default/languages/Settings.english-uk.php
Added : /trunk/Themes/default/languages/Stats.english-uk.php
Added : /trunk/Themes/default/languages/Who.english-uk.php
Revision: 2014
Author: arantor
Date: 21 March 2013 19:04:12
Message:
! Missing static variable. (Display.php)
! Fallback measures weren't quite correct in language loading in the event of certain combinations of default language. (Load.php)
! Required custom fields on the registration page should include required field indication. (Profile.php)
! While we're on the subject, CAPTCHA and question fields should also be indicated as required to the browser. Yes: competent browsers won't even send the page off the first place until these are filled in, which might save some page requests. (GenericControls.template.php)
! No point indicating the rel="search" if the user can't see it. (index.template.php)
! Legacy strings go bye-bye. (Error, Login language files)
! Accuracy tweaks (Install, ManageMaintenance language files)
! Oops, missed some other things that should have been entitised. (Notifications language file)
! 'New posts while you were...' warnings should have been number-context strings. (Post.php, Post language file)
! More UK translation. Some of these are ugly placeholders, bah. (*.english-uk.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Added : /trunk/Themes/default/languages/Install.english-uk.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Install.french.php
Added : /trunk/Themes/default/languages/Login.english-uk.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Added : /trunk/Themes/default/languages/ManageBans.english-uk.php
Added : /trunk/Themes/default/languages/ManageBoards.english-uk.php
Added : /trunk/Themes/default/languages/ManageMail.english-uk.php
Added : /trunk/Themes/default/languages/ManageMaintenance.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Added : /trunk/Themes/default/languages/Modlog.english-uk.php
Added : /trunk/Themes/default/languages/Notifications.english-uk.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/languages/Notifications.french.php
Added : /trunk/Themes/default/languages/Post.english-uk.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Added : /trunk/Themes/default/languages/Settings.english-uk.php
Added : /trunk/Themes/default/languages/Stats.english-uk.php
Added : /trunk/Themes/default/languages/Who.english-uk.php
1210
Features / Re: New revs - Public comments
« on March 21st, 2013, 06:53 PM »Oh, now I know... I think EmailTemplates was ISO earlier, because it didn't have any accents in it. I added accents when I translated your 'desc' strings...
- Although I'm not enchanted with the idea (when it comes to updating website files via FTP, it's two or three extra folders to check out), I guess it'd make sense to put all languages into their own folders, for simplicity. If you don't want that, then good; if you do, then I won't oppose it.
Well, there are many settings we never hesitated to remove to make room for others or just breathing space... ^^
Speaking of which. Isn't it feasible (ah, finally got the spelling right!) to just keep the editor out of topic pages, and when clicking 'Full editor', load it through Ajax instead...? I'm not afraid of these Ajax calls anymore. :P And it would save quite many bytes to topic page.
- there's an occurrence in Active Topics (from John) and one in one of your plugins (I think it's WedgeDesk, I'm not sure though), where it sends reqWin('url string'). I've fixed Active Topics to do it the 'proper' way, i.e. put the URL into the href (so that it actually gets prettified and optimized by Wedge... I think??!!), and do reqWin(this) instead.
WedgeDesk is also one of the issues around attachments/media items, to ensure permissions remain tied to the helpdesk and not anything else.
I still prefer for // comments at the end of a line of code to be either very short (a few words at most), or moved to their own line (or move, if needed). That's pretty much a 'SMF/Wedge coding guideline' to me... Do you think you could do that in the future..?
Posted: March 19th, 2013, 04:43 PM
OK, upcoming change I'm not entirely happy about.
The 'correct' behaviour is for loadLanguage to complain bitterly if a given language file doesn't exist - even if there will be a suitable fallback, it is still going to complain about the missing file. The only problem is that a small percentage of the language files for English UK will be identical to English US (e.g. so far the Home language file is in that category), so I need to include a placeholder for those so that I don't write exceptions directly into loadLanguage for a fringe language case. I don't like it either but it's the least worst alternative.
1211
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 21st, 2013, 05:43 PM »
Oops >_<
In other news, we really gotta move it up to the top of the page.
In other news, we really gotta move it up to the top of the page.
1212
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 21st, 2013, 05:21 PM »
There's an error been flagged in the log - and it still happened this morning but I'm not sure it's been fixed since.
(edited out)
8: Undefined index: page_title_html_safe
(Equivalent of action=notification)
(edited out)
8: Undefined index: page_title_html_safe
(Equivalent of action=notification)
1213
Features / Re: JavaScriptEscape headaches
« on March 21st, 2013, 05:17 PM »
And this same behaviour is mirrored in the language editor area, so users will be able to edit stuff and quote marks are left *unchanged* there. (I cannot safely htmlspecialchars anything the user puts, given that we have various inline links and whatnot in the language strings.)
The only way around it is to have a separate language file where its contents will be loaded just for JS injections and then we can 'encourage' everything in that to have quot instead of bare double quotes.
The only way around it is to have a separate language file where its contents will be loaded just for JS injections and then we can 'encourage' everything in that to have quot instead of bare double quotes.
1214
Features: Posts & Topics / Re: Automatic Quote splitter
« on March 21st, 2013, 05:13 PM »
There are more draft permissions than there should be, and there's a bug with the reporting area where it doesn't have all the proper labels for everything.
1215
Development blog / Re: It only took two guys two years...
« on March 21st, 2013, 05:12 PM »
Wedge is not publicly available at this time. Only selected alpha testers have access to it.