Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
1141
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 27th, 2013, 11:34 PM »
I am, I don't know about anyone else.
1142
Off-topic / Re: Unknown Action
« on March 27th, 2013, 09:52 PM »
OK, so I've fixed a bunch of stuff in r2030, this should clear up most of the unknown actions. If I see any more I will fix them as I see them (debugging info FTW)
1143
Features / Re: New revs
« on March 27th, 2013, 09:45 PM »
(2 files, 2KB)

Revision: 2030[1]
Author: arantor
Date: 27 March 2013 20:44:07
Message:
! Some missing and slightly inaccurate who's online strings. (Who language file)
! Injected error information would be overlooked. Most useful for bans. (Who.php)
! Pretty URLs don't save the user id into the URL for profiles, so viewing any other user's profile would always fail in who's online. (Who.php)
----
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/languages/Who.english.php
 1. I can't help but feel we should have had a Terminator reference by now.
1144
Off-topic / Re: Unknown Action
« on March 27th, 2013, 07:44 PM »
Notification isn't the only action that needs fixing ;)

I also found a related bug in it that I need to explore.
1145
Off-topic / Re: Unknown Action
« on March 27th, 2013, 02:01 PM »
I really need to sit and check the list of actions vs descriptions again, we've changed so much it's entirely possible that we've missed some.
1146
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 27th, 2013, 01:57 PM »
Quote from Dragooon on March 27th, 2013, 07:08 AM
@Arantor: Yay your first notifier, a couple of points though
1) It can use multiple handling, something like Arantor and 4 others liked your post "Re:Like my post" which is pretty simple to implement (mostly Notifier::getText and Notifier::handleMultiple stuff). Currently it'll just stop the notification and bump it, you can add a count in data and increment it when handleMultiple is called and add some conditional checks on getText
2) It should be LikesPost since it'll currently only handle that
It was a quick thing I did late last night ;) I did skim over the handleMultiple but I wasn't quite sure what I was supposed to do with it.

As far as the name goes, I did envision it supporting likes on thoughts too but I ran out of time last night to work on it.
1147
Off-topic / Re: Unknown Action
« on March 27th, 2013, 01:55 PM »
Sure. Usually if there is, it's a plugin that isn't entirely being well behaved.
1148
Features / Re: New revs - Public comments
« on March 27th, 2013, 01:54 PM »
Quote
did you check whether $context was being used elsewhere in the functions..?
No, I didn't. But any place with a linktree is also going to be setting the title, which is a context variable.
Quote
Considering I'm the only one who'd be annoyed by the change (i.e. having to move my FTP updates to one extra folder), it's probably best to just ignore me and move them to their own folders.
I'm not overly looking forward to the changes in the language editor, or for that matter, themes[1] with their own language files.
Quote
How pretty it is depends on what you're ready to give up on, eh eh.
Personally, I'd say that the less Display is crowded, the prettier it is overall.
As always, my main concern is with reactivity. But as long as the main editor is there, and Ajax is called only when going for 'full editor', I don't really see any issues with it.
Generally, that's fine.
Quote
i.e., loading smileys and buttons through Ajax seems like a given to me, but the wysiwyg and non-wysiwyg editors, along with their shortcuts etc, should always be loaded.
Ah... that's where you and I differ. WYSIWYG pretty much demands the buttons from a usability perspective and realistically the buttons are more important to me than the shortcuts are.
Quote
I was wondering whether we shouldn't be inverting the process on desktop..?
I don't know. I just know I hate crazy and inconsistent interfaces - you know my thoughts about Enter vs Ctrl Enter on Facebook for example ;)
Quote
reqWin(this.href) is wrong code. Perhaps inherited from an old version of Wedge..? Can't remember how I used to do it. (I fixed it manually. I have tons of compatibility-related updates I'll commit at some point for plugins... 29 files, half of which are from WedgeDesk.)
Actually, it's probably from SMF originally.
Quote
Probably, yeah...
I'd still like for you to look into your code for WD and tell me if you can think of a better way of doing it. The onclick stuff, I mean.
I don't remember much of WD, mostly it was brute-force conversion of SD original to whatever was current in Wedge at the time.
Quote
I can understand you don't like the idea... And, I'll just say, I agree I'd rather not do it that way.

I'm thinking, *maybe* we could have a 'special setting', such as $txt['language_parent'] = 'english' or something, that says Wedge shouldn't worry about missing files, and instead look for the file inside the 'english' folder. What do you think..?
The problem with a language indicating its parent like that means you implicitly have to load the file twice - load index once, learn that you need to have a parent, load the parent, reload the index to reinstate changes from that. Though once you've done that, you can avoid it further.

I dunno. I don't really like what's in SVN but I think it's best for now since it does actually enforce that you know you have all the files you should.
Posted: March 24th, 2013, 05:47 PM
Quote
* Because the registration agreement is a special language string that's explicitly parse_bbc'd
Which means now what's in the database is explicitly different to what's used for actual users, but heigh ho and all that. Reason: preparsecode will convert out all the line breaks.
Quote
This also makes them easier to use them as base for your own registration agreement.
Please tell me why a user would do this. Translators are the only people who should be looking at raw language files.
Quote
Missing file. Note that Home files are not supposed to be in the final distro, and that I'm sure I'll forget all about it soon enough, but whatever...
So users who get the final distro are going to be expected to hand code stuff? Might as well write off Wedge now then because most users do NOT want to hand code ANYTHING. If anything, not only does it need to stay but it needs an admin UI as well.
 1. Assuming we still have *themes* as things that can replace entire template files
1149
Off-topic / Re: Unknown Action
« on March 27th, 2013, 01:46 PM »
It's an action that is unknown to the system for whatever reason. Admins can see more details, though.
1150
Features / Re: New revs
« on March 27th, 2013, 04:43 AM »
(1 file, 4KB)

Revision: 2024
Author: arantor
Date: 27 March 2013 03:42:50
Message:
! Missing file from r2023. I clearly need more tea. (Class-NotifierLikes.php)
----
Added : /trunk/Sources/Class-NotifierLikes.php
1151
Features / Re: New revs
« on March 27th, 2013, 04:42 AM »
(6 files, 4KB)

Revision: 2023
Author: arantor
Date: 27 March 2013 03:40:40
Message:
! Only update the notifications count if there are people to notify. (Class-Notification.php)
! Harmonise area vs sa in the URLs. (Notifications.template.php, notifications.js)
+ Support for notifying people about their posts being liked. I don't know how rugged it is, it feels a touch hacky to me, but I don't see how else to do it as a core feature at this time, without bootstrapping it as a plugin. (Like.php, Notifications.php, Notifications language file)
----
Modified : /trunk/Sources/Class-Notification.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Themes/default/Notifications.template.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/scripts/notifications.js

:heck: And I forgot to upload a file with this. Dumbass that I am.
1152
Features / Re: New revs
« on March 27th, 2013, 03:10 AM »
(14 modified, 1 added, 10KB)

Revision: 2022
Author: arantor
Date: 27 March 2013 02:09:16
Message:
! Break styling for contacts/hidden out of the old way and use icons by the name instead for online lists. You will likely want to shorten the naming, which is fine, heh. (Subs-MembersOnline.php, Display.template.php, InfoCenter.template.php, MessageIndex.template.php, sections.css) :edit: And hidden.png.

! Weekly maintenance should check for missing .htaccess and index.php files, and regenerate them if appropriate, related to SMF bug 4965. (ScheduledTasks.php)

! Globanazi: we're not using $sourcedir any more for cache flagging. (Subs-Cache.php)

! Sort order for spiders online is often wrong, related to SMF bug 4930. (Subs-MembersOnline.php)

! Stats couldn't still be accessed even if disabled, SMF bug 4742. (Stats.php)

! Pruning attachments without leaving a deleted message could have an SQL error, SMF bug 4818. (ManageAttachments.php)

! SMF bug 4902: subscriptions handler can provide output without proper content encoding. SSI should not be influencing headers however. (subscriptions.php)

! SMF bug 4857: unlocking a post from the additional options would not log it properly in the moderation log. (Post2.php)

! SMF bug 4555: censored word description didn't fit the behaviour on the page. Also fixed bare > in the template, which is even in 2.0.4 and AFAIK isn't legal XHTML *whistle* (Admin.template.php)

! SMF bug 4669: plugin enabling/disabling was not logged. (ManagePlugins.php, Modlog.english.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Added : /trunk/Themes/default/images/hidden.png
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/subscriptions.php
1153
The Pub / Re: Looking for volunteers to test the Wedge private alpha!
« on March 26th, 2013, 10:45 PM »
Quote from Arantor on December 23rd, 2012, 05:27 AM
As said before, people who have joined pretty much just to ask if they can participate aren't really the people we're interested in. They're a certain kind of people, a group of people who have historically been observed to ask and get but not contribute anything meaningful - and why should they? They've got their shiny.

I'll say this again: if you want to help, demonstrate a willingness to do so. Asking for beta tester access isn't the way to help us - because if you can't be bothered to contribute to conversations much, you probably aren't going to contribute much in the way of testing. As it stands, the trend is holding up this time as well.

If you do want to help and are prepared to spend some time, read the discussions that have gone on. Add your thoughts - and don't just add '+1' or 'Great idea' comments. Tell us why you think they're great ideas. Or why they're not. There are people around here who think Nao and I can't do any wrong. Those people either don't know us well enough or don't watch what's going on - we make mistakes, errors of judgement and so on. The trick is that we recover and figure out what the best path is.

I guess what I'm getting at is that we don't need people much who are interested in the destination. We need people more who are interested in the journey as well, who are interested in looking at what we're suggesting, and being prepared to say it's wrong if it's wrong. We may not agree to start with, but at least if you're willing to tell us something's wrong, we might be able to fix it. And that begins BEFORE releases. That happens during development.

Participating in our discussions is at least as important as any amount of beta testing, and in the long run possibly more so.
* Arantor notes little has changed in 3 months...
1154
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 26th, 2013, 09:43 PM »
Quote
maybe if some one dis likes the post
Not an option.
Quote
and can it be shown in the author/poster's profile,
If you go to the profile > show posts area for a user, you will see their posts, if the posts received likes that will be shown there.

But I'm not talking about any of that. I'm talking about the notifications system that appears (currently) in the top of the sidebar, that is like XenForo's system.
1155
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 26th, 2013, 09:18 PM »
Do we want notifications if a post of ours is liked?

* Arantor is thinking could be good for the core, good for me to practice on - and good for ensuring that we get the 'don't notify me about this' working.