Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
1096
Features / Re: New revs
« on March 30th, 2013, 04:12 AM »
(3 modified, 2 added, 4KB)

Revision: 2037
Author: arantor
Date: 30 March 2013 03:10:49
Message:
! Feeds should not include MOVED topic notices. (Feed.php)

! Another bug of mine in Who's Online. (Who.php)

! Finally putting in icons for all the buttons along the moderation-options in a topic. Been meaning to find icons for the last two, in the end I just resized two of the icons deleted today. small_move in particular is ugly because I suck at resizing images in GIMP. (index.member.css, small_delete.gif, small_move.gif)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Who.php
Added : /trunk/Themes/default/images/small_delete.gif
Added : /trunk/Themes/default/images/small_move.gif
Modified : /trunk/Themes/default/skins/index.member.css
1097
Features / Re: New revs - Public comments
« on March 30th, 2013, 12:26 AM »
Eh, I'll revert it and apply the proper fix (because now it's totally broken) next time I commit.

error_new_repl* isn't used... but error_new_replies IS. It's even pulled in just a few lines lower:

Code: [Select]
if ($context['new_replies'] == 1)
$txt['error_new_reply'] = isset($_GET['last']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
else
$txt['error_new_replies'] = sprintf(isset($_GET['last']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);

// If they've come from the display page then we treat the error differently....
if (isset($_GET['last']))
$newRepliesError = $context['new_replies'];
else
$post_errors[] = 'new_replies';

$post_errors all get the error_ prefix later. The correct fix would not have been to remove the code (since now it's guaranteed to be broken) as error_new_replies cannot ever be declared properly, but to have replaced error_new_reply with error_new_replies in the $txt declaration.
1098
Features / Re: New revs - Public comments
« on March 29th, 2013, 11:07 PM »
Quote
- Hmm... I think Pete forgot to remove a code block after rewriting $context['error_new_replies'] to use number_context(). At least, it generated an error for me, and the variable wasn't used anywhere... (Post.php)
It's used in Post2.php. This particular piece of code is a bit of a clusterfuck but ultimately is the result of the fact that the post code can come from different places and go different places depending on what it has.

See Post2.php for $context['new_replies']. lines 277-295 being the most prominent use.
1099
Bug reports / Re: Rewriting pretty URLs with respect to the moved topic notice
« on March 29th, 2013, 10:59 PM »
1. Only have pretty URLs enabled for profiles.

2. Move a topic, leaving a redirection notice.
1100
Off-topic / Re: LAMP (Linux-Apache-MySQL-PHP)
« on March 29th, 2013, 10:42 PM »
On a localhost, where this is, it's absolutely fine.
1101
Bug reports / Re: add_plugin_css_file issues
« on March 29th, 2013, 09:42 PM »
Quote
Basically, I'm only keeping: guest/member, OS, browser, and language. These are entries that I'm always saving.
That makes sense to me.
Quote
The workaround would be to either merge both functions and have a param to specify it's a plugin
Hmm, I think I'd rather not. The biggest issue with that is add_css_file only handles relative paths, whereas they're only going to get absolute paths from plugins. If that means add_plugin_css_file just ends up as a wrapper for add_css_file, that's fine but the distinction needs to be kept because add_plugin_css_file does other stuff around getting the correct path.
Quote
Regarding mixins: it's never worked... Neither did extends!
No, it never worked - but all the time inline-block was a regular class, it didn't matter too much ;)
Quote
so I guess add_plugin_css_file SHOULD do it as well...
Probably, yes.
Quote from live627 on March 29th, 2013, 09:34 PM
Maybe merge functions, but keep add_plugin_css_file() as a shortcut of sorts?
Under the hood, perhaps, but all it really needs is add_css_file being able to handle absolute as opposed to relative paths and then just have add_plugin_css_file be a straight wrapper.
1102
Test board / Re: Losers. Testing.
« on March 29th, 2013, 09:33 PM »
Oh, regarding the value of -1? That's weird. But the whole poll this is... a bit iffy, there's still a bug that needs to get fixed.
1103
Features / Re: New revs - Public comments
« on March 29th, 2013, 09:33 PM »
Yup, this is the issue; the pie polls plugin, for example, needs to replace a single block, not an entire layer.
1104
Test board / Re: Losers. Testing.
« on March 29th, 2013, 08:39 PM »
Eh, it's in SVN, go nuts. ;)
1105
Bug reports / Re: Rewriting pretty URLs with respect to the moved topic notice
« on March 29th, 2013, 08:38 PM »
I can't seem to get it to behave even with removing either or both of those.
1106
Bug reports / Rewriting pretty URLs with respect to the moved topic notice
« on March 29th, 2013, 07:36 PM »
So, I was testing a patch with respect to moved topic notices being excluded from RSS feeds (there's no need to syndicate them)

Now, I don't have topic URLs or board URLs prettified, but I do have profile names prettified from other testing I was doing (and set to localhost/wedge/profile/UserName/)

Anyway, so I did the redirect notice, and the body of the post notice has this when you look at it:

Code: [Select]
This topic has been moved to New Board

?topic=34.0

The latter part is a link to the post, and that works correctly, but the body text is being manipulated when it shouldn't be.

The post's physical content is:
Code: [Select]
This topic has been moved to [url=http://localhost/wedge/index.php?board=4.0]New Board[/url]<br><br>[iurl]http://localhost/wedge/index.php?topic=34.0[/iurl]

And that iurl tag is being rewritten to:
Code: [Select]
<a href="/wedge/index.php?topic=34.0" class="bbc_link raw">?topic=34.0</a>

The rewriter is rewriting things not actually in the innards of a tag, but inside the tag's contents.
1107
Test board / Re: Losers. Testing.
« on March 29th, 2013, 07:15 PM »
Actually I tested it with modestly long text ;)
1108
Features / Re: Miscellaneous/WIP screenshots
« on March 29th, 2013, 05:46 PM »
Aaron mentioned it ages ago, but we never knew what to do with it.
1109
Test board / Re: Losers. Testing.
« on March 29th, 2013, 05:45 PM »
Hence the w50... ;)
1110
Off-topic / Re: LAMP (Linux-Apache-MySQL-PHP)
« on March 29th, 2013, 05:44 PM »
The css and js folders need to chmod to 777 too.