Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
1081
Features / Re: Message icons, some proposed changes
« on March 31st, 2013, 04:17 AM »
Except it's not that simple. As I keep mentioned, and this does annoy me that I keep mentioning it without anyone commenting on it but it is kind of important: what about filtering topics by way of icons? I know at least two forums I did this on where it was useful, because the moderators actively got people to set icons for things that were meaningful.

What about ditching per post icons that are a choice and merely having the device icons, but still able to pick up topic icons?

What about having multiple icons per post or per topic?

(See, having a poll is great. Having a poll where all the options indicate a given bias is not.)
1082
Off-topic / Re: Doctor Who
« on March 31st, 2013, 04:04 AM »
Quote
Well, the first time you saw her, she wasn't real, she was a Dalek..
No, she was forever Soufflé Girl to me!
Quote
She made me think of a talkative version of Hogfather's heroine
Susan Sto Helit is thoroughly badass. More so if you've read the Discworld series to any degree and have seen her parentage.
Quote
Woohoo, it's 4am... Gotta love these frigging DFT shifts!
In other news, I'm LOVING not having to change my timezone settings :D
1083
Off-topic / Re: Doctor Who
« on March 31st, 2013, 01:26 AM »
When I first saw Clara - Oswin - whatever, I wasn't *that* thrilled. I dunno. Something's changed about her. Something about the way she's acting/reacting with the Doctor is growing on me.
1084
Off-topic / Re: Doctor Who
« on March 30th, 2013, 10:54 PM »
That is the stuff of badassery. Clara is quickly going up in my estimations!
1085
Features / Re: Message icons, some proposed changes
« on March 30th, 2013, 06:46 PM »
Actually, I've been thinking about the whole prefix thing a lot lately, wondering if I should build it and be done with it.
Quote
If message icons are enabled and the poster did not select an icon the mobile[1] icon is used by default, if that makes any sense.
That's how it currently works - if you don't select an icon (and just use the xx icon by default), you'll get the mobile icon.

I'm not sure we need the attachment icon though.

If I can support a 3DS icon, I'm sure we can put a Windows icon in, hahahahahah
1086
Features / Re: New revs
« on March 30th, 2013, 06:39 PM »
(13 files, 3KB)

Revision: 2040
Author: arantor
Date: 30 March 2013 17:38:46
Message:
! Overhauled how the do-not-log behaviour works, so it can properly be done. The old ways were a bit naive. (index.php, Ajax.php, Dlattach.php, Feed.php, JSEditor.php, JSOption.php, VerificationCode.php, ViewQuery.php, ViewRemote.php)
! Notifications action shouldn't be logged. (index.php, Who.english.php)
! New do-not-log for actions behaviour is also accessible for plugins when declaring their own actions, just add nolog="yes" to the <action> declaration. (index.php, Load.php, ManagePlugins.php, plugin-info.rng)
----
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/JSEditor.php
Modified : /trunk/Sources/JSOption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewRemote.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/index.php
Modified : /trunk/other/plugin-info.rng
1087
The Pub / Re: Don't update log_online for certain actions
« on March 30th, 2013, 06:34 PM »
OK, so I've done this, but this does have some other interesting consequences.

Someone could still be visiting the site, keeping the tab open - but not actually 'online' because their entry to who's online doesn't get renewed, though I guess if they're not actually 'online', it's all good.

Note that logging is per-action not per-subaction, so if there's any part of action=notification that needs to be logged, we need to fix that. But I'll commit what I have for this to be examined.
1088
Features / Re: Message icons, some proposed changes
« on March 30th, 2013, 06:25 PM »
Quote
A regular SMF user will immediately notice how different it is (because it has the icon in it), so they're likely to click it and see that they can immediately view all icons... It's really, really better than the SMF implementation.
A quick glance at the topics made on this site would suggest otherwise.
Quote
The thumb up/thumb down icons are probably among the widest used, but they're so different in style -- we should probably be using our Like icons for these..?
This raises other problems. Firstly, the message icons can only be gifs. This is enforced in the code because there's no way to store the extension. We could update every single icon currently in the DB to include the extension then have the code behave, though.
Quote
Also, perhaps limit the ability to set message icons to topics, i.e. first post only...
Well, that certainly makes sense. In fact, I'd be inclined to pull the icon's id (since we're using the DB table for message icons now) into the topics table and make it filterable that way.

The thing then becomes, if users can only set it on new topic, we can largely dispense with the theatrics of having it elsewhere. Which sort of calls the mobile icons into question.
Quote
We could integrate other elements into message icons: (text) tags, pre-established topic prefixes...
That's workable.
Quote
I'd be tempted to agree that allowing for customization of message icons is a bit much, but OTOH some forums are gonna say they need it.

Maybe push it as a plugin, instead...?
This is where it gets very complex because I'm still of the feeling that if it were more prominent and more than just straight aesthetics (i.e. filterable) it might get more use.
1089
Archived fixes / Re: Notifications bar iinvalid markup
« on March 30th, 2013, 04:54 PM »
Except likes, which is mine :P
1090
The Pub / Re: Don't update log_online for certain actions
« on March 30th, 2013, 04:54 PM »
There are already some actions where it doesn't, I guess notifications can be added to that list. It's... complicated but I'll look at it today.
1091
Features / Re: Message icons, some proposed changes
« on March 30th, 2013, 04:21 PM »
I'm not disputing that the dropdown saves space. But because it's so compact, it hardly ever gets used.
Quote
As such, I don't find it a problem that it doesn't jump to your eyes, and that you have to actually look at the screen to change your icon. Heck, I've never liked these forums where people arbitrarily choose a random icon on their topics. Message index looked ugly enough in SMF... :lol:
Well, part of the problem is that most forums don't do a good job of it. If you have a set of consistently sized/shaped icons, it's much more meaningful, especially if you have the ability to filter topics on those icons (like vB did)

But I propose a third option: just dump the feature entirely. If it's not being used much, let's save ourselves the hassle and not use it at all.

No point worrying about a feature that 'no-one uses' and is 'ugly enough'
1092
Features / Re: New revs - Public comments
« on March 30th, 2013, 03:56 PM »
GIMP. I just opened it, cropped it, saved it, committed it.
1093
Features / Re: New revs - Public comments
« on March 30th, 2013, 03:43 PM »
Quote
Mind you, I also tried the same on small_delete, but Pete somehow managed to crush the competition here. What tool did you use for that one..?! (small_move.gif)
All I did was take the old quick_delete that got deleted, cropped it to size and dropped it in.
1094
Features / Re: Message icons, some proposed changes
« on March 30th, 2013, 05:32 AM »
OK, so I want to do a little test.

I genuinely don't know whether the 'displaying it as a dropdown' vs 'as a list of radio buttons' is more effective or better or whatever. But I also want to test it on a live audience without committing it to core without some idea of whether it's worth doing. Thus... a very nasty hacky plugin that pushes the icons into a fieldset under the postbox.

That way we can use it here and field-test it to see how well it goes down and if it works out, we can polish it up and implement it in core (easy enough to do, just update the running order of templates in Post.php, jiggle the templates in Post.template.php, the two I've provided are reasonably close to what would be needed, just need to give them the right names and fix the formatting to not be thrown together inside 2 minutes)

Note that I deliberately chose to exclude the descriptions. I don't know whether to include them as tooltips or simply not bother yet.

(In case anyone's interested, implementation time: 14 minutes.)
1095
Features / Re: New revs - Public comments
« on March 30th, 2013, 05:19 AM »
Quote
So you're saying I couldn't catch it before the only actual use doesn't specify the error_ prefix, right..?
Yup, unless you knew specifically that the post error handler was weird, you wouldn't be able to find it short of doing a test on new_reply and new_replies.

The language files are actually correct on this one, the whole point was to convert multiple strings into one number_context string but since there are two different strings to be pulled from (depending on whether you were on the posting page or quick reply), it just harmonises it all into one $txt entry that doesn't exist prior to the error handler being invoked.
Posted: March 30th, 2013, 03:04 AM

Also
Quote
! Unread Replies feature didn't actually set the participation icon. YES, we know that it's always set, as the page name implies... But still, not showing it when there's a legend next to the change is awkward. (UnreadReplies.php)
That's actually intentional. SMF never did it either. Though in SMF's case there's sort of more of a reason. (SMF didn't separate unread and unread replies into a separate file. One big ass function to do it all. I really need to streamline what we have, thinking about it.)
Posted: March 30th, 2013, 03:06 AM

Also also

http://wedge.org/Themes/default/images/icons/quick_poll.gif as referred to in the legend for a board is missing, and I don't see any poll icon anywhere in the test board itself :/
Posted: March 30th, 2013, 03:30 AM

Also, also also, I should have read a little further up, since yes, I did actually replace the commented bit with the one liner. That'll teach me for trying to review code in a bad mood. Not enough rum (haven't had any in ages, bah)
Posted: March 30th, 2013, 03:49 AM

Also also, also also, some debugging code in the rename method, line 172.