Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
106
Bug reports / Re: SMF bug 4952 (compressed files not always being inflated properly)
« on August 2nd, 2013, 03:40 AM »
It's still relevant for theme unpacking but I did test my plugin unpacking code with packages that were known to be broken with the old code so this isn't exactly a relevant bug but it can't go away just yet.
Mind you I'm still not clear on what of the theme stuff we're going to leave in.
Mind you I'm still not clear on what of the theme stuff we're going to leave in.
107
Other software / Re: SM.org compromised
« on August 2nd, 2013, 03:39 AM »
I honestly don't care about who the admin is. I haven't revealed the exact thing that was used inside the admin panel though it is fairly obvious.
One question I will put though: the area in question does allow for arbitrary PHP code. However, the vulnerability is only present if files are writable by PHP. I would *love* to hear a credible argument for leaving the files writable by PHP.
One question I will put though: the area in question does allow for arbitrary PHP code. However, the vulnerability is only present if files are writable by PHP. I would *love* to hear a credible argument for leaving the files writable by PHP.
108
Archived fixes / Re: Tooltips for
« on August 2nd, 2013, 01:53 AM »
Works for me. I was just slinging it out quickly to confirm exactly what would be needed.
109
Archived fixes / Re: No URL specified in Feed
« on August 2nd, 2013, 12:40 AM »
Just looking at the source, I think I understand why, specifically that Feedly is interpreting the Atom feed pretty much literally and literally, it's incorrect to RFC 4287.
There are two bugs at work here, the first is the content typing - right now we declare a <content> block with the post contents and a <link rel="alternate"> which points to the post. I believe, from looking at the spec that we shouldn't be doing that, but instead we should be using the link with rel=alternate, and a <summary> for the short version.
The second bug is that all feed content is properly supposed to be full URLs, not partial ones. Some clients can and will resolve that relative to the original feed URL but some don't - including Opera. That also includes the schemaless URL handling, which won't affect most people but it can affect sites that run HTTPS. (Basically, instead of defining http:// or https:// on links, you can just say // instead, which is fine... just not for feed readers. Bah.)
I've fixed it locally and will commit in a bit.
There are two bugs at work here, the first is the content typing - right now we declare a <content> block with the post contents and a <link rel="alternate"> which points to the post. I believe, from looking at the spec that we shouldn't be doing that, but instead we should be using the link with rel=alternate, and a <summary> for the short version.
The second bug is that all feed content is properly supposed to be full URLs, not partial ones. Some clients can and will resolve that relative to the original feed URL but some don't - including Opera. That also includes the schemaless URL handling, which won't affect most people but it can affect sites that run HTTPS. (Basically, instead of defining http:// or https:// on links, you can just say // instead, which is fine... just not for feed readers. Bah.)
I've fixed it locally and will commit in a bit.
110
Archived fixes / Re: 'Half' Smilies
« on August 2nd, 2013, 12:05 AM »
There has been a change in how smileys were handled under the hood and that got committed today - cache clearing should have fixed it ;)
111
Archived fixes / Re: 'Half' Smilies
« on August 1st, 2013, 11:57 PM »
Does clearing your cache help?
112
Archived fixes / Re: 'Half' Smilies
« on August 1st, 2013, 11:39 PM »
Interesting, in both Weaving and Wuthering (my and your defaults respectively) and on the same browser as you it works correctly for me...
113
Off-topic / Re: System visitations: MyBB 1.6.10
« on August 1st, 2013, 11:12 PM »
SMF's parser doesn't have any such limitations on nesting depth from what I remember. It does try to protect nesting too and keep it all straight - and with the out-of-the-box stuff it shouldn't be possible to break it. But we have some special tags that need to be thoroughly tested for that stuff.
Actually the bigger problem right now is the preparser that tries to 'fix' things and sometimes gets it wrong to interesting effect.
Actually the bigger problem right now is the preparser that tries to 'fix' things and sometimes gets it wrong to interesting effect.
114
Off-topic / Re: System visitations: MyBB 1.6.10
« on August 1st, 2013, 11:04 PM »
What do you mean 'should be done'? That's the bit I'm not happy with :P There are quite literally dozens of plugins for Wedge already and they all work this way...
No, Wedge will not be using something similar to DOMDocument for its bbc parsing, we've inherited SMF's parser which does something similar to what you're suggesting but it's a lot more complicated because there are different kinds of tags (some don't have mandatory closing tags e.g. the hr bbcode) and there will be an editor for such things in the admin panel when I figure out how to make a UI that doesn't suck.
No, Wedge will not be using something similar to DOMDocument for its bbc parsing, we've inherited SMF's parser which does something similar to what you're suggesting but it's a lot more complicated because there are different kinds of tags (some don't have mandatory closing tags e.g. the hr bbcode) and there will be an editor for such things in the admin panel when I figure out how to make a UI that doesn't suck.
115
Features / Re: New revs
« on August 1st, 2013, 10:52 PM »
6 modified, 1 added, 42KB
Revision: 2198
Author: arantor
Date: 01 August 2013 21:51:37
Message:
+ Drag and drop board rearrangement. It gets kind of funky when you have many boards and the scrollbars misbehave but that's more of an issue of the underlying jQuery UI Sortable and the nestedSortable components rather than strictly anything else. Seems to work for me other than that. (contributors.txt, ManageBoards.php, ManageBoards.template.php, mana.css, jquery.mjs.nestedSortable.js, ManageBoards language file)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
Added : /trunk/Themes/default/scripts/jquery.mjs.nestedSortable.js
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/root/contributors.txt
Revision: 2198
Author: arantor
Date: 01 August 2013 21:51:37
Message:
+ Drag and drop board rearrangement. It gets kind of funky when you have many boards and the scrollbars misbehave but that's more of an issue of the underlying jQuery UI Sortable and the nestedSortable components rather than strictly anything else. Seems to work for me other than that. (contributors.txt, ManageBoards.php, ManageBoards.template.php, mana.css, jquery.mjs.nestedSortable.js, ManageBoards language file)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
Added : /trunk/Themes/default/scripts/jquery.mjs.nestedSortable.js
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/root/contributors.txt
116
Features / Re: New revs
« on August 1st, 2013, 08:13 PM »
4 files, 6KB
Revision: 2195
Author: arantor
Date: 01 August 2013 19:12:30
Message:
! More overhaul of the underlying search code. There's still plenty more to do but this is a bit of what had to be done to properly isolate custom indexes from, say, everything else. (ManageSearch.php, ManageSearch.template.php, SearchAPI-Custom.php, SearchAPI-Standard.php)
----
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Standard.php
Modified : /trunk/Themes/default/ManageSearch.template.php
@ Just some background: pretty much all the code paths where searching ever touches treat custom indexes as a special case. The whole point, ultimately, is to not do that and push everything out to the search APIs as it should have been.
Revision: 2195
Author: arantor
Date: 01 August 2013 19:12:30
Message:
! More overhaul of the underlying search code. There's still plenty more to do but this is a bit of what had to be done to properly isolate custom indexes from, say, everything else. (ManageSearch.php, ManageSearch.template.php, SearchAPI-Custom.php, SearchAPI-Standard.php)
----
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Standard.php
Modified : /trunk/Themes/default/ManageSearch.template.php
@ Just some background: pretty much all the code paths where searching ever touches treat custom indexes as a special case. The whole point, ultimately, is to not do that and push everything out to the search APIs as it should have been.
117
Archived fixes / Re: Tooltips for
« on August 1st, 2013, 07:58 PM »
That works for me. Though we would still need to replace it with the following:
1 person liked this.
2 people liked this.
You liked this.
You and 1 other person liked this.
You and 2 other people liked this.
But that's still simpler than what we currently have. I'll tackle this shortly if you like?
1 person liked this.
2 people liked this.
You liked this.
You and 1 other person liked this.
You and 2 other people liked this.
But that's still simpler than what we currently have. I'll tackle this shortly if you like?
118
Archived fixes / Re: Tooltips for
« on August 1st, 2013, 07:27 PM »
The only benefit to the tooltip is that you can see the first couple of likes without actually selecting it. But if we drop the tooltip we can save some effort both in terms of language strings and not having to fetch the names from the DB... and if we're not fetching the names we simplify a ton of code and make the query faster to boot.
119
Off-topic / Re: Post count fever
« on August 1st, 2013, 06:53 PM »
Pfft, that took all of 5 minutes to make happen :P
Trouble is all the other stuff I have in the melting pot is probably a bit big to be finishing/committing inside one day but I'll see what I can do.
Trouble is all the other stuff I have in the melting pot is probably a bit big to be finishing/committing inside one day but I'll see what I can do.