Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
1021
Features / Re: Miscellaneous/WIP screenshots
« on April 8th, 2013, 06:39 PM »
The one problem with accepting outside funding is that we stop building it how we see fit, and start building what others want us to build, which is not the same thing at all. Features start getting adopted that are specific to a single use/single installation, rather than a broader use (and I'm aware that this has happened already)

Right now we build what we want to build and that's ultimately the bottom line - people can make suggestions and whatnot, and we're not under any obligation to accept them, but we will if we can see the benefit of it. But the minute money gets involved, it changes that dynamic, and I'd hate to compromise what we have for the benefit of the few at the expense of the majority. I'm just very wary about it.
1022
Off-topic / Re: Some advice when using jquery.ajax()
« on April 8th, 2013, 06:27 PM »
Yup, I specifically unlocked it the first time so that people could comment on Nao's proposals.
1023
Features / Re: Miscellaneous/WIP screenshots
« on April 8th, 2013, 04:23 AM »
Yes, it would - as it stands right now. How else might you set up a warning for each language?

I suppose what I could do would be to have it add one for the default forum language by default, then let admins add them on demand after that. As I said on my thoughts lately, doing i18n stuff is *hard* :P

(I'm sort of making this up as I go along. Prior to 31 March, the infractions system existed totally as a variable set of ideas in my head!)
1024
Features / Re: Miscellaneous/WIP screenshots
« on April 8th, 2013, 03:30 AM »
Still going. Here's where you edit infractions you already set. Yup, you can actually enforce that only certain groups can issue big scary warnings. The way it's also set up, you can enforce that junior moderators can *only* issue the preset warnings you've defined if you want. Not even customise the wording, if that's your preference.
Posted: April 8th, 2013, 02:58 AM

Oh, and if you want to add a custom note, here we go.

Did I mention I like fieldsets?
1025
Features / Re: New revs
« on April 7th, 2013, 11:44 PM »
(6 files, 2KB) - this is just a few bits and pieces I have kicking around that I can safely commit without affecting anything else.

Revision: 2047
Author: arantor
Date: 07 April 2013 22:42:43
Message:
! Managing membergroups could occasionally throw errors. (ManageMembergroups.php)

! Slightly nicer expandable groups in admin panel. At least I think so. (Admin.template.php, ManagePermissions.template.php)

! Corrected locale. (index.english-uk.php)

! Spacinazi. (Subs-Cache.php)

! Just a little something I've been using - I personally like to change the colour of disabled things to let people know they're disabled. (mana.css)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/languages/index.english-uk.php
Modified : /trunk/Themes/default/skins/mana.css
1026
Quote
Also evaluate whether we'll have conflicts, and for anyone to give me their opinion on some topic when I'm unsure which way I should fix something...
Actually, there wouldn't appear to be any conflicts ;)

My pending:
* update index.english-uk.php to specify the correct locale of en_GB rather than en_UK.
* bug fix for ManageModeration.template.php due to what I'm still convinced is a jQuery bug but one I can't reproduce myself outside of Wedge, nasty fix.
* everything else is related to the warnings replacement, which also strips out the last of the old code related to post moderation permissions (and all the attendant language strings etc.) and replaces it with the new infractions system and post-moderation-from-infractions as well as post-bans that are based on infractions... it's complicated but it hits a *ton* of files. But I think I hit most of the stuff that needed to be done, followed by slowly slogging through replacing the UI that needed to be replaced for the new features. It's slow and thoroughly frustrating :/


Sounds like you got some fun things ahead, all sounds good to me, including the general returnAjax thing you have in mind :)
1027
Archived fixes / Re: Event delayer gets upset if there's a " in it
« on April 7th, 2013, 09:03 PM »
Quote
And jQuery understands this perfectly, too.
This is more what I meant, I didn't realise it did.
Quote
We don't have "en-GB" in our language strings, but we do have "GB", so it might be possible to build the complete string from scratch by taking the paypal one and adding it to the generic language string, I don't know... What's your say?
English UK should have en_GB rather than en_UK, my bad. I've fixed that locally.

If only there were some fecking consistency between these fecking things. The locale string is for setlocale, the PayPal one for PayPal, why can't Google accept either of these without having to make its own standard on top? For hreflang, we should supply str_replace('_', '-', $txt['lang_locale'])

On the other hand, the <html> tag also expects a language identifier following ISO 630-1, which is two characters (which is currently provided by $txt['lang_dictionary'], although originally set up for pspell, and no, enchant doesn't use that, enchant uses the locale setting)

Why can't everyone just adopt the locale format and be bloody done with it? >_<
1028
Archived fixes / Re: Wedge.org today
« on April 7th, 2013, 08:45 PM »
The great thing about standards is that there are so many of them >_<
1029
Archived fixes / Re: Flexbox bug
« on April 7th, 2013, 08:44 PM »
Yup. I just went back to the same PM that I posted a screenshot of, and still have the same issue.
1030
Archived fixes / Re: Event delayer gets upset if there's a " in it
« on April 7th, 2013, 07:01 PM »
Quote
It's not that a workaround was needed for this...
You mean
Code: [Select]
onchange="$(\'input[name=infraction_duration_number]\').dostuff();"

would have been legal?
Quote
I really need to get started committing stuff...!
You wait until the commit I'm working on lands. I can't do it in bits because it all absolutely has to work together >_< So far, 25 modified, 3 added (will be 4 added by the time I'm finished, I'm not doing Eng-UK until I'm done)
1031
Archived fixes / Re: Event delayer gets upset if there's a " in it
« on April 7th, 2013, 06:50 PM »
As it turns out I changed the code to use an id rather than reusing the name but yeah I can now fully understand the need for the workaround as proposed ;)

* Arantor is not really a jQuery / JS guru, not the way he is with PHP
1032
Archived fixes / Event delayer gets upset if there's a " in it
« on April 7th, 2013, 04:55 PM »
I don't know if this should even be fixed, but I do want to make record of it.

I have a select, it has a simple onchange, which is to alter the disabled property of another input. Specifically,
Code: [Select]
onchange="$(\'input[name=\"infraction_duration_number\"]\').dostuff();"

The nested quote mark causes issues, but as I said, I'm not sure this necessarily needs a fix - doing something like this is not what you would necessarily call common.
1033
Off-topic / Re: Zopfli compression
« on April 6th, 2013, 03:39 PM »
Quote
Couldn't find a compiled DLL for local tests though, so I guess it'll have to wait... (And yes, I'm not against adding support for zopfli in Wess, as long as low-iteration passes have similar performance to gzip -9 and still save more bytes.)
That's the point, it's at least one order of magnitude slower than gzip -9, if not nearer two orders of magnitude slower.
1034
Off-topic / Re: Zopfli compression
« on April 5th, 2013, 07:41 PM »
But that's something that the CDN would typically manage transparently, no?
1035
Archived fixes / Re: Flexbox bug
« on April 5th, 2013, 07:40 PM »
What, exactly, am I supposed to be looking for?

.postarea has display:table-cell.