Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Topics - Arantor
211
Bug reports / SMF bug 4779 (moderator notes UI breaks after entering a note)
« on March 2nd, 2012, 11:02 AM »
Still happens, though less drastically - the textbox+button is pushed down under the content, overflow causes it to be scrollable but it leaves the textbox+button scrolled out of view as per screenshot.
Also note the moderator box is shorter than the container next to it.
Also note the moderator box is shorter than the container next to it.
212
Bug reports / SMF bug 4952 (compressed files not always being inflated properly)
« on March 2nd, 2012, 10:57 AM »
This is potentially irrelevant, as it depends on 1) keeping any of the current unpacking code features (theme install, plugin install)[1] and 2) keeping the implementation as it is and not replacing it with Zip_Archive or similar.
| 1. | I've been toying with the idea of forcing such things to be done by FTP anyway rather than getting into the quagmire of permissions etc. |
213
Bug reports / SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 10:53 AM »
This is curious.
I could understand > 255 failing because the choice is stored as an unsigned tinyint, but I have no idea why it gets out of step for 128-255.
I could understand > 255 failing because the choice is stored as an unsigned tinyint, but I have no idea why it gets out of step for 128-255.
214
Bug reports / SMF bug 4897: url/iurl auto link doesn't necessarily work as expected for sigs
« on March 2nd, 2012, 10:51 AM »
This one is somewhere in the murky ground between 'not a bug'/'by design' and 'not expected behaviour'.
The summary is that if you disable auto linking/url/iurl in the master bbcode options (under post options) but enable them in signatures, they still won't be parsed because the master list is disabled.
The design says that the list of sig bbc is simply what is *permitted* in a sig, not what will be parsed, but that's not necessarily either the most desirable behaviour nor the expected behaviour, and what would be ideal is to be able to switch between the two lists as needed. I don't think it'll be a *huge* performance hit since it can be done once per parse_bbc call rather than in the scary loops.
The summary is that if you disable auto linking/url/iurl in the master bbcode options (under post options) but enable them in signatures, they still won't be parsed because the master list is disabled.
The design says that the list of sig bbc is simply what is *permitted* in a sig, not what will be parsed, but that's not necessarily either the most desirable behaviour nor the expected behaviour, and what would be ideal is to be able to switch between the two lists as needed. I don't think it'll be a *huge* performance hit since it can be done once per parse_bbc call rather than in the scary loops.
215
Archived fixes / SMF bug 4763 - menu hook doesn't work properly when caching level >= 2
« on March 2nd, 2012, 10:46 AM »
There are two separate issues being discussed but they're heavily related.
Firstly, the items in the menu are cached - including the consequences of calling a hook. Which means on caching level 2, weird things can happen where plugin menu items won't necessarily be displayed (or worse, they'll continue to be displayed even when deactivated)
Secondly, determining the active menu item is potentially inaccurate because of the above.
I'm sort of wondering what the point of caching it is, though. It's very straightforward as it stands, and in fact the caching can screw things up given the gallery unread count.
Perhaps it would simply be better not to cache it at all.
Firstly, the items in the menu are cached - including the consequences of calling a hook. Which means on caching level 2, weird things can happen where plugin menu items won't necessarily be displayed (or worse, they'll continue to be displayed even when deactivated)
Secondly, determining the active menu item is potentially inaccurate because of the above.
I'm sort of wondering what the point of caching it is, though. It's very straightforward as it stands, and in fact the caching can screw things up given the gallery unread count.
Perhaps it would simply be better not to cache it at all.
216
Bug reports / SMF bug 4905 (signature length verified before preparsecode)
« on March 1st, 2012, 05:55 PM »
To clarify: preparsecode will do some operations to any bbcode to sanitise it (like strip 'html' bbcode from non admins), but it will also do expansions on things like /me and reformat certain URL type bbcodes to use full URLs.
This is a particularly tricky situation - because while a signature may be shorter than the limit, by the time it's preparsed it will may well go over the limit - and it may prevent subsequent saves to the signature too (if for example a URL is expanded, and it goes from limit - 1 to over the limit, you won't be able to save that signature even unchanged), and that's before we get into the realms of dealing with the line breaks becoming br tags.
What we might have to do is move the preparsecode before the length test, but proceed to flatten line breaks to a single character for the purposes of fairness.
This is a particularly tricky situation - because while a signature may be shorter than the limit, by the time it's preparsed it will may well go over the limit - and it may prevent subsequent saves to the signature too (if for example a URL is expanded, and it goes from limit - 1 to over the limit, you won't be able to save that signature even unchanged), and that's before we get into the realms of dealing with the line breaks becoming br tags.
What we might have to do is move the preparsecode before the length test, but proceed to flatten line breaks to a single character for the purposes of fairness.
217
Bug reports / SMF bug 4887 (audio CAPTCHA doesn't work in IE9)
« on March 1st, 2012, 02:22 PM »
Well... this one's curious. It's not for the same reason as SMF has, that it doesn't work. The popup has a broken object in it - and there are params present, so I'm not entirely sure what the problem is but it is broken in IE9 (though the direct link works fine)
The popup is also too small in both FF and IE9 causing it to have scrollbars (which has an... interesting... effect if you try to click on the scrollbars)
Also, the fact that the popup closes on click does cause the CAPTCHA to close in FF instead of playing.
The popup is also too small in both FF and IE9 causing it to have scrollbars (which has an... interesting... effect if you try to click on the scrollbars)
Also, the fact that the popup closes on click does cause the CAPTCHA to close in FF instead of playing.
218
Archived fixes / SMF bug 4755 (registration disabled still shows links to register)
« on March 1st, 2012, 02:01 PM »
There's quite a few places that the link is shown but of course, it's not really an option at that point.
219
Bug reports / SMF bug 4279 (attachment size check can timeout with big attachment folders)
« on March 1st, 2012, 01:51 PM »
This isn't really an issue in Media (which is restricted to 1500 files per album anyway IIRC), but it can be in the attachments setup itself. Should really use the attachments table, which records the size, to do the check.
Something more to bear in mind when Media handles attachments (in the future)
Something more to bear in mind when Media handles attachments (in the future)
220
Bug reports / SMF bug 3009 (duplicate meta information)
« on March 1st, 2012, 12:12 PM »
On paginated topics in particular, the title is duplicated each page, as is the meta description. While the latter is separately fixable, the title really does need to be updated.
At the very least, we should consider 'Title - Page 2' for pages > 1.
Wedge r1412 adds support for the pagination to be indicated in the page title (but nowhere else)
At the very least, we should consider 'Title - Page 2' for pages > 1.
Posted: February 29th, 2012, 01:41 PM
Wedge r1412 adds support for the pagination to be indicated in the page title (but nowhere else)
221
Archived fixes / [Won't fix] SMF bug: Flood time limits are enforced for admins
« on March 1st, 2012, 10:35 AM »
I'm not sure whether I'd classify this as a real bug or not, maybe it's desirable? Anyhow, the flood time limit (e.g. 'posts must be x seconds apart') is applied even for admins.
The only thing I would say in its defence is that in the event the admin's account is compromised, it does provide *some* limiting factor. But if the account is compromised, there's more that could be damaged or screwed up in its stead anyway...
:edit: Updated title.
The only thing I would say in its defence is that in the event the admin's account is compromised, it does provide *some* limiting factor. But if the account is compromised, there's more that could be damaged or screwed up in its stead anyway...
:edit: Updated title.
222
Archived fixes / SMF bug 4913 (convert fopen/fwrite to file_put_contents)
« on March 1st, 2012, 10:18 AM »
I'm not 100% sure why this is being suggested, but it is certainly shorter and cleaner, though I can't see it being any faster or more efficient in the long run. I'm also not sure if there aren't permissions related issues to deal with.
Note that we wouldn't convert all the cases (only where it's atomic, such that we do fopen/fwrite/fclose in quick succession), because that's faster than doing file_put_contents with appending.
Posted: February 29th, 2012, 02:27 PM
Note that we wouldn't convert all the cases (only where it's atomic, such that we do fopen/fwrite/fclose in quick succession), because that's faster than doing file_put_contents with appending.
223
Features / Some admin menu changes
« on February 29th, 2012, 05:17 PM »
So Nao suggested a change of the Configuration menu to:Quote I see a couple of issues with this... firstly, I did want to keep Mod Filters as a top level item, as I see it being part of a task-led mentality within the admin panel, but I can see the benefits of Moderation being a top level item too.
OK, here's a thought.
Move Pretty URLs to under Server (as a top level item), then look at moving the items in Features and Settings > General to other pages (creating new pages if necessary, e.g. Who's Online is virtually at enough items to warrant a small page of its own, especially if permissions is moved there too, and the page can be used for admin information purposes too)
That would get rid of Features and Settings entirely (which also suits me quite a bit). As far as Moderation goes, I'm inclined to push that in different ways, moving the warning system stuff under Members > Warnings (since I've talked about putting more options in there anyway)
After that, I'd probably put Filters under Forum somewhere as a top level item (with Add as a sub item in the menu) and Anti-Spam in Members too (again as a top level item, I figure people are going to want to get there in a hurry, and I do imagine there will be mods that will expand that section anyway should they choose to do so; they don't *have* to use the plugins area though it is of course encouraged)
Part of the problem is that most of the Forum stuff is forum specific configuration while what the Configuration area is for is really for 'not forum but *site wide* stuff', except that we don't have much that it is site wide without being quite specific to the forum areas of the installation - there's languages and themes, because they don't deal with the acts of posting etc. and the forum content.
More like... (When it comes to entry names.)
Configuration
Features and Settings
General
---------------
Pretty URLs
Moderation
Settings
---------------
Anti-Spam
Warnings
---------------
Filters
Add filter
(I'm also positive Pretty URLs configuration could still be moved somewhere else, so that Features and Settings could let go of the sub-menus.)
OK, here's a thought.
Move Pretty URLs to under Server (as a top level item), then look at moving the items in Features and Settings > General to other pages (creating new pages if necessary, e.g. Who's Online is virtually at enough items to warrant a small page of its own, especially if permissions is moved there too, and the page can be used for admin information purposes too)
That would get rid of Features and Settings entirely (which also suits me quite a bit). As far as Moderation goes, I'm inclined to push that in different ways, moving the warning system stuff under Members > Warnings (since I've talked about putting more options in there anyway)
After that, I'd probably put Filters under Forum somewhere as a top level item (with Add as a sub item in the menu) and Anti-Spam in Members too (again as a top level item, I figure people are going to want to get there in a hurry, and I do imagine there will be mods that will expand that section anyway should they choose to do so; they don't *have* to use the plugins area though it is of course encouraged)
Part of the problem is that most of the Forum stuff is forum specific configuration while what the Configuration area is for is really for 'not forum but *site wide* stuff', except that we don't have much that it is site wide without being quite specific to the forum areas of the installation - there's languages and themes, because they don't deal with the acts of posting etc. and the forum content.
224
Archived fixes / SMF bug 4870 (incorrectly capitalised month names)
« on February 29th, 2012, 02:56 PM »
I still don't get why SMF and Wedge don't just have the months set appropriately for language and use them rather than trying to mess around with ucwords...
225
Bug reports / SMF bug 4851 (long posts being quoted can cause issues in Firefox)
« on February 29th, 2012, 02:52 PM »
Interesting solution. It's also potentially awkward if in a minor way - the post body is not trimmed as far as I can tell, which means there will be an extra space sent to the server. Which will then be 2 spaces if the post is edited... etc.