New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1740, on October 13th, 2012, 09:16 PM »
rev 1740
(3 files -1, 2kb)

! Fixed the Like popup header. (Like.php)

* Considering that I started with a more complex arrow for the Wuthering linktree, and then reduced it to a simpler form, I just remembered that I really didn't need an image file for it... So, replacing it with one of my usual favorites, the border-color hack. (tria.gif, Wuthering/extra.css)

* Harmonazi. (extra.rtl.css)
Re: New revs
« Reply #1741, on October 16th, 2012, 12:23 AM »
rev 1741
(2 files, 2kb)

+ Added labels for the permission page, allowing you to click permission names to check/uncheck them. (ManagePermissions.template.php)

* The Clean Cache maintenance task should also empty the CSS and JS cache folders... (ManageMaintenance.php)
Re: New revs
« Reply #1742, on October 16th, 2012, 12:24 AM »
rev 1742
(5 files, 2kb)

- We don't need to repeat the schema.org breadcrumb definitions on the bottom linktree in topic pages. Which begs me to ask... Google, why aren't you taking my breadcrumbs into account? Wedge.org has been using then for over 6 months, and yet they're still shown the same way as before... :-/ (index.template.php)

! Minor overflow issue. I'm not sure it's for the best, but it's fixable at any time anyway... (Media.template.php)

* Added a small comment in add_css to remind people that it may fail if calling wetem::hide(). Duh. (Subs-Cache.php)

* Harmonized font size in Wuthering linktree, and linktree padding in Weaving. (index.css, Wuthering/extra.css)
Re: New revs
« Reply #1743, on October 18th, 2012, 10:44 AM »
rev 1743
(4 files, 1kb)

* Admin homepage should now show arrows in the newbie box. I have a feeling it should have been done that way since day one... (Admin.template.php)

* I may come to regret this later, but I moved up the body padding reset code for low resolutions. So, instead of being applied to Wuthering, it's now applied to all skins (including Warm, which doesn't need it, but it won't hurt it either.) (sections.css, Wuthering/extra.css)

* Minor tweaks. (Warm/extra.css)
Re: New revs
« Reply #1744, on October 18th, 2012, 05:28 PM »
rev 1744
(5 files, 3kb)

! Mismatched background in stats page. (Stats.template.php)

* Multiple minor CSS tweaks. They're all for the better. Changed windowbg/windowbg2 color in Wine and removed the gradient background (left it on postbg for now). I fear that too many gradients tend to kill the effect. Maybe I'll add them back later. Added a background border between cells in windowbg-alterning tables. Look for the 'final' keyword lost in the middle, it's fun. (common.css, sections.css, Wine/extra.css, Wuthering/extra.css)
Re: New revs
« Reply #1745, on October 18th, 2012, 05:29 PM »
rev 1745 -- woot, plenty of Wess fixes...
(2 files, 5kb)

+ Added is_ios to browser variable. $browser['agent'] will now return 'ios' whether you're on iPod, iPhone or iPad, and whatever browser you're using, because Apple doesn't allow for other browsers to use their own engine. Except for Opera Mini, which should return 'opera', because I like to do things correctly. Also, because I don't have an iPad under the hand, I can't determine whether it's safe to rename extra.iphone.css to extra.ios.css. (Load.php)

+ Added prefix handling support for font-feature-settings and calc() to Wess. (Class-CSS.php)

! Redefining a CSS variable like "$post_bg2 = $window_bg2" could have unexpected results, due to a misplaced call to develop_var(). Well, maybe I'm adding even more bugs by moving it, ah ah. What do you know. Nah, should be good. (Class-CSS.php)

! Undefined variable $is9 in Wess... Not sure how it stayed that way for so long without generating an error... (Class-CSS.php)

! Fixed support for the old flexbox model, and added display: box to the list. Please note that it's recommended to use display: flex or inline-flex instead, these are the new official values, but their support is not as wide. It'll be at least a few years before it starts being useful really... Sob. (Class-CSS.php)
Re: New revs
« Reply #1746, on October 19th, 2012, 11:58 PM »
rev 1746
(2 files, 1kb)

! Fixed crash on iPad devices, due to Apple being a bunch of funny guys who enjoy changing their user agent without warning. (Load.php)

! Applied a band-aid on the IE6 non-anchor hover polyfill, because it needed it. More specifically, having a ":hover:after" in your CSS seems to trigger an error. That fix should simply ignore the error. Not that IE6 supports :after anyway, eh..? (ie6hover.js)
Re: New revs
« Reply #1747, on October 20th, 2012, 06:12 PM »
rev 1747
(7 files + 8 folders, 9kb)

* Rewrote Wuthering linktree to use a shadowed half-circle rather than bland arrows. Adds about 200 bytes of CSS... That should compress correctly. You tell me if you don't like it. (Wuthering/extra.css)

! Fixed local ignores in the SVN server. (svn, attachments, cache, css, js, Plugins, Sources, Sources/media)

! Media deletion confirm box will now use a regular confirm() call -- until I'm ready to deploy ask() everywhere. (Media.template.php)

+ Added a nice little transition at window resize time. To think it's only one line of code... (index.css)

* Attempting to fix an Opera problem where rounded corners don't show up or disappear correctly. Hopefully I won't need to rework this for other platforms. (index.css, sections.css, Wine/extra.css)

- Removing some custom iOS JavaScript that was no longer needed... I think. (Wine/skin.xml, Warm/skin.xml)
Re: New revs
« Reply #1748, on October 27th, 2012, 11:19 AM »
rev 1748
(5 files, 2kb)

! Fixed CSS bug that would occur when having a selector declared multiple times in a file and then used as a mixin. (Class-CSS.php)

! (SMF bug) Typo: can_view_receipient_email. (SendTopic.php, SendTopic.template.php)

* The trackIP function should be named TrackIP per index.php convention, or trackIP per Sources convention (as it's part of multiple sub-actions). I decided to go for trackIP everywhere. (Profile-View.php)

- Removed remnants of the rev 939 removal of guest_hideContacts. (other/install.sql, SendTopic.php, SendTopic.template.php)
Re: New revs
« Reply #1749, on October 27th, 2012, 11:06 PM »
rev 1749 -- I'm saving the better stuff for a round number like the next one :P
(1 file, 1kb)

+ Mini-menus can now show the %id% and %special% variables in the link text in addition to the link URL. If you don't get it, don't bother. (topic.js)
Re: New revs
« Reply #1750, on October 27th, 2012, 11:14 PM »
rev 1750
(6 files, 11kb)

* Renamed template_profile_icons to template_user_status, and moved it to the left of the user name. Basically, instead of showing profile icons with links in them, which is already dealt with by the new mini-menus, I'm replacing the Online status icon with four squares whose color codes indicate the user status: online/offline, has a website linked, is male/female, is a friend or not. (Display.php, Display.template.php, index.language.php, sections.css)

+ Added See IP / Track IP entries to the mini-menu. Still missing: an e-mail link. (Display.php, index.language.php)

* Replaced all calls to $scripturl with <URL> in the Display stuff. I think it's working... (Display.php)

* Minor CSS tweaks. The most notable change is that I increased the sidebar width by 20 pixels. I think it provides for a better balance, but it's not perfect yet. (common.css, sections.css)
Re: New revs
« Reply #1751, on October 28th, 2012, 06:05 PM »
rev 1751
(3 files +2-2, 3kb)

* Renamed SendTopic to Mailer, because it's more about sending e-mails than sending topic by e-mail. (index.php, xml/detailed-version.php, Mailer.php, Report.php, Mailer.template.php)
Re: New revs
« Reply #1752, on October 30th, 2012, 10:01 PM »
rev 1752
(28 files, 12kb)

* Restored ask() function and updated the thought system to use it instead of confirm(). Since the extra custom function adds quite a few bytes, I also optimized the embedded HTML code for better compression, and possibly better readability of the thought system code. So, all in all, the compressed JS is 15 bytes shorter. Good ol' days... (script.js, index.member.css)

+ First batch of ask() conversion. Most confirm(string) calls now use the ask(string, event) syntax. (script.js, ManageAttachments.php, ManageBans.php, ManageMail.php, ManageMembers.php, ManagePaid.php, ManageSearchEngines.php, ManageSmileys.php, MessageIndex.php, ModerationCenter.php, Aeva-Foxy.php, TEMPLATES: Admin, Display, Errors, ManageBoards, ManageMaintenance, ManageNews, ManagePlugins, ManageSmileys, Media, ModerationCenter, Packages, Profile, Recent, Themes)

! $deep_folder was incorrectly initialized, causing CSS files with a 'local' keyword to be ignored by Wess at parse time. (Subs-Cache.php)

* French grammar fix. (ManageTopics.french.php)
Re: New revs
« Reply #1753, on October 31st, 2012, 10:20 AM »
rev 1753
(30 files, 11kb)

* Last batch of confirm() to ask() rewrites. I didn't think I could pull it off, but all of the confirm calls are now using ask(). Yay. (Class-Editor.php, Display.php, Groups.php, ManageAttachments.php, ManageBoards.php, ManageMembers.php, ManagePaid.php, ManageSmileys.php, mediadmin.js, topic.js, TEMPLATES: Admin, index, ManageAttachments, ManageBans, ManageMaintenance, ManageMedia, ManageMembergroups, ManageMembers, ManageNews, ManagePermissions, ManageSearch, Media, MessageIndex, ModerationCenter, MoveTopic, Packages, PersonalMessage, Profile, Search, Themes)

! SMF bug: there's a confirm box in template_modify_language_entries that actually doesn't do anything because of the lack of a return statement. (Admin.template.php)

* Shortened thought JS code. Not by much, but it's on every page for members... I like saving bandwidth. (index.template.php)

@ The ask() callback is only used once: in the PM popup code (index template). Is it worth keeping it..?

@ Simplified JS code in MembersAwaitingActivation. Would appreciate if beta testers could look into it and see whether the confirm box still works as expected. (ManageMembers.php)

NOTE: I'm hoping to be able to release the private alpha by tonight... Scary!! ;)
Re: New revs
« Reply #1754, on October 31st, 2012, 03:57 PM »
rev 1754
(11 files, 6kb)

+ Implemented say() (replacement for alert()), and modified it to be closer in spirit to ask()... It'll do the same internally, just not showing the extra button. This allowed me to use it in Post pages when submitting a message that's going to be moderated. Also, post.js shows an example of a say() call that requires executing some code after it (in the callback), but has no need to give a boolean return (thus, no event handler is passed to it). (script.js)

* Converted all alerts to say(). Well, easier said than done... I've left one alone (in the spellchecker) because I can't be arsed to determine whether it would work. And I don't use the spellchecker anyway. Do you? (ManageBans.template.php, ManagePermissions.template.php, ManageSearch.template.php, Post.template.php, Profile.template.php, Register.template.php, editor.js, post.js, up.js)

- These JS-oriented strings no longer need HTML entities... Well, easier said than done: who's willing to have a look and change them all, while ensuring they won't be used in e-mails...? Nope? Okay, I'll just forget about them for now... (Post.french.php)