New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1500, on March 22nd, 2012, 04:01 PM »
rev 1500 (yay!)
(7 files, 3kb)

! Fixed Ajax rebuilding of thought list after submitting a new one. Now it should properly in iOS. (script.js)

* Added 4px to .cat's top margin. Don't worry about me, it will pass. (index.css)

* Media queries were being a bit too conservative with 1000px. 900px is still an okay width. (sections.css)

* IE's glow filter looks awful. Replaced it with shadow filters in Wine. Also fixed header background (again?)... (Wine/index.ie*.css)
Re: New revs
« Reply #1501, on March 22nd, 2012, 04:40 PM »
rev 1501
(6 files, 3kb)

! Attempting to fix some of the recently discovered auto-saving draft bugs. Drafts should no longer be saved if the message is empty, and the auto-save flag is reset as soon as Wedge is done with it, instead of after the saving operation is completed successfully. (post.js)

! Here's my pretty lame attempt at fixing the anchor position bug in blog posts. I simply added an $excluding_first boolean that is applied to $counter in each post. I'm... pretty sure it's the reason for the issue, although I'd like to get confirmation. (Display.php)

- Removed some $context['page_info'] declarations. These were only useful for wap2 mode or anything that doesn't support JavaScript. Hey, welcome to the 21st century, right?! (Display.php, MessageIndex.php, PersonalMessage.php, Unread.php, UnreadReplies.php)
Re: New revs
« Reply #1502, on March 22nd, 2012, 07:40 PM »
rev 1502
(3 files, 2kb)

! Fixed the draft saving fix. Should work everywhere as designed, now. The latest issue was that I was testing against 'message' instead of 'draftInfo.message'... (post.js)

! Fixed various problems with blog mod in Display pages. First of all, first_new_message was incorrectly set because it didn't take $include_first into account. Secondly, $counter would return -1 for the blog post. Fixed that. Also, doublepost merging was broken in blog mode. It tested for the first message retrieved the incorrect last message ID for the last page, and it got mixed up overall with the blog post. Finally, I'm optimizing the code a bit by not providing a last_msg_id when merging posts isn't available anyway (like, the previous post isn't yours...) (Display.php)

! Okay, sometimes I'm ahead of my time. Changing the maximum width for definition lists in the stats area proved to generate some amusing layout bugs. (sections.css)

@ Note that 'View most recent posts at the top' is horribly broken, such as not retrieving the latest post at all, and giving more incorrect anchor positions. Well, I never used the option before so I'm a bit lost with the inverted strategy and all.
Re: New revs
« Reply #1503, on March 23rd, 2012, 03:07 PM »
rev 1503
(14 files +1, 7kb)

! Plugins would never load the non-default language strings. Hey, I think it's the first time I touch plugin-related code at all! :P (Load.php)

+ Added an aeva_showStars() function whose purpose is to simply show an img tag of stars for a corresponding rating between 0 and 5. Half points are taken into account, which wasn't the case before (especially not with a rating of 0.5/5 which would generate a 404 error!) (Aeva-Foxy.php, Aeva-Gallery2.php, Subs-Media.php, Media.template.php, images/aeva/star05.gif)

! If a subject had double quotes in it, replying would show a backslash instead of the first quote, and remove the rest of the subject. (Post.php)

! If $options['view_newest_first'] is set, show the page index's "New" post indicator at the beginning of the list, instead of the end. (index.template.php)

* The Flash language string was a bit confusing. (Admin.language.php)

! Fixed more translations. (Help.french.php)

! Fixed media comment layout. (Media.template.php)

! Fixed the rating select box disappearing after rating a media item. (script.js)

! Fixed overlapping main menu icons in the 'genuine' IE8 (thanks TE). Just to make it clear: this problem doesn't show up in IE9 + IE8 compatibility view, so a big thank you to Microsoft for making our lives a misery. (index.ie8.css)

! Fixed some colors when showing drop-shadow-type zooms with Zoomedia. (media.css, zoom.css)
Re: New revs
« Reply #1504, on March 23rd, 2012, 04:00 PM »
rev 1504
(8 files, 2kb)

* If the admin_login template is shown (to confirm your password before you access an admin page), Wedge will now use a 'login' id in the html tag, rather than the original page's action id. (index.template.php)

+ ...Which allows me to finally vertically align that dreaded login box. Yay. (sections.css)

! Arhh. Even Firefox doesn't like a 49% width on two-columns! (index.firefox.css)

! Modify Topic Settings was set at an incorrect index in the contextual tabs. (ManagePosts.php)

* Minor tweak to media area styling. (media.css)

* Minor language/translation tweaks. (Admin.french.php, Help.language.php)
Re: New revs
« Reply #1505, on March 24th, 2012, 07:36 AM »
rev 1505
(5 files +1, 6kb)

! Fixed Split Topics selector's Ajax code, which simply failed to work with the page index function being moved to the index template. (SplitTopics.php, SplitTopics.template.php, Xml.template.php)

! Fixed error in create_button(). (Subs.php)

+ Added a robots.txt with an exclusion rule for ?msg= links, which are aliases to topic pages that I'm sure Google can do without. Plus, it saves you the 404 error on that file. (other/robots.txt)

* Latest homepage tweaks. (Home.template.php)
Re: New revs
« Reply #1506, on March 24th, 2012, 02:27 PM »
rev 1506
(4 files, 2kb)

! Thought parent links (@Username) didn't always work, because they were referring to the parent thought, instead of the master thought. (Home.php)

+ Profile thought lists will now highlight the parent thought you came for. (Profile.template.php, sections.css)

- If your forum is old enough (YaBB era) to still have threadid links pointing to it, then you're certainly skilled enough to do a regex redirection in your htaccess file, and you'll be happy to save a test for all other users. (QueryString.php)
Re: New revs
« Reply #1507, on March 24th, 2012, 07:33 PM »
rev 1507
(5 files, 4kb)

! Now ensuring that westr::close_tags() doesn't close any self-closed tags. (Class-String.php)

! Show Newest Posts First would render the New icons incorrectly in topic pages. (Display.php)

! Fixed incorrect number of table cells per line in media album lists. (Subs-Media.php)

* Moderators should be able to merge double posts from guests. (Display.php)

* Moved moderator list to the sidebar, as in Noisen. (Display.php, MessageIndex.php, Display.template.php, MessageIndex.template.php)

* Spacinazi. (Display.php)
Re: New revs
« Reply #1508, on March 25th, 2012, 05:41 PM »
rev 1508
(6 files, 4kb)

+ Wedge will now silently redirect outdated cached JS/CSS requests to their latest version (or at least any version that works.) Also, don't log errors 404 for completely missing cache files. (QueryString.php)

! Just some extra topic privacy protection in post merging... (SplitTopics.php)

! Ensure that the smart tag splitter won't mistake array members in plain view (like $something['variable']) for tags. (post.js)

+ Apparently, I forgot to commit the template for per-board moderators. (Display.template.php)

! Fixed invisible 'member' thoughts for members without a 'regular member' group. (Home.php)

* Hide the homepage's opening blurb on mobile skins. (Home.template.php)
Re: New revs
« Reply #1509, on March 26th, 2012, 10:58 AM »
rev 1509
(3 files, 13kb)

! Fixed JS error when editing post in Wireless skin. (Always requires a placeholder for subject! Maybe I should add it through JS though..?) (Display.template.php)

* Optimized quick edit JS for size, saved 100 to 200 gzipped bytes, not much but it all adds up. Next step: optimize footer JS in topic pages. Note that the quick edit object no longer has prototypes. Basically, prototypes of original objects are only useful if you're going to have several instances of an object on the same page. Otherwise, it's just a waste of space. (Display.template.php, topic.js)

* QuoteFast should take topic privacy into account. (QuoteFast.php)
Re: New revs
« Reply #1510, on March 26th, 2012, 06:34 PM »
rev 1510
(3 files, 3kb)

! A better fix for the dl.stats issue from rev 1502. (sections.css)

! Fixed timezone auto-detector in Profile area. The code is shorter, and should work this time. (Profile.template.php)

* Don't show topicseen in the URL if the topic is already seen. Only done for SSI, dunno if it's needed elsewhere. (SSI.php)
Re: New revs
« Reply #1511, on March 27th, 2012, 10:50 AM »
rev 1511
(3 files, 3kb)

! The 'javascript' parameter in show_settings was adding an extra space here and there, resulting in unneeded spaces in the final HTML. Harmonized this. (ManagePaid.php, Admin.template.php)

! Rewrote the select box's handling of details (helper text below an option) because it wasn't working correctly in the current version. To do this, I also had to fix the fixed width code because it didn't behave any better. I fear it would make the script bigger, but in the end it's actually shorter by 21 gzipped bytes. Yaych. (sbox.js)
Re: New revs
« Reply #1512, on March 27th, 2012, 06:31 PM »
rev 1512
(1 file, 6kb)

! Fixed Display.php screwing with post counters, anchor positions and blog/board differences. It took an AWFUL five days of work to fix it all. The code's a bit on the hackish side, some of it doesn't even make sense to me, but I'd rather commit buggy code that works, than leave untouched any buggy code that doesn't work. (Display.php)

! Fixed 'All pages' feature showing links to all pages apart from the [All] thingy. Well, it could be argued that you'd want to have clear links to individual pages in the page index even if you have all of the pages visible in the first place. But I'm saying that it's a waste of HTML, so have someone else fix it back for ya. (Display.php)

! Fixed Merge Double Posts flag being set incorrectly if $ascending was set to false. (Display.php)

- Removed support for topic=123.from456, which has never been used in SMF and Wedge AFAIK. So, just as I said last time, if your forum is old enough to support these links, then you're skilled enough to do a redirect rule in your htaccess or apache config file. (Display.php)

- Commenting out some portion of optimization-oriented code that I couldn't get to work properly with the new fixes. I'll restore it when I'm less tired. Seriously, you don't want to make me do that now. (Display.php)
Re: New revs
« Reply #1513, on March 27th, 2012, 06:58 PM »
rev 1513
(2 files, 2kb)

! Fixed thought list on iOS. The action buttons don't look great, with no animation and all, but iOS doesn't support position: absolute (at least my version of it), and I decided against doing too many tricks. Usability is more important here. (index.iphone.css)

! Spacinazi. (index.template.php)
Re: New revs
« Reply #1514, on March 28th, 2012, 03:28 PM »
rev 1514
(2 files, 2kb)

! Fixed non-Wysiwyg mode select boxes remaining in their selected state when they should be reset to the select box title. (editor.js)

! Fixed more select box bugs created by the latest 'fix'. And believe it or not -- it saves an additional 16 gzipped bytes. That's now 2210 gzipped bytes of pure goodness. Until of course someone tells me that their browser has an issue. Because not everyone can use Opera, can they? (sbox.js)