New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1275, on January 27th, 2012, 03:04 PM »
rev 1275
(3 files, 9kb)

+ Added support for transparency in attachments and avatars. Transparency is only calculated when showing an attachment in a topic (loadAttachmentContext), when showing an avatar in the sidebar (loadUserSettings, setupThemeContext), and when loading avatars for other members (loadMemberContext). Calculations are done using the code I wrote for Aeva Media 2.x. Non-transparent avatars get an 'opaque' class, while nothing special is done for attachments right now. Maybe we'll do something later, but I'm lacking inspiration. (Display.php, Load.php, Subs.php)
Re: New revs
« Reply #1276, on January 27th, 2012, 04:45 PM »
rev 1276
(5 files, 3kb)

+ Just like at Wedge.org, Wedge will now add a New icon next to the page index if there are more unread topic pages available to you. Although it's not as important as back in the day when SMF was buggy and marked an entire topic as read even with more pages unread, it's still nice to easily spot whether there are more pages to go through. (index.template.php)

+ Show a New icon next to the first unread post in topic pages. Wedge.org does it differently (it adds a New icon next to all unread posts), but I felt this might be a bit overwhelming in a generic forum system. (Display.php, Display.template.php)

* Optimized the 'new' icon's size. Didn't expect to save anything, but there you go, a few less bytes. (images/language/new.gif)
Re: New revs
« Reply #1277, on January 27th, 2012, 04:56 PM »
rev 1277
(25 files, 4kb)

* Renamed constructPageIndex() to template_page_index(), in keeping with the index template's naming guidelines. (index.template.php, 24 files in Sources)
Re: New revs
« Reply #1278, on January 27th, 2012, 06:34 PM »
rev 1278 -- another set of features I'd been meaning to add from day one!
(4 files, 5kb)

+ Added number of new posts available per topic in the Unread Topics and Unread Replies pages. Another proud feature from Noisen/Wedge.org! And yes, I know, it's a bit of a slow query... But I think it could be worse. And it never killed my forums, after years of use. (Unread.php, UnreadReplies.php, Recent.template.php)

* Remove the thoughts block if no thoughts are found at all. (Welcome.php)
Re: New revs
« Reply #1279, on January 27th, 2012, 09:07 PM »
rev 1279
(10 files, 4kb)

* Harmonized block headers in the sidebar. Some were using we:title, others were using we:title2, now they're all using we:title. (Display.template.php, GenericMenu.template.php, MessageIndex.template.php)

* Started harmonizing font sizes in the sidebar. Right now it'll look ugly on a stock install, but that's because I'm doing the styling in the new skin, which has yet to be committed. Trust me, it's looking good. (GenericMenu.template.php, InfoCenter.template.php)

- Removed info center's toggler button, because it's of absolutely no use, and a waste of bandwidth. If you want it, you can always, I don't know, get a life. (Boards.php, Welcome.php, InfoCenter.template.php, Welcome.template.php, index.rtl.css, sections.css, Warm/index.css)
Re: New revs
« Reply #1280, on January 28th, 2012, 04:09 PM »
rev 1280
(10 files, 4kb)

+ Implemented sidebar positioning through skin settings, i.e. <sidebar>. (Load.php, Aeva-Gallery.php, Subs-Cache.php, skin.xml, Warm/skin.xml)

* Replaced $context['post_position'] with $context['sidebar_position'] in topic pages, and inverted their logic obviously. (Display.php, Display.template.php)

* wetem::parent() is a much more elegant way of determining whether the current block is executed in the default layer or in the sidebar... (Media.template.php)

* Micro-styling. (admin.css, media.css)
Re: New revs
« Reply #1281, on January 28th, 2012, 05:04 PM »
rev 1281
(5 files, 2kb)

* Simplified the final keyword's regex. (Class-CSS.php)

! The final keyword wasn't properly removed if followed with a colon, e.g. ".class final:before". Instead of just added that possibility, I decided to turn the str_replace into a preg_replace with word boundaries, which should be future-proof. (Subs-Cache.php)

! Media area's Home/Albums/Playlists header should be a title header, rather than a category header. (Aeva-Foxy.php, Media.template.php, media.css)
Re: New revs
« Reply #1282, on January 29th, 2012, 05:56 PM »
rev 1282
(3 files, 2kb)

* I was really, really bothered by the limitations on the 'content' tag in WeCSS. Added some reasonably fast code to protect it.[1] (Subs-Cache.php)

+ Added support for text-overflow on browsers using a prefix for it. (Subs-Cache.php)

- Removed new_win class from Print button, as it didn't exactly open a new window. (Display.php)

! Undefined variable. (Welcome.template.php)
 1. Wasted a couple of hours trying to rewrite Class-CSS and Subs-Cache in more 'efficient' ways, but it was buggy... In the end, the added code really isn't much trouble anyway.
Re: New revs
« Reply #1283, on January 30th, 2012, 04:29 PM »
rev 1283
(5 files, 5kb)

* Optimized 'content' tag handling speed in WeCSS, and ensured entire lines would be saved. See, the content syntax is quite odd, allowing for multiple strings within quotes, so I might as well save them all. (Subs-Cache.php)

* Profile homepage was missing a closing div, and had improper styling. Hopefully that short inline style thing is just temporary... Also spacinazi. (Profile.template.php)

+ Added board url to the recentTopics() function, just in case. Also spacinazi. (SSI.php)

* Removed 'buttonstrip' class from button list links (you can target them simply with ".buttonlist a"), and moved the 'last' class to their parent li tag, to make it easier to style. (index.template.php)

* News box should be a bit taller. No need to make it so short really...? (admin.css)
Re: New revs
« Reply #1284, on January 31st, 2012, 06:01 PM »
rev 1284 -- Gosh, I don't want to touch the select box code ever again!
(3 files, 2kb)

+ Added ability to hide a select box option by specifying 'data-hide' to its original option tag. This is effectively helpful for placeholder "defaults" like in the Quick Access box. Internally, it will behave as a hidden 'disabled' item, so that keyboard events don't reach it. (sbox.js)

! Setting a select box size to fixed will later set its width to zero if all its items are disabled or hidden. (sbox.js)

* Started adding a few data-hide properties here and there. (PersonalMessage.template.php, script.js)
Re: New revs
« Reply #1285, on January 31st, 2012, 10:05 PM »
rev 1285
(60 -7 files, 30kb)

* Renamed the 'sticky topic' feature to 'pin/unpin'. It makes more sense, and semantically it's better to clearly differentiate between doing and undoing an action. The 'make_sticky' permission is renamed to 'pin_topic'. Plus, SMF is 'stuck' with 'stickied'. Meh! (index.php, install.sql and 5 other/* files, Display.php, JSModify.php, ManageAttachments/Permissions/Search/Settings.php, MessageIndex.php, Pin.php, Post.php, Post2.php, QuickMod.php, RemoveTopic.php, ScheduledTasks.php, Search2.php, Security.php, SplitTopics.php, Subs-Post.php, Unread.php, UnreadReplies.php, images/icons/quick_*.gif/small_pin.gif, LANGUAGES: EmailTemplates, Errors, Help, index, ManageMaintenance, ManagePermissions, Modlog, Post, Reports, Search, Who, Wireless, TEMPLATES: ManageMaintenance, ManageSearch, MessageIndex, Post, Recent, Search, Who, Wireless, SKINS: index.css, index.member.css, index.rtl.css, sections.css)

* I believe unpinning a topic should generate a notification just the same way pinning it would. (Pin.php)

- SMF bug: testing for a $sticky variable that is never set. (Display.php)

- SMF bug: show_sticky.gif is a leftover from the Core theme... (show_sticky.php)

- SMF bug: lockicon and stickyicon IDs are never defined. (MessageIndex.template.php)

! Translation error. (Help.french.php)
Re: New revs
« Reply #1286, on January 31st, 2012, 10:44 PM »
rev 1286
(3 files, 2kb)

+ Wedge will now specify as the body id whether the current page is an action, board or topic. Might be very helpful for skinners and modders. (index.template.php)

! Don't select items in open select boxes if clicking them with the middle or right mouse button. (sbox.js)

! Chrome (and maybe others) wouldn't register function keys and other various keys when a select box was open. (sbox.js)

* Var-nazi. (topic.js)
Re: New revs
« Reply #1287, on February 1st, 2012, 02:50 PM »
rev 1287
(14 files, 3kb)

* Renamed main_content div to just 'main'. I've double-checked, no single element in Wedge uses 'main' as its id, so why waste good bytes on a long name for this one...? (other/install.php and 6 other files, index.template.php, index.css, index.iphone.css, skin.xml, Warm/index.css, Wuthering/index.css, Wuthering/skin.xml)
Re: New revs
« Reply #1288, on February 2nd, 2012, 07:12 PM »
rev 1288
(8 files, 8kb -- 88, like the rev number? Another boring coincidence.)

! Fixed weToggle object to actually remember the latest choice. It was broken in both cookie and database modes. (script.js)

* Simplified weToggle object. oCookieOptions only had one option (whether to use cookies or not), so it's now directly indicating the cookie name if it has to be used. The oThemeOptions object was simplified similarly. Removed sThemeId because it's only used in one place, and can be added to sAdditionalVars. Which I renamed to sExtra because, eh, it's shorter. And finally, only print a variable if it's to be set to true. (Boards.template.php, index.template.php, Post.template.php, script.js)

* Replaced many of the key/val placeholders in $.each with the this keyword. Did it everywhere it helped save more gzipped space. That's everywhere but two places. (script.js)

* Replaced the weCookie object with a cookie getter (still called weCookie, though), because the setter didn't make use of the object itself and the getter didn't get the updated cookie so I'd rather do the cookie parsing every time a cookie is requested. Plus, it saves space. For the record -- over 100 gzipped bytes in this commit alone. (script.js)

* sha1.js is always loaded alongside script.js, so don't bother printing the extra copyright info at compilation time. (sha1.js)

* Updated the New icon in both English (better looking W) and French (shortened 'Nouveau' to 'Nouv', because it's perfectly understandable, and takes less space.) (images/language/new.gif)
Re: New revs
« Reply #1289, on February 3rd, 2012, 03:12 PM »
rev 1289
(7 files, 3kb)

+ Added align parameter to the img bbcode. Pete, please implement the UI for changing bbcodes, because it's a nightmare to do manually :P (install.sql, index.css)

! The sendpm() function was using $context['forum_name'] at one point, without globaling it. (Subs-Post.php)

* Renamed noi_resize() to weres(), and now using it to test whether the page is loaded, instead of window.eves which isn't available if the HTML code holds no inline events. (index.template.php, sbox.js)

- Why should we need to keep these weToggle objects into global variables, when they won't be used at all...? (Boards.template.php, index.template.php)

* Inline JS simplification. (Post.template.php)