New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #795, on May 22nd, 2011, 08:17 AM »Last edited on May 26th, 2011, 11:51 AM by Nao/Gilles
rev 780
(4 files, 10kb)

* Zoomedia now properly resizes a zoom box to the viewport height when needed, and gets rid of the description to save space. (zoomedia.js)

* The aelink class is no longer a class for links but for the link container in item descriptions. Cleaner this way. (Subs-Media.php, media.css)

* Avatar selection code was too big when it could be done in 5 lines. Uh. (Profile.template.php)

* Server-based avatar selection box was too large. Now it should be better integrated. (Profile.template.php)
Re: New revs
« Reply #796, on May 22nd, 2011, 11:59 PM »
rev 781
(1 file, 5kb)

! Safari and Chrome didn't reset the sidebar when resizing to a small viewport and then back to a normal viewport. Fixed by setting the 'hidden' sidebar state to a block instead of a table. Sounds easy but it took hours to debug. Hate it when it happens. (index.css)

(Just wanted to commit this ASAP because it really was a PITA. I'm surprised Pete didn't notice anything -- you're using Chrome right?)
Re: New revs
« Reply #797, on May 24th, 2011, 12:34 AM »Last edited on May 26th, 2011, 11:51 AM by Nao/Gilles
rev 782
(4 files, 9kb)

! Fixed various issues in several browsers when resizing a zoom box to fit the viewport height. Had to add a IE6/7 hack to make it barely work, though. Will try fixing it later. (zoomedia.js)

* Applied the Opera 'hack' to all browsers, because it actually works best when resizing the screen. (zoomedia.js, zoom.css, zoom.ie6.css, zoom.ie7.css)

* Optimized a few bytes by turning 'auto' into a variable. (zoomedia.js)

! Fixed zoom box padding when showing HTML. (zoom.css)

! Fixed potential JS error when cancelling a zoom before the image was actually loaded at all. (zoomedia.js)

PS: I committed my fixed zoomedia.js because it currently works in IE6/7/8, Chrome and Opera (didn't test other browsers.) But it could be better really... I'm super-pissed.
Re: New revs
« Reply #798, on May 25th, 2011, 03:23 PM »Last edited on May 26th, 2011, 11:51 AM by Nao/Gilles
rev 783
(4 files, 7kb)

* Rewrote the zoom box resizer to rely more on CSS and less on browser hacks... Only to fail miserably, because IE7 wouldn't cooperate. Oddly, IE6 fares much better here. So, I'm now using hacks only for IE7, including a very ugly one. Hardcoding a width value? Somebody do something! (zoomedia.js, zoom.css, zoom.ie6.css, zoom.ie7.css)

! Forgot a semi-colon to close a function variable. (zoom.css)

PS: if I have to spend ONE extra minute on this fucking resizer code, I'll kill a random cat!! So IE isn't pixel perfect on description paddings here, and I don't fucking care. It's the first time I'm getting it to work on ALL browsers I tested on...
Re: New revs
« Reply #799, on May 25th, 2011, 03:24 PM »Last edited on May 26th, 2011, 11:51 AM by Nao/Gilles
I'm committing in three small thematic batches -- if it's any more readable...

rev 784
(2 files, 7kb)

! Made sure that // comments in CSS files are stripped if they're at the beginning of a line, regardless what they're followed by. (Subs-Cache.php)

* Prevented jQuery from being re-minified. Saves processing time and gives better results. (Subs-Cache.php, jquery-1.5.2.js)
Re: New revs
« Reply #800, on May 25th, 2011, 03:27 PM »Last edited on May 26th, 2011, 11:51 AM by Nao/Gilles
rev 785
(3 files, 5kb)

+ Added two tentative new hooks in the topic display loop: display_prepare_post and display_post_done. (Display.php)

! Some of the user menu code was prepared even if no menu was to be displayed. (Display.php)

! Some browser still had issues with the sidebar transmorphing code. (index.css)

- I don't see any reasons to add a meta description that's exactly the same as the page title. Waste of bandwidth. (index.template.php)
Re: New revs
« Reply #801, on May 26th, 2011, 11:50 AM »
rev 786
(7 files, 11kb)

+ Added support for 'glass' outline type in Zoomedia. It's also enabled by default, at least for now. (Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Media.language.php, zoom.css)

! Zoomedia didn't comply with the expand duration variable. Also made sure to change its default from 250 to 800ms. Let's enjoy these animations, shan't we? (Aeva-Gallery2.php, Aeva-Subs-Vital.php, zoomedia.js)

! Found the reason for the IE7 bug... 'overflow: hidden' triggers hasLayout and messes up with its width. Setting it to hidden after calculating the width does the trick. (zoomedia.js, zoom.css)

! Zoom out animation wasn't correctly resetting the overflow value either. (zoomedia.js)

- Removed a debug line. (zoomedia.js)

- Removed closeOnClick option (will never be used, seriously.) (zoomedia.js)

NB: the new trick is tested in IE6, IE7, IE8 and Firefox 5. Haven't tried in other browsers... Please do it for me? :angel:

NB²: do you like it if I separate the changelog lines with extra line breaks like on this page...? Is it more readable or just not worth it?
Re: New revs
« Reply #802, on May 26th, 2011, 11:33 PM »
rev 787
(1 file, 4kb) (actually just an if() test added...)

! Well, in the end, I STILL get to re-introduce an IE7 hack... Glitch otherwise happens when opening an item without resizing it, and showing a multi-line description. Stupid hasLayout! (zoomedia.js)
Posted: May 26th, 2011, 11:26 PM

rev 788
(1 file, 5kb) (just reverting the previous addition, and moving a line around...)

! I really must insist on removing these hacks, sir... Just hoping I'm not breaking Firefox 3.5.7 beta 2 for Ubuntu 1.03 alpha 7 by doing this. I've seen stranger things you know. (zoomedia.js)
Re: New revs
« Reply #803, on May 27th, 2011, 10:17 PM »
rev 789
(61 files, 44kb)

+ Added $context['session_query'] = $context['session_var'] . '=' . $context['session_id'], which should save some valuable CPU time concatenating these strings into URLs... There were over 300 occurrences to modify. (Load.php and all other files in this commit. Should allow for an easy mass-revert in case problems arise.)

(As per our discussion a few weeks ago!)
Re: New revs
« Reply #804, on May 27th, 2011, 11:12 PM »Last edited on May 29th, 2011, 12:15 AM by Nao/Gilles
rev 790
(1 file, 6kb)

! Don't animate menus if the mouse cursor exits the menu zone and immediately comes back to it through the same menu entry. (script.js)

* Some code optimization to help minification... Although, funny story, it fares worse in the gzipping stage. Yay. (script.js)
Re: New revs
« Reply #805, on May 29th, 2011, 12:16 AM »
rev 791
(12 files +1-1, 18kb)

* Changed windowbg colors a tiny bit to make them a bit more lively. (index.css)

* wrc-based intertitles now use the h6 tag. Hopefully it shouldn't carry too much weight and can be used any way you like. (index.css)

* Reworked the stats page layout. Both windowbg colors are now used. The first area gets its items reordered in a more logical way. Got rid of title2 blocks in favor of h6. (Stats.template.php, index.css, sections.css)

* Renamed $txt['parent_boards'] to $txt['sub_boards'], to reflect what it's actually used for... (I call that a SMF bug.) (BoardIndex.template.php, MessageIndex.template.php, Wireless.template.php, index.language.php)

* Updated some icons to use the same size as the others. (stats_posters.gif, stats_replies.gif)

- Forgot to delete jQuery 1.4 from the SVN. (jquery-1.4.4.js)

! Glass effect in Zoomedia didn't work in Safari. (zoom.css, zoom.webkit.css)

! Fixed validation error (divs in ths). (Stats.template.php)

* Indenazi. (zoomedia.js)
Posted: May 29th, 2011, 12:14 AM

(Note: rev 792 is a dummy/empty one, due to a wrong manipulation.)
Re: New revs
« Reply #806, on May 31st, 2011, 10:57 AM »
rev 793
(7 files, 10kb)

! Item upload page would consider empty quota lists as errors, instead of falling back to the overall default quota. (Aeva-Gallery.php)

! Error in the English version -- "add an item to this album" should just be "add an item", since the item uploader allows you to choose your target album... (Media.english.php)

* Readability nazi. (Subs-Media.php)

* Sidebar shouldn't have cat blocks. Using title2 in calendar. (Calendar.template.php)

* h6 intertitles have no reason to be linked to .wrc, since they're never used in other situations. (index.css)

* Zoomedia's glass effect was a tad too strong in some situations. (zoom.css, zoom.webkit.css)
Re: New revs
« Reply #807, on June 1st, 2011, 08:04 PM »
rev 794
(8 files, 17kb)

* Overhaul of the credits area. Still needs some work. (Credits.php, Who.language.php, sections.css, Who.template.php)

* Simplified the footer copyright, given that it'll be legal by the end of the week... (index.language.php)

* Reworked stats area to show long strings over the entire line instead of cutting it in half. Try resizing the window to see how it improves on the earlier behavior. (sections.css)

! Fixed a session bug (thanks TE). (Login2.php)

NOTE: this does NOT include the font family changes I made to Wedge...
Re: New revs
« Reply #808, on June 3rd, 2011, 06:23 PM »
rev 795
(8 files, 10kb)

* Credits update. Added nice little South Park avatars of the Wedgeward guys, sorted long lists in (an)alphabetic order, removed a consulting developer (who never committed to the actual repository), and moved the remaining one (that's me) to the developer list (since that's what I was, unofficially.) (Credits.php)

* Made sure the copyright list takes the entire width in the credits area. (Who.template.php)

! Poll questions are limited to 255 characters, just like poll options. (Poll.template.php)

- Removed some unused or useless font fallbacks. (media.css, report.css, sections.css, Warm/index.css, Wuthering/index.css)
Re: New revs
« Reply #809, on June 4th, 2011, 06:16 PM »
rev 796
(4 files, 7kb)

! Usernames with special characters were incorrectly processed in profile pretty URLs. (QueryString.php)

* Use a dfn tag rather than a custom span to show the help text for password changing. (Profile-Modify.php)

* Don't hide additional membergroups if there aren't enough to justify it. (Profile.template.php)

* Parenazi. (Subs.php)