New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #705, on April 8th, 2011, 01:42 AM »
rev 687
(3 files, 5kb)

! Load Aeva-Gallery2.php properly. Allows viewing the media pages in profile areas. (ManageMedia.php, Profile.php)
! The thing is called Exifixer, not Exifer, even though the original library says Exifer... (exif/exif.php)

(Some last-minute changes before I go to bed.)
Re: New revs
« Reply #706, on April 8th, 2011, 02:15 PM »
rev 688
(9 files +1, 12kb)

! A couple of areas still had mod_security compatibility issues. One of them was pointed out by myself and [Unknown] in 2009 to the SMF team and never fixed. I only remembered it now. Way to go, SMF. (ManageAttachments.php, Media.template.php)
* Added support for the newest URLs of YouTube. (Subs-Aeva-Sites.php)
+ Might as well put that useless $txt['lang_dictionary'] to good use and use it as a lang parameter in the html tag until we add a proper 2-letter code entry. (index.template.php)
+ Added an index.php protection to the Sources/media folder. Not very useful though.... (media/index.php)
* Renamed action=helpadmin;help=... to action=help;in=... because we no longer use the help action anyway, and it's not only for use in the admin area. Will do the rest in a batch in the next commit. (index.php, Help.php, Load.php, ManageMembergroups.php)
Posted: April 8th, 2011, 02:07 PM

rev 689
(23 files, 16kb)

* Finished renaming helpadmin to help. (All 23 files.)
Re: New revs
« Reply #707, on April 8th, 2011, 09:28 PM »
rev 690
(10 files, 24kb)

! parsesmileys() would search for every smiley twice (once in a normal version, once in a htmlspecialchar'ed version), even if they were the same. It also applied htmlspecialchar to a same string three times in a row... Oh please, come on! (Subs-BBC.php)
* Optimized parsesmileys() replacement code. Both versions are lightning fast. The new version is 10 to 20% slower when the string has no smileys, but 2 to 5 times faster when it meets one or more smileys. (Subs-BBC.php)
* Optimized the block replacement function code. Replaced the super-cool regexp with a lame series of strpos calls. The new version is much faster when using hundreds of blocks, but a bit slower with few blocks (could be made faster by removing the case-sensitivity code.) It's still more robust anyway, and easier to understand. (Subs.php)
* Providing a means for the playlist area to know whether the album link should be shown. Yeah I know -- extra query... (Aeva-Foxy.php)
* Simplified media menu and fixed current area highlighting. (Aeva-Gallery.php)
! Fixed headers in playlist area. (Aeva-Foxy.php)
! Some areas didn't properly rename Aeva-Subs to Subs-Media. (Aeva-Subs-Vital.php, Subs-Media.php, Subs-BBC.php, Subs.php, Who.php)
! Converted the Aeva Media changelog to UTF8, to avoid errors at parse time. This will eventually be used in the Wedge changelog, hopefully. (default/aeva/changelog.txt)
* Minor button strip fixes. Hopefully the new forced overflows won't break anything. (Media.template.php, index.css)
! .title2 link color should be the same as when not linked. (index.css)
Re: New revs
« Reply #708, on April 9th, 2011, 12:08 AM »
rev 691
(7 files, 12kb)

- Removed case insensivity code from the block replacement path. Although very fast, it's not worth the trouble -- just be wise and use lowercase, there's no point in going uppercase here. (Subs.php, index.template.php)
! Fixed <if> replacements in the new code. (Subs.php)
! Block building code in Load.php was needlessly long (by 11 lines!), and forgot to apply the scripturl transform. (Load.php)
! Fixed image URLs in Media stylesheets. (media.css, up.css)
* Moved dummy block overrides from Wine to Warm (our 'sample case'), where I can take some time to explain what it does... (settings.xml, Warm/settings.xml)
Re: New revs
« Reply #709, on April 9th, 2011, 12:56 AM »
rev 692
(1 file, 5kb) (Uh, actually one byte changed :P)

! Mismatched tags. (MessageIndex.template.php)
Re: New revs
« Reply #710, on April 9th, 2011, 04:29 PM »
rev 693
(forgot to check stats, whatever.)

+ Added media icon to the main menu. (sprite-menu-32bit.png, sprite.png, Subs.php, index.css)
+ Added 3 pixels around each menu icon to avoid getting artifacts in some browsers (IE6, Safari Mobile...) (sprite*.png, index.css)
! Fixed three syntax errors in the ban manager. (ManageBans.php)
* A small change to avoid infinite loops when a tag is unclosed. (Subs.php)
* Starting HTML5 conversion of Media templates. Okay, just three lines... So what? (Media.template.php)
Re: New revs
« Reply #711, on April 9th, 2011, 05:42 PM »
rev 694
(5 files, 7kb)

* Moved the admin notification area to the actual template to avoid issues with <we:> tags, and removed the related code from admin.js -- which was only used for that one case anyway. (Admin.template.php, admin.js, admin.css)
* It's Wedge, not SMF. (Admin.language.php)
Re: New revs
« Reply #712, on April 10th, 2011, 01:52 AM »
rev 695
(21 files +1-1, 29kb)

* Made Media area work. It is now possible to create albums, upload single items, and view the album and item pages. The rest is coming, of course. (Media.template.php, media.js and other files.)
! Fallback code in the wesql::insert function was incorrect. (Class-DB.php, Aeva-Gallery.php, Aeva-Gallery2.php
! Fixed (un_)preparsecode calls in Media area. (Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php,
! Fixed call to media.js and hs.css in Media area. (Aeva-Gallery.php, Media.template.php)
* Outdated table names. (Subs-Media.php)
* Renamed wedgeEditor object to wedit, for consistency reasons. (Class-Editor.php, Display.php, Jseditor.php, JSModify.php, ManageNews.php, ModerationCenter.php, MoveTopic.php, PersonalMessage.php, Post.php, Subs-Media.php, Post2.php, Profile-Modify.php, QuoteFast.php, Subs-Post.php)
* Minor details. (Media.template.php)

More coming tomorrow... Just a bit late, see?
I'm very glad that the gallery finally works. It was less work than expected (I estimated two weeks of work minimum, not one week!)
Re: New revs
« Reply #713, on April 10th, 2011, 02:20 PM »
rev 696
(25 files -1, 34kb)

* Enabled Gallery and Auto-embed settings to actually be enabled/disabled through the Core Features area. Hide the main and admin menus with respect to these settings. (Admin.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, ManageMedia.php, ManageMedia3.php, Subs-BBC.php, Subs.php, Media.english.php, Media.french.php)
* Core Features should be detected through an isset(). Should be faster than in_array(). Both methods will be available until everything's converted. (Admin.php, Load.php)
* Renamed Exif to Metadata in the UI and internally, to make room for potential future implementations. (db_aeva.php, Aeva-Foxy.php, Aeva-Gallery.php, Class-Media.php, ManageMedia.php, Subs-Media.php, Media.template.php, Admin.english.php, Admin.french.php, ManageMedia.english.php, ManageMedia.french.php, Media.english.php, Media.french.php)
* Renamed a few remaining 'aeva' fields to 'media' or 'misc'. (db_aeva.php, Load.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia2.php, Subs-Media.php, Subs.php, Media.template.php)
- Removed Sources/media/exif folder, as it was an old version of Subs-Exif.php (oops.)
! Calling in_array('m', array('m,cd,cp')) is going to return false. I'm just telling you, SMF. This is how it works. (install.sql, Load.php)
! Fixed infinite loop when dealing with an empty menu. (Subs-Menu.php)
Re: New revs
« Reply #714, on April 10th, 2011, 04:14 PM »
rev 697
(9 files, 11kb)

* Renamed (again) media and auto-embed core features to use 'media_enabled' and 'embed_enabled' single settings. Eventually, core features will all have their own settings and use them where needed. (install.sql, Admin.php, ManageSettings.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-Subs-Vital.php, Subs-Media.php, Subs-BBC.php, Subs.php)
Re: New revs
« Reply #715, on April 11th, 2011, 01:22 PM »
rev 698
(14 files, 16kb)

* Turned admin_features into a series of variables. (install.sql, upgrade.sql, Admin.php, Display.php, Load.php, ManagePermissions.php, ManageSettings.php, ModerationCenter.php, PersonalMessage.php, Profile-View.php, Profile.php)
! Fixed post boxes in media area. (Subs-Media.php, Media.template.php)
* Temp header update. (media.js)
Re: New revs
« Reply #716, on April 11th, 2011, 07:46 PM »
rev 699
(2 files, 12kb)

- Removed self-closed tag closers (?) from Media templates and fixed a few things (labels, etc.) Source files aren't done yet. (Media.template.php, ManageMedia.template.php)
Posted: April 11th, 2011, 07:17 PM

rev 700
(12 files, 15kb)

- These source files have tons of templating in them... So much for the MVC model uh. Removed all />'s where needed, and a few more fixes as usual. Renamed all remaining SMG tags to MEDIA. (Sources/media/*, ManageMedia.language.php, Media.template.php)
Re: New revs
« Reply #717, on April 11th, 2011, 11:29 PM »
rev 701
(6 files, 11kb)

! Fixed lists of children albums looking really bad due to the new rounded corner markup. Well, I couldn't find a perfect solution so I made a couple of changes. I'm not satisfied though... (Subs-Media.php, media.css)
! Minor thingies. (ManageMedia.english.php, Media.template.php, hs.css)
+ Added .wrc_top and .wrc_bottom classes, in case they ever make themselves useful. Not for now though... (index.css)
Re: New revs
« Reply #718, on April 12th, 2011, 04:11 PM »
tl:dr --- mass upload fixed :)

rev 702
(10 files +1, 32kb)

* Added support for icon transparency in playlist headers. (Aeva-Foxy.php, media.css)
* Cleaned up mass upload interface and JS, and delayed said JS to the bottom. (Aeva-Gallery2.php, Media.template.php, index.css, up.css)
! Fixed mass upload. It now actually works, although the jQuery version is still being worked on. (up.js, uploader.js)
! Fixed some wrong paths for Media scripts. (Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia.php)
! Silly oversight in block replacement code caused empty params to show an unprocessed if-block instead of hiding it or processing it. (Subs.php)
Re: New revs
« Reply #719, on April 12th, 2011, 06:13 PM »
tl:dr -- Highslide fixed :)

rev 703
(5 files +1-2, 115kb) (that's mainly because of the JS files being swapped... Actual changes are minor.)

! Forgot to capture a match during template error processing. (Load.php)
! Fixed Highslide support. (Aeva-Subs-Vital.php, aeva/highslide.js)
* Fixed item pages with no comments to show something actually watchable. (Media.template.php)
* Restored jQuery version of uploader JS, as I finally found why it was going cuckoo. (up.js)