New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #555, on January 23rd, 2011, 06:30 PM »
rev 517

* Finished HTML5 conversion work, w3:cat and button_submit transforms. Ahhhhhhh!!! (create_backup.php, test_modification.php, repair*.php, Load.php, Admin.english.php, Admin.french.php, editor.js, script.js, suggest.js, topic.js, TEMPLATES: Admin, Announce, BoardIndex, BoardIndexInfoCenter, Display, GenericControls, GenericList, GenericMenu, Help, Login, ManageAttachments/ Bans/ Calendar/ Mail/ Maintenance/ Membergroups/ Members/ News/ Paid/ Permissions/ ScheduledTasks/ Search/ Smileys, ModerationCenter, MoveTopic, Notify, Packages, PersonalMessage, Poll, Post, Printpage, Recent, Register, Reminder, Reports, Search, SendTopic, SplitTopics, Stats, Themes, Who)
! Missed one search input conversion. (Search.template.php)
! Typo. (Search.english.php)
Re: New revs
« Reply #556, on January 23rd, 2011, 08:50 PM »
rev 518

+ Added support for CSS variables, as well as the ability to set their values depending on the current CSS state (browser, rtl, login...) (Class-CSS.php, Subs.php)
+ Added ability to supply a member.css file for logged in users. (Load.php)
+ Added the following default CSS variables: $images, $theme, $root and $here. (Subs.php)
* Renamed {root} to $behavior in settings.xml, to make it easier to understand, in light of the new CSS variables. (Subs.php, settings.xml)
* Tweaked Nix header settings for a less dark outcome. (Nix/index.css)
! The dynamic sidebar doesn't work in IE6 and IE7. Tweaked the code to at least avoid error messages at startup. Will require a deeper rewrite later, though. (index.template.php)
! Fixed a couple of wrong URLs and added a sample variable to the Warm styling. (Warm/index.css)
- Removed relative path fixer, as it was no longer needed. (Subs.php)
- Removed h3.grid_header, as it's never used anywhere. (admin.css)
* Rewrote button hack for IE6 in Pastel. Now it should actually work. (ie6.css, settings.xml)
* Rewrote CSS files to use $images instead of relative paths. (admin.css, editor.css, settings.xml, index.css, rtl.css, sections.css)

(Phew!!! At last, finished with the big commits :))
Posted: January 23rd, 2011, 08:45 PM

rev 519

* Fixed a few inverted rules and added a newline to the beginning of all CSS files (for consistency.) (css/*.css)
Re: New revs
« Reply #557, on January 24th, 2011, 12:15 AM »
rev 520

! Fixed a SMF bug: a deletion confirmation was apparently only asked... if the entered data was invalid in the first place. (ManageSearch.template.php)
! Fixed a Nao bug: autoSetup() was broken during the conversion to jQuery. (register.js)
* Converted most of the remaining stray getElementById's in inline events. Left aside the ones that can't use jQuery, and those that are in loops. (Calendar.template.php, ManageMembergroups.template.php, ManageSmileys.template.php, MoveTopic.template.php, Profile.template.php, Register.template.php, post.js, register.js, script.js, suggest.js, topic.js)
* Converted admin.js to jQuery... Yes, apparently I'd missed the file. (admin.js)
Re: New revs
« Reply #558, on January 24th, 2011, 10:17 AM »
rev 521

+ Added ability to add double quotes around CSS variables (allowing empty strings to be set), and recursive replacements to allow using variable names inside other variable definitions. (Class-CSS.php)
* Updated button code to provide IE fixes for IE only. (index.css)
* Backported Warm changes to Pastel. (index.css)
+ Added a proper member-only file to both Pastel and Warm. (member.css)
* Styled Remove button in the post attachment area. (post.js)
! Fixed bevel in Simple Search area's search button. (sections.css)
! Typo. (admin.js)
Re: New revs
« Reply #559, on January 24th, 2011, 04:31 PM »
rev 522

+ Added very basic support for CSS functions, starting with darken() and lighten(). They don't even take luma coefficients into account, ah ah, what a noob! (Class-CSS.php, Subs.php, index.css)
* In Post pages, show the original post's title in linktrees under square brackets and without extra spacing. Looks a tad better this way. (Post.php)

(Class-CSS adds a few functions from the PHP port of Sass -- I will end up using them, and I credited the originals, even though they're quite short and not exactly rocket science for anyone interested in RGB vs HSL.)
Re: New revs
« Reply #560, on January 24th, 2011, 08:41 PM »
Trying to change my mind after my complete and utter failure in RL... :(

rev 523

! Fixed SMF bug (how many SMF bugs have we found these last few months really?!), where the second JavaScript block in constructPageIndex wasn't updated to use JavaScriptEscape, resulting in (1) a small waste of time, (2) a fully visible incorrect URL, resulting in Google being able to fail on it. (Subs.php)
* Moved inline styling to the correct place. (Subs.php, index.css)
* Simplified titles and categories in Warm. (Warm/index.css, Warm/settings.xml)
Posted: January 24th, 2011, 08:39 PM

rev 524

! Woops. (Subs.php)
Re: New revs
« Reply #561, on January 24th, 2011, 09:23 PM »
rev 525

+ Rewrote darken/lighten to use a more realistic HSL transform, and added support for saturize(), desaturize() and hue(). Yeah baby. Tell me it sends shivers down your spine. (Class-CSS.php, Warm/index.css)
Re: New revs
« Reply #562, on January 24th, 2011, 11:24 PM »
rev 526

+ Added support for base64 encoding of images for non-IE browsers. Heck, it actually works, *and* compresses to the same size as usual... I don't even know if it's worth adding a setting to disable it... (Class-CSS.php)
! Fixed wrong hex encoding for RGB components lower than 16. (Class-CSS.php)
+ Added support for nested functions (darken(desaturize($color, 10), 10)) (Class-CSS.php)
Posted: January 24th, 2011, 11:09 PM

rev 527

! IE6 and IE7 don't support data URI schemes. Bad IE. (Subs.php)

@ Also of note: if you update an image, you need to also empty the cache or update a css file because Wedge won't guess it by itself... Seriously, I'm not checking all of these files on every page load!
Re: New revs
« Reply #563, on January 25th, 2011, 05:41 PM »Last edited on January 26th, 2011, 11:16 AM by Nao/Gilles
rev 528
(26 files, 31kb transferred)

! JPG images should have a MIME type of image/jpeg, not image/jpg. (Class-CSS.php)
* Minor changes. (Subs.php, latest-packages.php)
* Optimized CSS to only load some repeated images once. The size savings are better than I expected. (index.css, sections.css)
+ Added 'search' and 'cancel' classes to related inputs, to make it faster to find them (and avoid using some JS in IE.) There weren't a lot of them anyway. There's also one in Display but I'll commit it later. (sections.css, settings.xml, TEMPLATES: Admin, index, ManageAttachments, ManageBoards, Memberlist, PersonalMessage, Profile, Search)
! Fixed title_bar and cat_bar to title and cat classes. (Warm/admin.css, ie6.css, ie7.css, index.css, rtl.css, sections.css, webkit.css)
! Fixed icons, button padding and general handling of inputs for IE. (ie6.css, ie7.css, ie8.css, index.css)

PS: I'll try, from now on, to indicate the stats given by TortoiseSVN after I'm finished committing. This should make it easier to determine the amount of data you'll have to check. ;)
Re: New revs
« Reply #564, on January 25th, 2011, 11:48 PM »
rev 529
(1 file, 7kb)

! Fixed SMF bug: clicking frenetically the Quick Modify button at load time could result in errors and UI glitches. Fixed by only setting the edit mode as active after the actual original message is received. (topic.js)
* Let's just make this clear: if I'm editing a post, and I'm suddenly clicking the Quick Modify button for it, IT'S PROBABLY NOT WANTED. Cancelling any such actions. If you want to start a message over, use the Cancel button and then click Quick Modify. (topic.js)
* bInEditMode was redundant, using sCurMessageId now. Also replaced in Display.template.php, will commit later. (topic.js)

(It may not be the best fix, if only because I'm not even sure it fixes it, but it certainly works great in IE6 and Opera 11, where I tested, and it's a clean and short solution, as mentioned before.)
Re: New revs
« Reply #565, on January 26th, 2011, 11:15 AM »
rev 530
(12 files, 13kb)

! Fixed a SMF bug: if the outbox isn't empty, people should still be able to view it, even if they can't send *new* PMs. (PersonalMessage.php)
+ Added a message saying "A response to this message was sent." if you're viewing your outbox and at least one of the recipients replied to a message. This was way overdue... (PersonalMessage.php, PersonalMessage.english.php, PersonalMessage.french.php, PersonalMessage.template.php)
- Removed mentions about forwarding in "You have responded to this message". It was confusing. Whether you reply to the original poster or to someone else is your own choice, but it's not proper "forwarding". PMs are often private and this shouldn't be encouraged too much. (PersonalMessage.english.php, PersonalMessage.french.php)
! Fixed a variable collision due to a micro-optimization in smc_saveEntities. (script.js)
! Fixed a small IE6 layout issue in topic pages. (Display.template.php)
! Fixed potential browser errors if you're trying to access the quick modify or quick reply areas before they're actually initialized. Which should only happen if you're trying hard at doing it, really. (Display.template.php)
* A few !!!SLOW comments were converted to !!! SLOW. I just can't live with the idea of missing spaces. (Memberlist.php, PersonalMessage.php, Profile-View.php, Recent.php, Subs-Boards.php, Subs-Recent.php)
* Spellinazi -- 'accessable'. Urgh. (readme_convert.html, Subs-Recent.php)
Re: New revs
« Reply #566, on January 26th, 2011, 03:55 PM »
rev 531
(8 files, 14kb)

+ Added ability to see the number of users who replied to a PM in the event of a mass PM. (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php, PersonalMessage.french.php)
! A regression in last commit concealed PM recipients in the inbox. (PersonalMessage.php)
! In the CSS parser, any hex RGB output could be corrupted by incorrect numbers, and didn't round numbers correctly. (Class-CSS.php)
* Don't add the 'o' prefix to Opera files when parsing box-shadow and border-radius. Ah ah, what a weird hack... (Subs.php)
* Modified comment stripping to actually keep comments starting with /*!, just like when parsing JS files. (Class-CSS.php, Subs.php, Warm/index.css)
* Disabled double clicks on the Quick Modify buttons. I need help, now. (Display.template.php)
Posted: January 26th, 2011, 03:18 PM

rev 532
(4 files, 15kb)

+ Added a Spellchecker icon of my making. (index.css, buttons.png, buttons-32bit.png)
Re: New revs
« Reply #567, on January 26th, 2011, 10:25 PM »
rev 533
(3 files, 6kb)

! Fixed toggler glitch where if the starting position was collapsed, the block would open and then animate to disappear. Uh. (script.js)
- Started removing nocsscache code... It's neat and all, but the CSS previewer is going away. Bye bye, we won't miss you that much, you can't fight the goodness that is CSS parsing. (QueryString.php, Subs.php)
+ Added a 'dynamic_rewrite' hook in ob_sessrewrite, to allow manipulating the buffer before the URLs are handled by the Pretty URLs module (the output buffer hook system happens *after* they're transformed, so it was really needed.) (QueryString.php)

(Toggler bug was visible in the news fader area on the board index, btw.)
Re: New revs
« Reply #568, on January 27th, 2011, 09:30 AM »
rev 534
(7 files, 13kb)

! Fixed the dreaded 'This address is already in use' that Pete hated so much. Eheh. (Subs-Boards.php, Subs-PrettyUrls.php)
! Translation errors or improvements. (ManageBoards.french.php, Themes.english.php, Themes.french.php)
Re: New revs
« Reply #569, on January 27th, 2011, 04:35 PM »
rev 535
(3 files, 12kb)

+ CSS parser now sports support for: alpha function (alpha(rgb(255,255,255), -.25) returns rgba(255,255,255,.75) if the browser supports it), named colors (the 16 basic HTML ones plus 'grey' for Pete's sake), hsl, hsla, rgba, mixed case, and 3-letter hex codes. PHEW! (Class-CSS.php)
* In case of a syntax error while parsing CSS, you'll get a big red color instead. That should tell you where to look... (Class-CSS.php)
! Since HTML5 is case-insensitive, inline event tags should be as well. (QueryString.php)
! " is automatically turned into a double quote inside inline events, but this is not the case outside of these. Converting them manually. (QueryString.php)
! Fixed the very annoying bug where newlines in JavaScript alerts/confirms were shown in plain text as \n. Oh, this one was annoying. (QueryString.php)
* Dotnazi. (Profile.english.php)
Posted: January 27th, 2011, 04:22 PM

BTW, some friends are visiting in a few minutes so I'll probably be offline for the entire evening. ;)