Plugin revs

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Plugin revs
« Reply #75, on January 31st, 2014, 10:26 PM »
[Commit revision baab37a]
Author: Nao (Signed-off)
Date: Fri, 31 Jan 2014 22:26:11 +0100
Stats: 2 files changed; +29 (insertions), -0 (deletion)

  • Missing strings in the Birthday plugin. Hopefully, these should be okay... (Birthday-Admin.english.php)
  • Why wasn't that file translated to French at all..? Heresy! Qu'on lui tranche la tête ! (Birthday-Admin.french.php)
Re: Plugin revs
« Reply #76, on February 1st, 2014, 05:31 PM »
[Commit revision 4a2b5a6]
Author: Nao (Signed-off)
Date: Sat, 01 Feb 2014 17:30:22 +0100
Stats: 7 files changed; +44 (insertions), -11 (deletions)

  • birthday: translation tweaks. (Birthday-Admin.french.php, Birthday-Mails.french.php)
  • calendar: Added my own national day. Because. (Subs-Calendar.php, CalendarHolidays.language.php)
  • calendar: removed showbdays setting (I don't think it's being used?), and years 2008-2011. Let's not live too much in the past... (plugin-info.xml)
Re: Plugin revs
« Reply #77, on February 2nd, 2014, 07:52 PM »
[Commit revision 2d25292]
Author: Nao (Signed-off)
Date: Sun, 02 Feb 2014 19:50:35 +0100
Stats: 3 files changed; +10 (insertions), -10 (deletions)

  • Fixed calendar dates. (From SMF 2.0.7 patch.) (calendar/Subs-Calendar.php)
  • Indenazi. (we_pinterest/We-Pinterest-Main.php)
  • Duplicate scripts. (we_pinterest/We-Pinterest-Main.template.php)
Re: Plugin revs
« Reply #78, on February 4th, 2014, 11:09 AM »
[Commit revision 4da8074]
Author: Nao (Signed-off)
Date: Tue, 04 Feb 2014 11:08:25 +0100
Stats: 2 files changed; +17 (insertions), -53 (deletions)

  • Fixed We-Pinterest to, err... Actually work, I guess..? Honestly Pandos, I have no idea how the original plugin was supposed to work, but according to their API documentation, it looked like webmasters are supposed to add a Pinterest button manually for each of their images. Which wasn't done here. So I'm doing that Wedge-style, with jQuery goodies. I hope you don't mind. ;) (We-Pinterest-Main.template.php)
  • Removed a dummy file... I guess! (We_Pinterest-Admin.php)

Pandos

  • Living on the edge of Wedge
  • Posts: 635
Re: Plugin revs
« Reply #79, on February 4th, 2014, 11:41 AM »
Thank you :)
But... does it work for you?
# dpkg-reconfigure brain
error: brain is not installed or configured

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Plugin revs
« Reply #80, on February 4th, 2014, 11:51 AM »
Did my tests on that topic...
http://wedge.org/pub/bugs/8407/like-and-reposts/
Will disable the plugin once you're happy with the changes. As I have no-Interest-in-Pinterest, and I doubt anyone would want to pin a picture posted here...

Also, Pinterest recommends a minimum width of 750px, but I set it to 300px because, well, because. I think it's still an okay width... Especially if the picture is a portrait. Feel free to change it.

(And to everyone else: YES, you can comment on plugin revs if you want... No problem. The only locked topic is New Revs, and even that one may get re-opened one day, as it can be a hassle to find the New Revs Comment topic. Unless I add some kind of 'reply to new topic' thing...)

Pandos

  • Living on the edge of Wedge
  • Posts: 635
Re: Plugin revs
« Reply #81, on February 4th, 2014, 12:02 PM »
OK, it's really working here :)
Dunno why it's not working on my local copy...


Just before you have posted your fix I was about to implement the HTML5 code from Pinterest-Plus :)
https://github.com/skibblenybbles/PinterestPlus


If you want you can disable the plugin. Will take a look into it.
Re: Plugin revs
« Reply #82, on February 4th, 2014, 12:11 PM »
..and it doesn't work on AeMe....

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Plugin revs
« Reply #83, on February 4th, 2014, 12:16 PM »
In gallery pages? No reason for it to work, since you added this to a topic hook... Add it to any page, and it'll work, I suppose. ;)

Re: other plugin, have you seen the size of his source code..? :^^;: Mine is about ten lines... Lol.

Pandos

  • Living on the edge of Wedge
  • Posts: 635
Re: Plugin revs
« Reply #84, on February 4th, 2014, 12:24 PM »
Quote from Nao on February 4th, 2014, 12:16 PM
In gallery pages? No reason for it to work, since you added this to a topic hook... Add it to any page, and it'll work, I suppose. ;)
I think gallery is most important to Pinterest thingy :)
Quote
Re: other plugin, have you seen the size of his source code..? :^^;: Mine is about ten lines... Lol.
Yeah. It's huge :)
Your a genius @work ;)

OK, on my ToDo list there is something like a setting in admin area, where you can change the needed size of images and change the button layout.

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Plugin revs
« Reply #85, on February 4th, 2014, 02:34 PM »
Sure.

BTW, I'd recommend against having the on/off setting. If you want to disable We-Pinterest, you should disable the plugin entirely, rather than set this setting. It'll save some processing time here and there -- it's not free.

Okay, I tried changing the main hook to point to 'load_theme' instead of display pages, and it still doesn't work on AeMe pages. It looks like the function is not called at all (including here). Well, I'm not sure why... Anyone?
Re: Plugin revs
« Reply #86, on February 4th, 2014, 03:23 PM »
[Commit revision 46791bb]
Author: Nao (Signed-off)
Date: Tue, 04 Feb 2014 15:23:05 +0100
Stats: 2 files changed; +2 (insertions), -0 (deletion)

  • Regards, team -- was missing. (Birthday-Scheduled.php, WedgeDesk-Notifications.php)
Re: Plugin revs
« Reply #87, on February 4th, 2014, 11:38 PM »
[Commit revision ad3449b]
Author: Nao (Signed-off)
Date: Tue, 04 Feb 2014 23:35:49 +0100
Stats: 3 files changed; +27 (insertions), -32 (deletions)

  • we_pinterest: this new version now works on Aeva Media pages. (We-Pinterest-Main.php, plugin-info.xml)
  • Notes: I removed the template code because everything the plugin does can be done from the source file (for now). I moved the hook to load_theme so that it gets loaded on all pages, including galleries. Finally, I rewrote the JavaScript to account for linked images. This should cover everything, but in AeMe pages you'll notice that while you can pin a preview, you can't pin a full image. That's because they're generated dynamically, and I don't want to make this plugin more complicated than it should be.
Re: Plugin revs
« Reply #88, on February 5th, 2014, 01:47 PM »
[Commit revision 6e21be0]
Author: Pandos (Signed-off)
Date: Tue, 04 Feb 2014 18:21:54 +0100
Stats: 1 file changed; +27 (insertions), -0 (deletion)

  • Missing strings in the Birthday plugin.  (Birthday-Admin.english.php)

[Commit revision 5203f98]
Author: Pandos (Signed-off)
Date: Tue, 04 Feb 2014 18:26:11 +0100
Stats: 3 files changed; +180 (insertions), -0 (deletion)

  • German translation for calendar plugin

[Commit revision 388ee6c]
Author: Pandos (Signed-off)
Date: Tue, 04 Feb 2014 18:42:14 +0100
Stats: 1 file changed; +27 (insertions), -0 (deletion)

  • German translation for plugin contact page

[Commit revision 8ec350c]
Author: Pandos (Signed-off)
Date: Tue, 04 Feb 2014 18:54:14 +0100
Stats: 1 file changed; +13 (insertions), -0 (deletion)

  • German translation for plugin edit_history

[Commit revision 77e6fa2]
Author: Pandos (Signed-off)
Date: Tue, 04 Feb 2014 19:11:12 +0100
Stats: 1 file changed; +6 (insertions), -0 (deletion)

  • German translation for plugin mass_attach.

[Commit revision a804007]
Author: Pandos (Signed-off)
Date: Tue, 04 Feb 2014 19:20:44 +0100
Stats: 1 file changed; +22 (insertions), -0 (deletion)

  • German translation for plugin mentions

[Commit revision a9d13a2]
Author: Pandos (Signed-off)
Date: Tue, 04 Feb 2014 19:45:25 +0100
Stats: 1 file changed; +4 (insertions), -0 (deletion)

  • German translation for plugin skin_selector.

[Commit revision 414f0f9]
Author: Pandos (Signed-off)
Date: Tue, 04 Feb 2014 19:50:24 +0100
Stats: 2 files changed; +30 (insertions), -0 (deletion)

  • German translation for plugin users_online_today.
Re: Plugin revs
« Reply #89, on February 5th, 2014, 06:32 PM »
[Commit revision 5a06763]
Author: Nao (Signed-off)
Date: Wed, 05 Feb 2014 14:33:38 +0100
Stats: 15 files changed; +2269 (insertions), -0 (deletion)

  • Importing Facebook Connect plugin from Dragooon's repo. Without history, because I'm not going to mingle with that... (facebook/*)
  • Wrapping license text, adding Wedge license.
  • Fixing spacing, indentations, UTF8, line endings.
  • Started work on converting to the latest Wedge version. Fixed URL to FB dev platform.

[Commit revision b27838a]
Author: Nao (Signed-off)
Date: Wed, 05 Feb 2014 18:31:17 +0100
Stats: 7 files changed; +50 (insertions), -58 (deletions)

  • facebook: Renamed ID to Wedge:Facebook, for simplicity (and an official flavor.)
  • facebook: Use we_json_encode, in case we have json_decode support but not json_encode... So, what? It can happen. In an alternate timeline or something. (base_facebook.php)
  • facebook: fixed for latest Wedge; replaced $scripturl with SCRIPT; $context['user'] with we::$user. (plugin.php)
  • facebook: fixed $me['id'] being used here and there. I'm thinking it was the session variable that was really wanted. (plugin.php)
  • facebook: moved the login button below the login box, but within it, not outside of it. Also HTML5-ized. (plugin.php, plugin.template.php)
  • Removed unneeded globals. (we_pinterest/We-Pinterest-Main.php, facebook/plugin.php)