Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - emanuele
46
The Pub / Re: git problems for non-gits.
« on December 17th, 2013, 11:05 PM »- I didn't have to play with rebase at any point. Does that mean I'm free from it, or not? Is rebasing needed only when committing from another branch...?
You may have to use rebase if you commit to your local repo at master, and the pull it because git may bet confused by the new commit that is the merge of the pull request.
Or it may not, because when you pull you just pull the merge commit (because in fact the other commit is just the same as the one you did).
Basically, if I consider my local repo to be the 'official' one, then I guess the workflow is completely different, and I'll have to learn it (again).
* repo upstream => commit 1 (let's say)
* I do a commit in my local and push => repo emanuele commit 2
* in the meantime you do a commit on your local repo => origin commit 3
* I send a PR and you merge it from github => repo upstream commit => 4
Now, you'd have to synch your local repo and the remote one (upstream) but: if you push you get a fast-forward (or whatever it is) error because you have new commits locally and new commits in the remote, so you have first to "pull"[1] the remote repo and then push it again.
It's not so different in fact (and probably for your work-flow it could make more sense), the only difference is what is considered the "master" repository: doing the pull request way is the one that belongs to he organization (like for Elk and SMF, in this case you never commit to the org repo, but always to your local one and then synch), in the other you consider your local repo the original one and you could even ignore PR at github and instead fetch the other repos and do the merges directly on your local copy (sorry, I'm one of the few that apparently loves git workflow and can't stop thinking about all the alternatives to do the same thing LOL).
Why the hell does the 'Signed-off' mention only show up in the extended log (i.e. I have to click the '...'), meaning that if I want to check for sign-off status, I have to click Commits, then for each commit open the ..., and pray that it's there..? Why can't github 'simply' add a 'signed-off' *icon* next to the commit entry, so I can immediately tell if it's okay..?
Probably because sign-off is not *so* popular...I think, but dunno.
| 1. | pull is equivalent to fetch + merge, so "grab the remote history and merge it into your local branch" |
47
The Pub / Re: More constant names to consider.
« on December 15th, 2013, 10:56 AM »
I would avoid duplication (e.g. if you already have the id in we::$id, it's useless to have it in a constant too). Also, yes the user id is going to change at certain points during the execution, so I would really avoid to make a constant out of it simply because it is not constant.
48
The Pub / Re: More constant names to consider.
« on December 14th, 2013, 02:30 PM »
Member is usually more "friendly" I think, user more a kind of relation like provider/client.
But for example in the Italian translation are both mixed up because member doesn't really fit in certain situations (and also because every time I read "member" in Italian without a context I can't stop thinking about its second meaning... lol).
But for example in the Italian translation are both mixed up because member doesn't really fit in certain situations (and also because every time I read "member" in Italian without a context I can't stop thinking about its second meaning... lol).
49
The Pub / Re: Need opinions on a variable name...
« on December 14th, 2013, 11:58 AM »
I'd say assets if you are going to have there css and javascript too, otherwise it would sound strange to me.
It seems you changed the poll "just" before I finished to write the two lines above (in fact I had this page open since yesterday and got the warning about new replies while posting lol).
Well, I think it's still pretty much valid: images are part of the assets I think, so...
Regarding access to the code, at the moment I'm already dealing with 3 to 4 codebases (Elk, SMF (even though I'm just following funny comments these days), WCRPG and Xanje yes, I consider that two things (that have different and sort of diverging codebases) a kind of fork too lol), so add another one would make my head explode in fancy ways LOL
Also, jumping in an almost completely different coding style from zero would be quite tricky for me and I wouldn't be able to grasp much of it in the short term, so I wouldn't be of much help anyway.
And considering we are trying to finalise the beast there is already quite a bit of things to do (I think you know as well. ;)), I even had to forget about learning a bit of Java... :(
It seems you changed the poll "just" before I finished to write the two lines above (in fact I had this page open since yesterday and got the warning about new replies while posting lol).
Well, I think it's still pretty much valid: images are part of the assets I think, so...
Regarding access to the code, at the moment I'm already dealing with 3 to 4 codebases (Elk, SMF (even though I'm just following funny comments these days), WCRPG and Xanje yes, I consider that two things (that have different and sort of diverging codebases) a kind of fork too lol), so add another one would make my head explode in fancy ways LOL
Also, jumping in an almost completely different coding style from zero would be quite tricky for me and I wouldn't be able to grasp much of it in the short term, so I wouldn't be of much help anyway.
And considering we are trying to finalise the beast there is already quite a bit of things to do (I think you know as well. ;)), I even had to forget about learning a bit of Java... :(
50
The Pub / Re: More constant names to consider.
« on December 14th, 2013, 11:52 AM »
Do you already have some constants?
If so I'd say follow the same naming scheme, if you don't and you are deciding it now... mmm... it mostly depends on your preferences I think.
I don't like underscores much ..well, that's not true, my mind changes every two lines of code I write LOL
Anyway, as long as the name is not confusing, I'd say be consistent with what you pick and live with it. ;D
If so I'd say follow the same naming scheme, if you don't and you are deciding it now... mmm... it mostly depends on your preferences I think.
I don't like underscores much ..well, that's not true, my mind changes every two lines of code I write LOL
Anyway, as long as the name is not confusing, I'd say be consistent with what you pick and live with it. ;D
51
Archived fixes / Re: FF messing things up?
« on December 9th, 2013, 12:22 PM »
I'm always worried by generic things, they always end up breaking something else. :-S
53
Archived fixes / Re: FF messing things up?
« on December 6th, 2013, 01:54 PM »* emanuele is innocent! :P
54
Archived fixes / Re: FF messing things up?
« on December 2nd, 2013, 11:15 AM »
Is that feature the one that breaks again the layout? :P
Same details as above. ;)
Same details as above. ;)
56
Off-topic / Re: A short script to remove unused, useless globals in PHP.
« on November 23rd, 2013, 02:32 PM »
Where can you see the email at github?
Sign-off?
If so, you have to change the config of your local git (global config or local config depending on what you want to obtain).
And the old commits do not change unless you rewrite the history resigning all of them (once I found a trick to do that, but last time I tried to find it again I wasn't able to... :().
Sign-off?
If so, you have to change the config of your local git (global config or local config depending on what you want to obtain).
And the old commits do not change unless you rewrite the history resigning all of them (once I found a trick to do that, but last time I tried to find it again I wasn't able to... :().
57
Off-topic / Re: A short script to remove unused, useless globals in PHP.
« on November 19th, 2013, 12:01 AM »
You can use gist too if you want: not a "real" repo, just a sort of pastebin, but with everything a repo has in terms of versioning and forking (I'm not sure you can clone gists).
https://gist.github.com/
https://gist.github.com/
58
Archived fixes / Re: FF messing things up?
« on November 18th, 2013, 11:59 PM »
Chrome seems to work fine here (I used it to have the confirmation it was not a "major" problem), 31.something... OMG 31? O_O
That's a quite crazy numbering. LOL
That's a quite crazy numbering. LOL
59
Archived fixes / Re: FF messing things up?
« on November 18th, 2013, 11:04 PM »
Ohhh...right... O:-)
Gomen. :youretheboss:
FF 25 OpenSuse... TBH I don't even know what's the current FF version, I may be several behind... :-S
Gomen. :youretheboss:
FF 25 OpenSuse... TBH I don't even know what's the current FF version, I may be several behind... :-S
60
Other software / Re : SMF reaction to 'unused, useless globals'
« on November 18th, 2013, 11:02 PM »Well, it's too bad that Wedge and Elk aren't directly interoperable; I mean, I can't exactly cherry-pick a commit from Elk, etc. Or even from SMF. As such, I really very rarely check out either changelog, and will usually miss any bugfixes.
I stopped a while ago cherry-picking things back to SMF because it was just a plain re-write.
BTW, I don't know if you read my Wedge changelogs, I suppose you do, but in case you don't, sometimes I'll document bugs that are also in Elk and SMF; or just in SMF, in which case it doesn't concern you. Just search new rev pages for 'smf', and it should narrow them down.