Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - emanuele
106
The Pub / Re: The Cookie Law (in the UK at least)
« on June 14th, 2012, 01:51 PM »
* emanuele 's knowledge of English is far from perfect and legal matters make his head hurt...

BTW, regarding the part about privacy, if I'm not too wrong the email addresses are usually considered a personal information. In that respect SMF (don't know Wedge) should show something to guests when they are allowed to post I think...

* emanuele takes a note
107
Bug reports / Re: SMF bug 4905 (signature length verified before preparsecode)
« on May 18th, 2012, 02:46 PM »
Quote from Arantor on May 18th, 2012, 12:52 AM
Now what is it we always tell newbies? :P :lol:

(Remember that search can also work on a single topic ;))
But I want to read, is the funny part... :D

P.S.
10!
108
Other software / Re: Has SMF Gotten Slower?
« on May 18th, 2012, 12:48 AM »
*cough cough* random avatar *cough cough*

* emanuele whistles innocently
109
Bug reports / Re: SMF bug 4905 (signature length verified before preparsecode)
« on May 18th, 2012, 12:36 AM »
Quote from Nao on May 17th, 2012, 01:02 PM
No problem. I told you to look at our changelogs :P
It's in my todo list, but I'm still at page 75 because I read soooo slowly... :(
110
Bug reports / Re: SMF bug 4905 (signature length verified before preparsecode)
« on May 17th, 2012, 12:57 PM »
:hmm:
* emanuele did miss it...
* emanuele goes to lunch :angel: and later he will look at the code.
Thanks! :D
111
Bug reports / Re: SMF bug 4905 (signature length verified before preparsecode)
« on March 14th, 2012, 01:02 AM »
ohh...that would make sense...

Code: [Select]
}

preparsecode($value);
// Too long?
if (!allowedTo('admin_forum') && !empty($sig_limits[1]) && $smcFunc['strlen'](str_replace('<br />', "\n", $value)) > $sig_limits[1])
{
$_POST['signature'] = trim(htmlspecialchars(str_replace('<br />', "\n", $value), ENT_QUOTES));
$txt['profile_error_signature_max_length'] = sprintf($txt['profile_error_signature_max_length'], $sig_limits[1]);
return 'signature_max_length';
}
return true;
}
Not even necessary to shorten it (javascript will take care of this aspect :P).

Missing a check for the admin somewhere.
112
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 3rd, 2012, 05:13 PM »
Quote from godboko71 on March 2nd, 2012, 10:56 PM
Sorry to take this a bit off topic... Why would anyone have so many options in a forum poll?
I have no idea, but I'm pretty sure that if you allow something there will be someone that will do it. :P
113
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 05:52 PM »
Quote from Nao on March 2nd, 2012, 04:41 PM
Don't forget to follow our changelogs, we often report SMF bugs there too. (When we're merciful, we specify 'SMF bug' so that SMF devs can easily find them in the logs :P)
One of my best skills is datamining. :P
Quote from Nao on March 2nd, 2012, 04:41 PM
I'm definitely curious to know where the SMF dev team currently stands with regards to Wedge, though :)
Don't know: I'm not the SMF dev team, just a member of the team. ;)

Personally I'm plain curios (as always I am) to see the final result! :D

And if the question is another: well, I'm too young (in SMF years) to know the full story and I don't like to rely on others' reports and opinions in this kind of matters. ;) So let's say I feel neutral.
114
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 03:19 PM »
Quote from Nao on March 2nd, 2012, 03:10 PM
emanuele, aren't you one of the current SMF developers? ;)
That's why I'm lurking everywhere I see "SMF bug" (mantis, the bug reports board, here) :P
115
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 02:06 PM »
For the 255 options I simply added a $poll/post_errors even though is not 100% reliable because this count is based on the number of options ($optionCount), but since the id_poll is not based on that count (because in case an option is deleted the id is not decreased) it could still throw errors...I think I'll see if there is another option.
116
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 01:44 PM »
The (real) problem is in the logic of the javascript: the script counts how many items are there and it continues the numbering from there, so if you let's add 5 options you have ids from 0 to 4, then you edit the poll and remove two options in the middle (2 and 3 let's say)  and save the ids on the next page load will be 0, 3, 4, but when you add a new option with the javascript it add the new input with id equal to 3, that way you have 2 input box with id 3 and of course the second will be the one used by php.