Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Topics - [Unknown]
1
Off-topic / Unknown's thoughts on Wedge
« on June 26th, 2011, 10:11 AM »
Quote from Arantor on June 26th, 2011, 12:43 AM
FWIW, Notepad++ offers 1, 2, some of 3 (there's a popup display for the selection of tabs, much like Alt-Tab does but no jump-to-specific-tab-by-number), 4, 5 if you want, not sure about 6, 7 - well, it doesn't fail on 60MB SQL dumps but it doesn't like it much, 9, 11 and 12.
Quote from Nao/Gilles on June 26th, 2011, 07:52 AM
It has 8 too (clone view in tab context menu).
Hmm, it has 4 and 8?  I probably need to look at it again.  Sounds like it has improved.
Quote from Arantor on June 26th, 2011, 12:43 AM
It's not the uber-IDE but I've found it to be a very nice and capable tool, I certainly haven't found it wanting - except possibly for lack of an SVN plugin that doesn't require the SVN command line tools.
So using svn the way it was intended to be used (that is, via command line) is another beneficial feature it has, you say?  Sounds even better.

Heh, the GUIs bug me mainly because they make their own (different) choices than the developers of Subversion itself.  Example: TortoiseSVN iirc commits externals by default, whereas svn commit doesn't.  The correct way is what svn commit does, and I basically have to not use externals at work because everyone else uses the wrong and breaks them if I do (because they use TortoiseSVN.)

Meanwhile svn has excellent help, clean cli UI, and beats msysgit out of the part on Windows.  What more could I ask for?
Quote from Nao/Gilles on June 25th, 2011, 10:39 PM
And what do you think of our work from what you've seen so far? :unsure:
Well, I'm a nitpicker.  I could list a bunch of problems I have with SMF 2.0 in general, and with this, and even with the changes.  Not to mention just as many with code that is more or less certainly still code I wrote.  I also see it (and probably SMF 2 as well) as even more bloated than before, which I know you probably don't see as a bad thing...

Likely, I'm sure some people thought "my secret project" was bloated, what with its child boards and templates for each section (rather than just one global), etc.  So I'm certain I'm biased.

Anyway, staying away from the details, looking at the code (whether the new Wedge stuff or old) just makes me want to clean it up.  I don't know if you know, but I had a policy of re-reviewing files, periodically (on top of reviewing all incoming commits) which I did by marking files every X weeks and going through them line by line and making sure the code still jived together.

Are you guys doing code review at all yet?

Also, having managed sites that actually had multiple and seasonal themes, and enjoyed it and themes like the Comic theme, the direction I see those going saddens me.  Having written large scale modifications (which if I did it over again, I'd just make it take .diff files directly, in addition to a reasonable set of hooks, but then, the realities of PHP 4 got in the way of many things), and supported people who had very customized versions of SMF and YaBB SE, the direction that's going also greatly saddens me.

FWIW, if you wonder why I like the package manager, just so you know - the reason I joined the YaBB SE dev team was to improve the package manager and put it into Trinity (YaBB SE 2.0.)  Otherwise I would've never joined.  I like the concept of diff updates and being able to keep records of your changes (not that I don't like and desire plugins additionally, e.g. TOX-G is designed specifically with plugins in mind.)

And there I speak about SMF and Wedge, although in different ways.  I realize the "mods are only minor things" and "all themes are just colors changes of the default one" concepts come from somewhere.  Seems like a... not catch 22, whatever it's called when you assume a problem doesn't exist, because you don't have it, but really you don't have it for other reasons.  Seems like one of those whatever-they're-calleds to me, but that's just my opinion.

By the way, I suggest completely replacing setup_fatal_error_context() type operations with exceptions, since if you're requiring PHP 5, this will make integration much easier.  This was one of the big problems with SMF back in the day because of the PHP 4 requirement.  It's why lines like these exist:

Code: [Select]
trigger_error('Hacking attempt...', E_USER_ERROR);

Because I was working so hard to stop people from neutering their own forum's security measures.

Ah... just memory lane, mostly, for me.  Doesn't look different enough, just has stuff like PayPal all over it, which certainly makes the calendar look as much like a core feature as the "Reply" button.

-[Unknown]
2
Features / Optimize release images
« on June 20th, 2011, 03:35 AM »
Running optipng on most images can really improve things.  At a cursory glance, it appears that many pngs, avatars, etc. can all be optimized with some amount of savings.

I suggest adding it to a release script, so it's never forgotten, something like this:

find Themes avatars media -name "*.png" -print0 | xargs -0 --no-run-if-empty other/tools/optipng -o4

Or even better, run it more often (e.g. when checking in png changes) and then it only has to process the changed files, which is much quicker.

For example, the avatars directory could currently save 40 KB if it were losslessly compressed (about 12%.)  This affects both distribution bandwidth and obviously admin's bandwidth.  Losslessly optimizing jpegs is a good idea too.

-[Unknown]