Wedge

Public area => Bug reports => The Pub => Test board => Topic started by: Nao on March 29th, 2012, 06:49 PM

Title: Test topic...
Post by: Nao on March 29th, 2012, 06:49 PM
(click to show/hide)
Hmm.

Even though it is definitely set to 'quoted=optional' in the database..]]>Test..
Title: Test topic.
Post by: Nao on March 29th, 2012, 06:50 PM
Hey... It actually works?!

(click to show/hide)
Hmm.

Okay, it's when you don't add quotes that it fails... Which makes sense, somehow...

:edit:
Title: Re: Test topic.
Post by: Nao on March 31st, 2012, 05:16 PM
Quote from Nao on March 29th, 2012, 06:50 PM
Hey... It actually works?!

lmlkmlmlkmlkmlkmlkmlkmlkmlkmlkmlkmlkmlkmlkmlmklkmlkmlkmlkm4545645645654645654564645546456456456546456lkm

Okay, it's when you don't add quotes that it fails... Which makes sense, somehow.
Test.

lmlkmlmlkmlkmlkmlkmlkmlkmlkmlkmlkmlkmlkmlkmlmklkmlkmlkmlkm4545645645654645654564645546456456456546456lkm

Posted: March 31st, 2012, 05:15 PM

Seems to work for me...?
Title: Re: Test topic.
Post by: Nao on April 6th, 2012, 10:09 AM
Test. Test.(http://wedge.org)
http://wedge.org
Title: Re: Test topic.
Post by: Nao on April 6th, 2012, 10:10 AM
Okay, here's the deal... I can't get the url problem to reproduce here. Is this a special board that is entirely bug-free? :P

Try to edit my post, Pete!

Test. Test.(http://wedge.org)
http://wedge.org
Title: Re: Test topic.
Post by: Nao on April 6th, 2012, 10:11 AM
Hey... Interesting. Now I can reproduce.

Test. Test.(http://wedge.org)
http://wedge.org

The problem doesn't happen when I quick edit an existing post to add a straight URL. If I save, then quick edit again, the link is url-tag free.

Editing this post again... It never happens! Surprising. So there's something happening generally, that doesn't happen when quick editing to add the link.
Title: Re: Test topic.
Post by: Arantor on April 6th, 2012, 01:06 PM
Quick editing goes through a different code path to main posting, as I commented when this first occurred.

Need to compare the path of Post2.php to JSModify.php and see where the difference is, I'll look at that shortly.
Title: Re: Test topic.
Post by: agent47 on April 10th, 2012, 06:56 AM
Something that you should really know about me is that...........
(click to show/hide)
me like big boobies :p
Title: Re: Test topic.
Post by: Nao on April 10th, 2012, 10:45 AM
(click to show/hide)

Bug!

The multi-word spoiler tag actually works on first post, but breaks on quick edit...!
Title: Re: Test topic.
Post by: Nao on April 10th, 2012, 10:46 AM
(click to show/hide)
As evidenced here...

BTW, full posting doesn't add the closer spoiler tag, while quick edit does.
Title: Re: Test topic.
Post by: Nao on April 10th, 2012, 11:11 AM
Kay then...
First post is using entities (quot) in the database. Second post isn't.
That's the reason for the bug... YET another issue with preparsing, this time the other way around (i.e. quick edit adds the bug.)
Title: Re: Test topic.
Post by: Arantor on April 10th, 2012, 12:00 PM
Yay for entirely separate code paths -_-
Title: Re: Test topic.
Post by: Nao on April 10th, 2012, 12:01 PM
I, for one, would love to know why this is happening at all.
And another reason for me to advocate using double quotes in the DB, rather than quot entities... :whistle:
Title: Re: Test topic.
Post by: Arantor on April 10th, 2012, 12:08 PM
Because quick edit does something totally separate to Post2.php, it never actually calls either Post file at all, it's all in JSModify.php - and preparsecode is called at a different time, and notably, the Aeva on-posting code is never called at all (which is why the other stuff re the url bbcode doesn't happen in quick editing)


Even more than ', it bothers me about having " tags, and I'm not sure you wouldn't have to alter how the bbc parser works then since some parameters can be quoted.
Title: Re: Test topic.
Post by: Nao on April 10th, 2012, 12:34 PM
IIRC, Aeva's onposting wasn't called because of incompatibilities with the JS handling or something... But that's probably something that could be fixed.

Also, the question is to know whether or not this is a Wedge or SMF bug... (the quote stuff.)

SELECT * FROM wedge_messages WHERE body LIKE '%"%'

Showing rows 0 - 29 ( 3,987 total, Query took 0.0035 sec)

Yeah... Funny eh? Apparently double quotes have been happily living in our database forever without any worries...
Title: Re: Test topic.
Post by: Arantor on April 10th, 2012, 01:45 PM
Well, historically everything was done using htmlspecialchars with ENT_QUOTES so if it's not doing that now, there's a reason - and very likely that reason is code we've changed rather than code that's buggy in SMF.

Also note that the DB here isn't a true SMF database but one from Noisen's code which did have a lot of changes, and possibly including some that affected htmlspecialchars.

I'm fine with switching to ENT_NOQUOTES for such, provided that we can be certain there's no XSS injection risk. (There shouldn't be an SQL injection risk because of the query layer doing its own quoting.) It will certainly space some space (including the extra byte per row that I wanted to spend making it mediumtext ;))
Title: Re: Test topic.
Post by: Arantor on April 18th, 2012, 07:36 PM
http://example.com/

http://example.com/

example.com(http://example.com/)

http://www.youtube.com/watch?v=OBGOQ7SsJrw

Conan the Barbarian: The Musical (Arnold Schwarzenegger)(http://www.youtube.com/watch?v=OBGOQ7SsJrw#ws)

Conan The Barbarian: The Musical(http://www.youtube.com/watch?v=OBGOQ7SsJrw#ws)
Title: Re : Re: Test topic.
Post by: Arantor on April 18th, 2012, 07:38 PM
http://www.youtube.com/watch?v=OBGOQ7SsJrw
Title: Re: Test topic.
Post by: YogiBear on April 24th, 2012, 10:55 PM
This post is just an excuse to show appreciation of all the work that's gone on here - and so I can say I've now posted on Wedge. :)
Title: Re: Test topic.
Post by: Nao on April 24th, 2012, 11:03 PM
You already did on march 31 ;)

(http://wedge.org/s/a/avatar_1_1335289199.jpg)

(http://wedge.org/s/a/avatar_1_1335289199.jpg)
Title: Re: Test topic.
Post by: YogiBear on April 25th, 2012, 12:57 AM
 :blush: ::)
Title: Re: Test topic.
Post by: Nao on May 26th, 2012, 10:04 AM
Quote from Nao on April 24th, 2012, 11:03 PM
You already did on march 31 ;)
Testing.

Details


Code: [Select]
[media id=1]

[media id=1]
Title: Re: Test topic.
Post by: Nao on May 26th, 2012, 10:04 AM
Edit test...
Quote from Nao on May 26th, 2012, 10:04 AM
Quote from Nao on April 24th, 2012, 11:03 PM
You already did on march 31 ;)
Testing.
Nested quotes.
Quote from Nao on May 26th, 2012, 10:04 AM
Quote from Nao on April 24th, 2012, 11:03 PM
You already did on march 31 ;)
Testing.
Nested quotes.
Quote from Nao on May 26th, 2012, 10:04 AM
Quote from Nao on April 24th, 2012, 11:03 PM
You already did on march 31 ;)
Testing.
Quote from Nao on May 26th, 2012, 10:04 AM
Quote from Nao on April 24th, 2012, 11:03 PM
You already did on march 31 ;)
Testing.
Nested quotes.
Title: Re: Test topic.
Post by: Nao on February 11th, 2013, 11:09 PM
Test.
Title: Re: Test topic.
Post by: Nao on February 11th, 2013, 11:10 PM
Test.

Details
Title: Re: Test topic.
Post by: Maxx on February 28th, 2013, 01:01 AM
Just a test of the code function of the BBC:

replace your submit button, intended  for Firefox only!

Code: [Select]
.button_submit, .button_reset
{
    background: -moz-linear-gradient(center top , #686868 0px, #232323 100%) no-repeat scroll 0 0 transparent;
    border: 1px solid #9B9D9B;
    border-radius: 2px 2px 2px 2px;
    color: #D3E5FA;
    cursor: pointer;
    font-weight: normal;
    margin: 0 auto;
    padding: 0 17px;
    text-decoration: none;
    cursor: pointer;
    font-weight: normal;
}

looks like the attached below;
Title: Re: Test topic.
Post by: Nao on April 11th, 2013, 11:54 PM
Test. @Nao
Title: Re: Test topic.
Post by: Nao on February 5th, 2014, 11:27 PM
[Commit revision 12cf1e3]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 05 Feb 2014 23:14:33 +0100
Stats: 1 file changed(https://github.com/Nao/test/commit/12cf1e3a9a15d3d64d1de25d808b34062668092c); +2 (insertions), -0 (deletion)
Title: Re: Test topic...
Post by: Nao on April 9th, 2014, 11:06 AM
Test.

http://wedge.org/pub/feats/6803/new-revs-public-comments/255/ (90% after adding some strategic htaccess rules)
[url]http://www.simplemachines.org/community/index.php?topic=519351.0[/url] (68%) [url=http://www.wedge.org][url=http://www.wedge.org]www.wedge.org[/url][/url]
[url]http://www.elkarte.net/community/index.php?topic=1001.0[/url] (54%)

And another bug fixed... :eheh:
Title: Re: Test topic...
Post by: CerealGuy on January 28th, 2015, 09:59 PM
$1 $2
Code: [Select]
$1 $2