Wedge
Public area => The Pub => Plugins => Topic started by: live627 on January 9th, 2013, 02:44 AM
-
Because people will want it.
Here comes the ingenuity: No additional hooks are needed. I use the menu hook to modify profile and recent; their context is available to modify.
-
As I said in my thoughts, I'm jealous of this. The UI is so elegant (I'm assuming you didn't try to fix up feeds? Don't know about search.)
Not sure how I would have done it had I attempted it, I think I'd have skipped trying to show the nice UI and simply pretended the board didn't exist (user group can see, but cannot enter) and done it by having the plugin fudge query_enter_board and query_see_topic if necessary afterwards.
I did consider adding it as a core feature for those who feel they need it, but I think it's better as a plugin, and if it's like this, it's a great job :)
-
Well, thank you! I'm actually blushing right now.
Anyway, this UX isn't anything new. It is derived from my old SMF mod http://livemods.net/index.php?action=media;sa=item;in=75
I forgot about search and the feeds. I'm going to modify query_enter/see_board for SSI, feeds will get a similar treatment, and search will still index passworded boards, but only hide them from the end results with the above UX.
-
You did a good job, be proud of it! :)
The only downside I can think of doing it that way is that other plugins won't necessarily behave. If it's enforced by munging query_ magic, other plugins can't help but behave.
It's sort of why I've been thinking it might have to be considered as core unless we stay resolute and firm against the people who think it's a good idea!
-
The only downside I can think of doing it that way is that other plugins won't necessarily behave. If it's enforced by munging query_ magic, other plugins can't help but behave.
Eh, if they don't, they have a security issue. They have the inbuilt topic privacy settings to contend with.
-
Sure, that's a given, but what I'm thinking is a plugin that is not aware of password boards will potentially not respect it... I don't know how it works but the screenshots seem to suggest query_enter_board otherwise grants access, so a plugin that does as it should and uses QEB is going to be able to access things even without the password.