Post by: live627 on October 9th, 2012, 10:40 AM
 |
 |
Post by: Arantor on October 9th, 2012, 03:16 PM
Post by: Nao on October 9th, 2012, 05:42 PM
Maybe it should be made core, BTW...? Or at least an official plugin...
Can you share it for now? :P
Post by: Arantor on October 9th, 2012, 05:50 PM
The reason for suggesting it that way is performance saving ;)
Post by: Nao on October 9th, 2012, 06:09 PM
I had this mod installed on one of my earlier SMF1 sites, no longer there though, but I liked it...
Post by: Arantor on October 9th, 2012, 06:11 PM
Also, I noticed a bug which I'll report in a minute.
Post by: live627 on October 10th, 2012, 12:50 AM
Hey, nice... It's actually one of the many features I had on my (core) to-do list. I guess I can give it up now... :)
Maybe it should be made core, BTW...? Or at least an official plugin...
Can you share it for now? :P
And done.. Someone wants it on their site :P
Post by: Arantor on October 10th, 2012, 02:02 AM
There's about 6 plugins active on this site right now... :o
Post by: spoogs on October 10th, 2012, 02:08 AM
Post by: live627 on October 10th, 2012, 02:09 AM
Nao lurves his plugins.
Quite a change in spirit. First wanting to shy away, then wanting to install some, then... wanting to build some?
Post by: Arantor on October 10th, 2012, 02:19 AM
But building is less a skill and more an art in doing the dance the right way, especially if you're used to just adding code wherever you feel like.
| 1. | I'm not going to claim that I made *best* use of hooks, I think Dime probably has that title. But I certainly made noise about making use of them whenever possible. |
Post by: Nao on October 11th, 2012, 05:02 PM
I hate mods because they make your life a nightmare when it comes to upgrading the main program.
I love plugins because they never modify external code.
I don't know how to write a plugin, though. And I wouldn't want to look into it for now -- it's not time for me. I have other priorities...
But I love the fact that some of the features I'm always postponing end up in nicely made plugins. That's pretty great.
Anyway... Active Members enabled on Wedge.org :) Thanks, John!
Oh, and also thanks for reminding me (through your code) that I hadn't (yet) fixed the $_GET['title']/$_POST['t'] bug in the Like popup. Done now. (Locally.)
Posted: October 11th, 2012, 04:48 PM
Also, a quick fix for the 'more' link giving out negative numbers... (Due to activemembers_num being higher than the current number of posters.)
<?php
$num_active_members = count($active_members);
if (!empty($settings['activemembers_num']) && $num_active_members > $settings['activemembers_num'])
$context['active_members'][] = '<a href="#" onclick="reqWin(weUrl(\'action=activemembers;t=' . $topic. '\'), 500); return false;">' . $txt['more'] . '</a> (' . ($num_active_members - $settings['activemembers_num']) . ')';Post by: Arantor on October 11th, 2012, 05:55 PM
Writing them isn't hard, once you get into the mindset. The mindset simply is: I can run my own code at *these* places, if I were inserting my own code there to do a job, what would I write? The rest is pure packaging.
Post by: agent47 on October 11th, 2012, 07:02 PM
Post by: live627 on October 14th, 2012, 12:11 AM
But I love the fact that some of the features I'm always postponing end up in nicely made plugins. That's pretty great.
Post by: Nao on October 14th, 2012, 12:17 AM
Yeah my to-do list isn't public, but I posted some of it a few months ago... ;)
Maybe I should clean it up and post the entirety of it. Plenty of ideas for people to exploit!
Post by: live627 on October 14th, 2012, 12:24 AM
Also, I clicked the (more) link here and nothing happened. Firebug did not show a data-eve on it. Or onclick. Or whatever.
Posted: October 14th, 2012, 12:23 AM
http://wedge.org/pub/plugins/6998/plugins-i-refuse-to-do/
Post by: Nao on October 14th, 2012, 07:27 AM
Wait, ideas can be exploited now? :lol:
Also, I clicked the (more) link here and nothing happened. Firebug did not show a data-eve on it. Or onclick. Or whatever.
Post by: live627 on October 14th, 2012, 09:01 AM
Post by: Nao on October 15th, 2012, 03:32 PM
I already sent a link in my last post. I am talking, of course, of the more link when in excess of 10 active members are found...
Clicked link.
Opened a popup for me...
Using Firefox 17 (Aurora).
Post by: agent47 on October 15th, 2012, 04:08 PM
And also just out of curiosity I know it displays member names in the order of the number posts made on that topic but how does it choose between two members who've made the equal number of posts on that topic? 'cause I noticed that the member "Antes" was literally the second poster on that thread and yet his name has been pushed into the "more" list. Is it based on a member's overall post count because it can't be alphabetical either as I see the member "Zootalaws" who's made one post himself among the ten displayed members.
Edit: no wait it can't be based on a member's overall post count either. Confused... Random order?
Post by: Arantor on October 15th, 2012, 04:13 PM
Post by: Nao on October 15th, 2012, 04:16 PM
So it's probably down to a wrong permission out there.
:edit: Ninja'd...
Post by: Arantor on October 15th, 2012, 04:17 PM
Post by: Nao on October 15th, 2012, 04:18 PM
I didn't notice in the first place.
Maybe the plugin area should indicate whether a plugin is associated with permissions, and give a link to them...? Maybe..?
Post by: Arantor on October 15th, 2012, 04:29 PM
Firstly, use the correct type for <text name="activemembers_num" /> - it should be an int (which also allows setting min, max, step, size), it's a number, not a text string.
Secondly, adding the permission to the settings page. <permissions name="view_active_members_own" /> and <permissions name="view_active_members_any" /> though you'll need to make strings for them too. (And the <newperms> block still has to be left present too.)
The reason for that is because so many people got confused that they have to set permissions in somewhere other than the plugin's own area. So instead, put the permissions in the plugin's settings page.
Post by: Nao on October 15th, 2012, 04:48 PM
Posted: October 15th, 2012, 04:46 PM
Hmpf... I've enabled the permission for guests and members alike. It still doesn't seem to work...
Have no time to work on this further for now, though.
Oh, and while I'm at it... I guess the #1 thing to do with the plugin is to ensure the word 'more' isn't linkable when the user doesn't have permission to view that popup... Would have saved me some debugging time ;)
Post by: Arantor on October 15th, 2012, 04:56 PM
Does it work with per-board perms..?
Hmpf... I've enabled the permission for guests and members alike. It still doesn't seem to work...
It needs to be one or the other.
Post by: Nao on October 15th, 2012, 08:18 PM
if (allowedTo('view_active_members_any') || ($topicinfo['id_member'] == $user_info['id'] && allowedTo('view_active_members_own')))Posted: October 15th, 2012, 08:17 PM
Hmm, not working... :-/
Post by: Arantor on October 15th, 2012, 08:18 PM
Post by: Nao on October 15th, 2012, 08:37 PM
But I just realized that it's not the permissions that are a problem at this point, it's the fact that it can't find the 'main' block, which rings no bell to me... I mean, it's the exact same code as in Help.php..?!
Posted: October 15th, 2012, 08:25 PM
(Nope... It's definitely the permissions that trigger the error.)
Posted: October 15th, 2012, 08:27 PM
1/ it's id_member_started, not just id_member...
2/ action=activemembers doesn't have 'topic' but 't' as its topic ID, so no $topicinfo for it... :-/
Posted: October 15th, 2012, 08:30 PM
(Fixed.)
Post by: live627 on October 16th, 2012, 01:11 AM
And also just out of curiosity I know it displays member names in the order of the number posts made on that topic but how does it choose between two members who've made the equal number of posts on that topic?
Post by: live627 on October 16th, 2012, 01:32 AM
Secondly, adding the permission to the settings page. <permissions name="view_active_members_own" /> and <permissions name="view_active_members_any" /> though you'll need to make strings for them too. (And the <newperms> block still has to be left present too.)
Post by: Arantor on October 16th, 2012, 02:16 AM
Does it really need to be an own/any permission, though?
Post by: Pandos on November 6th, 2012, 10:07 AM
One thing that is filling my error log:
#/Plugins/active_members_fixed/img/tick.png): failed to open stream: No such file or directory
Post by: live627 on November 6th, 2012, 10:37 AM
Post by: Arantor on November 6th, 2012, 01:12 PM