Wedge
Public area => The Pub => Plugins => Topic started by: live627 on June 21st, 2012, 02:41 AM
-
Currently, only the known variables can be extended through a hook. It should follow, then, that the actual filtering should also be plugin-friendly.
Now, the problem is how exactly to extend these best. Currently, each action is handled in a big switch syntax. I see two ways to do this. We could run with this (using the "default" case) or divide each action into separate functions.
Thoughts?
-
It isn't handled in a big switch case.
There's two parts to extending moderation filters.
Firstly, there's defining more types of rules, for example you could use that to declare a rule based on the number of likes a person has (since that's not currently in the system), you'd call moderation_rules to actually set up the actual processing of that rule. (You'd declare both its definition and if inside the admin panel, also go on to load the templates and language strings for it) - this is where the big switch comes in, but it's already extensible.
Secondly, there's the actual process of applying rules. This is currently not extensible in any fashion, but what would you want to do with a post in a moderation context, that isn't preventing/moderation/pin/unpin/lock/unlock, exactly?
If you did, for some random reason, want to set something up, add a new hook call in just before // Any mistakes? in Post2.php.
-
Random question: would it be useful to extend Topic Solved with this to prove it all works?
-
/solved = solve this topic? It would be a good way to test the mod filters and I like that idea.
-
Well, that's the beauty of it, you can configure it in all sorts of fun ways - /solved is the canonical example but not required to be that.
-
I never did get around to this one. I need to investigate this particular case since it's an entire class of action not currently possible.
-
Okay, I don't know where to post about this, and given that my network issues took away most of my mana for the day, I'm not going to bother fighting too hard against my internal compass... :P
About the moderation filters.
- How exactly can I trigger that popup...? I really need to see what I'm trying to translate, because it has a strange ring to it... (?)
- Create a new filter, with Chrome for instance. First dropdown choice. Then first DD choice. Then choose 'Depends on post subject'. Click inside the text input and type anything. My problem comes from the fact that it only shows the Add button once you focus out of the box. It should be triggered when you start typing something, or even right after you select the filter type (e.g. 'Depends on post subject'.)
- Also, the 'Informing the user' part shows up after you select the second dropdown. It should either show up before the condition list, or be shown only when the 'Save this rule' button appears.
- Finally, there's still at least one bug in the Condition list... Select 'applies to one of more boards', then click a board name checkbox, then click a radio button above it. The button doesn't appear. That's because it only appears when you click the radio button first, and then any checkbox, not the other way around... That's a minor bug, but it's still a bug. It may apply to other situations in the condition list, but I don't have time to test them all, sorry, it's more of a job for our BETA TESTERs.......... :niark:
-
* Triggering the popup is easy. Create a rule that has moderate or prevent as its action, and you'll get an extra option at the bottom to put in a message for the different languages. Put something in there. This is so when a rule triggers, the admin can explain to users what they did wrong. The popup is just a convenience in the admin area to show the admin what all the different languages are. (I can add screenshots of the whole process if that would help)
My problem comes from the fact that it only shows the Add button once you focus out of the box.
Also, the 'Informing the user' part shows up after you select the second dropdown. It should either show up before the condition list, or be shown only when the 'Save this rule' button appears.
As I see it, none of this is a bug. It's working exactly as I designed it to. Whether that means the design is wrong is a matter of debate, but if it changed, a lot more stuff has to be written to explain to the user what they're doing wrong. This way, they can't actually add a rule without conditions to it, they have to come up with a valid condition for a rule to add it to the rule and there must be a valid condition attached to be able to add the rule.And, by the way, what prevents us from renaming the Help template to 'Popup' and 'help_text' to 'popup_text'? I actually did this internally last night, before my network problems started... Because I'm feeling that the help popup is just one of many.
-
* Triggering the popup is easy. Create a rule that has moderate or prevent as its action, and you'll get an extra option at the bottom to put in a message for the different languages. Put something in there. This is so when a rule triggers, the admin can explain to users what they did wrong. The popup is just a convenience in the admin area to show the admin what all the different languages are. (I can add screenshots of the whole process if that would help)
I was expecting a '?' icon or something..?It was written that way, by me, deliberately back in February and it has *always* been that way since day 1. It's simply to not allow the user to actually add anything until there's something valid to add.
As I see it, none of this is a bug.
It's working exactly as I designed it to. Whether that means the design is wrong is a matter of debate, but if it changed, a lot more stuff has to be written to explain to the user what they're doing wrong.
It's still primarily used for the help text as far as I know (though the new say/ask might use it, haven't checked), and the only other uses are this popup and the who-liked-this popup, both of which are somewhat misappropriation of the help template by keeping the display logic inside the action itself rather than delegating it to some kind of template.
-
I'm still not seeing the popup stuff, even after doing all of that.
I was expecting a '?' icon or something..?
But it should update after a first character was entered, rather than going out of the input area.
It doesn't need a rewrite, just a couple of tweaks...
The only problem with altering it in that fashion is that there's no user messages or anything, nor any logic to show any, in the event of the user trying to add something stupid. Thus it triggers onchange and only if there's something valid does it show anything. But it wasn't done out of laziness, it was to cause the user to stop a moment and check they'd put in what they meant to put in before they hit the add or save buttons respectively.I'm just thinking that it's more logical to have a generic popup template like we do have a generic menu template, and then use that for the Help popups as well...
-
Ah, got it, never actually SAVED a filter after building it... That's why I couldn't find the popup ;)
It may be triggered on change, but on my side it never triggers when typing text, only on focusout... Odd. Can you look into it?
How to reproduce what I really consider to be a bug:
- Create new filter
- Choose first in dropdown
- Choose first radio button
- Choose first in dropdown
- Click a checkbox (i.e. a board name), nothing happens, which is as intended I guess,
- Click a radio button (i.e. "applies to the selected"...), nothing happens, which is NOT as intended.
GenericPopup done :) It's not as slick as the Help stuff, but at least it's no longer a hack eheh...
-
It may be triggered on change, but on my side it never triggers when typing text, only on focusout... Odd. Can you look into it?
Click a radio button (i.e. "applies to the selected"...), nothing happens, which is NOT as intended.
There is no circumstance where a user should be legitimately creating a rule that happens on every post everywhere without *some* kind of qualification on it, even if it's only 'where user is not an admin'.
-
Yes it is. Until you actually select a board, the rule's not valid. It applies to the selected, but you haven't selected any, so this is a rule that is applicable to nothing, and thus useless.
-
And did you select both a board and one of the radio buttons?
I couldn't reproduce it misbehaving.
-
Yes, I did... The 'trick' is to select the board(s) BEFORE you select the radio buttons. Clicking the radio buttons won't then trigger the button, and I have to re-check the boards for this to happen.
An easy fix would be to have a default radio button checked to begin with. Or fix the JavaScript ;)
This is with Chrome 26.x.
-
I thought the code checked that? Been ages since I looked at it.
-
That's what I've been telling you for ages just the same :lol:
It doesn't work as intended, thus I thought you'd be eager to fix it. Or at least have a look at the code ;)
(I'd fix it myself, but I've never really looked into that particular page's source code and would rather give you dibbs.) ('Giving dibbs', does that work in English?)
-
But it's always worked for me, I've never been able to make it not work, though I'll test it again in a bit.
-
Keep me posted.
-
Don't know if this is intended behavior and if this has been said before (I searched, didn't find anything), however, when you add a rule that moderates the post when someone uses the f-word, the post will be moderated even when it is posted by an administrator. Yes, it does what it should do, but it doesn't really make sense when you can approve it anyway.
So my question is: is this intended behavior?
-
Yes, this is absolutely intended behaviour. It may not be entirely logical to you, but it's doing *exactly* what you've told it - moderate the post because it contains a given word. If you don't want that behaviour to apply to admins, make an exclusion for them - moderate the post... if it contains a given word AND user is not in group Administrators.
Consider the other practical case - it would help discourage moderators from using profanities.
-
Thanks for the explanation. ^_^ I was just wondering, that's why I asked. :)