Wedge

Public area => The Pub => Off-topic => Topic started by: Dragooon on June 3rd, 2012, 07:40 PM

Title: What the...
Post by: Dragooon on June 3rd, 2012, 07:40 PM
Code: (Search2.php, line 584 and 638) [Select]
$word = $word;

What am I missing?
Title: Re: What the...
Post by: Arantor on June 3rd, 2012, 07:47 PM
I have no idea but it's been there since Wedge r1 (back when it was still Search.php not the two separate files) which means it's been there since SMF 2.0 RC3 and likely earlier.
Title: Re: What the...
Post by: Nao on June 12th, 2012, 08:51 AM
Removing these...
It's been like this since at least RC1.
In fact, in SMF 1.1, it was this instead:

Code: [Select]
$word = stripslashes($word);

I guess it was a temp fix... And never got properly cleaned up.
Title: Re: What the...
Post by: ziycon on June 12th, 2012, 10:23 AM
I've seem this more than enough times with development work, a developer will leave a line like this if they're unable to get a certain function working on the value being assigned so they remove the code that's not working and just end up leaving the variable assigned to itself so they know where to come back to but a lot of the time is forgotten about.

I've seen it in numerous mainstream software across multiple languages. The fun bit is trying to figure out what it was meant to do. :)
Title: Re: What the...
Post by: Nao on June 12th, 2012, 10:50 AM
Some features are there for a reason. As we say in France... "Comments are not made for dogs" :P
Title: Re: What the...
Post by: Norodo on June 12th, 2012, 01:32 PM
Quote from Nao on June 12th, 2012, 10:50 AM
As we say in France... "Comments are not made for dogs" :P
That's the strangest french thing I've heard of in at least a week.
Title: Re: What the...
Post by: ziycon on June 12th, 2012, 01:35 PM
Quote from Nao on June 12th, 2012, 10:50 AM
As we say in France... "Comments are not made for dogs" :P
Quite an odd one I have to say...  :hmm:
Title: Re: What the...
Post by: Nao on June 12th, 2012, 02:44 PM
When you'd catch someone not washing their hands after dirtying them, you could for instance say "Eh, les lavabos c'est pas fait pour les chiens !", qui basically means that these things were built for use by humans, not dogs, and one should therefore use them... :^^;:

I was actually looking for a direct English translation earlier and couldn't find it, so it's definitely a French peculiarity I guess...

Just like people looked at me strangely when I told them "J'te dirai quoi" (direct translation: "I'll tell you what", actual meaning: "I'll tell you (later) (the outcome of what we just discussed)"), and found out, years later when watching a movie, that it was actually something only the French from the North would say.
Title: Re: What the...
Post by: ziycon on June 12th, 2012, 02:52 PM
I get you, sure there are many Irish sayings that people outside of Ireland just don't get. :)
Title: Re: What the...
Post by: MultiformeIngegno on June 13th, 2012, 01:47 AM
I think there are in any language! :D