Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: emanuele on January 19th, 2015, 11:27 PM

Title: install.php, no more. :P
Post by: emanuele on January 19th, 2015, 11:27 PM

Code: [Select]

Click here to delete this install.php file now.

Should probably be something along the lines:

Code: [Select]

Click here to delete the install directory now.

Title: Re: install.php, no more. :P
Post by: Nao on January 23rd, 2015, 10:20 AM

Actually, that's exactly what the installer does... It deletes the install.php and install.sql files, and only those.
I didn't test whether I could 'simply' try to unlink the install folder itself, but it didn't matter much... Especially since the install process is now streamlined in a way that makes sure (1) install.php is never called independently ("hacking attempt"), (2) it's never called again after something is installed.

I did find a bug in the test for obgz though, it links to install.php instead of index.php so it'll probably fail all attempts... I could link to install/install.php instead and add the obgz test before the hacking attempt test, but I don't think it's worth it... I'll commit an updated version, hopefully it'll work.

As for the rest, I don't know if it's worth changing...

Title: Re: install.php, no more. :P
Post by: emanuele on January 23rd, 2015, 02:51 PM

Ohh... not verified enough, sorry... :-[

Title: Re: install.php, no more. :P
Post by: Nao on January 23rd, 2015, 05:13 PM

Now I'm just wondering what Pandos committed the other day... :^^;:

Title: Re: install.php, no more. :P
Post by: Pandos on January 25th, 2015, 07:36 PM

No need to worry :D
Will change a single word tomorrow. :)