Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Jurien on January 6th, 2015, 10:01 AM

Title: Top header
Post by: Jurien on January 6th, 2015, 10:01 AM

A very tiny small issue in the top section (square instead of well rounded corners)
  core/skins/index.css (https://github.com/Wedge/wedge/commit/f11a6c251f1d2956ae5a0a6c52c214839e08af07)

Title: Re: Top header
Post by: Nao on January 6th, 2015, 11:52 AM

Honestly, not seeing any problems on my local copy... I've committed minor existing changes to Wilde, to sync the git repo with my own install, but I don't think it'll have any influence on it... (?)

Title: Re: Top header
Post by: Jurien on January 6th, 2015, 01:30 PM

The problem only exist on the Wilde skin.
There must be something wrong in skins/index.css

Code: [Select]

#top_section
padding: 8px 30px
border-bottom: 1px solid $separator_col
background: $main_bg

Title: Re: Top header
Post by: CerealGuy on January 6th, 2015, 06:40 PM

border-bottom: none
background: none

fixed it for my custom skin...

Title: Re: Top header
Post by: Nao on January 7th, 2015, 01:33 AM

Seriously guys, are you seeing this bug here on wedge.org..? Working fine for me... Using Firefox...

Title: Re: Top header
Post by: Johnny54 on January 7th, 2015, 10:16 AM

Win 8.1 - With IE11, chrome and Firefox everything looks the way it should be. (rounded corners)

Title: Re: Top header
Post by: Nao on January 7th, 2015, 12:55 PM

Quote from CerealGuy on January 6th, 2015, 06:40 PM

border-bottom: none
background: none

fixed it for my custom skin...

That's not the way to do it... Look inside Wilde/extra.css:

Code: [Select]

@remove #top_section
background: *
border-bottom: *

There you go -- you cancel that out, AND it removes the original declarations, meaning it loads a millisecond faster.

Frenich, are you sure you updated your Wilde files...??

Title: Re: Top header
Post by: Nao on January 7th, 2015, 06:15 PM

I'll cancel my commit later. I didn't test enough and I think it's wrong to force skinners to account for more changes to Weaving. I'll wrap my changes in @local tests.

Title: Re: Top header
Post by: Jurien on January 7th, 2015, 09:20 PM

Quote from Nao on January 7th, 2015, 12:55 PM

Frenich, are you sure you updated your Wilde files...??

Yes for sure....the new updated revs however did solved my issue so no problems anymore thanks :cool:

Title: Re: Top header
Post by: Nao on January 7th, 2015, 10:11 PM

Oh, really... ^^

Anyway, I figured I should be using @if local keywords more in Weaving, if only to show how powerful it is, but mostly because Weaving should be as bare as possible for inheritance purposes, and since I'm physically unable to allow myself to publish a 'bare' skin, local keywords are the... key, I suppose.