Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: CerealGuy on January 6th, 2015, 02:17 AM

Title: updateSettingsFile in install.php
Post by: CerealGuy on January 6th, 2015, 02:17 AM

In refer to http://wedge.org/pub/support/8744/install-problem/msg296767/#new

Pull Request: https://github.com/Wedge/wedge/pull/25

EDIT: umm having some troubles here, not sure if this really fixes it. Perhaps test it again, getting some errors here in the moment, but not sure if its because of this.

Title: Re: updateSettingsFile in install.php
Post by: Nao on January 6th, 2015, 11:55 AM

While your solution is certainly more elegant than what I ultimately chose to do (and I really, really wanted to just do that include!), ultimately this is the installer we're talking about, the entry point into Wedge, and I just don't have the time to commit to testing whether using the 'default' version will work in the installer. There has to be a reason why SMF (or whatever old version of Wedge) didn't just do include('Subs-Admin.php') to load the updateSettingsFile function and instead chose to re-declare it, so I'm not going to bother for now...

Feel free to test your own patch thoroughly, i.e. go through the painful steps of installation several times, and convince me to use it... The less code, the better. :^^;:

Title: Re: updateSettingsFile in install.php
Post by: Drunken Clam on January 6th, 2015, 02:15 PM

I'm actually installing another 3 or 4 forums tonight, I'll let you know how it goes! :cool:

Title: Re: updateSettingsFile in install.php
Post by: Nao on February 20th, 2015, 11:44 AM

I'm guessing this is solved by then..?
I'll mark it as solved.

Also, I'll be doing a test install on the wedge.org server today, so I can see what's up with the installer. And test the media gallery properly...