Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: CerealGuy on October 16th, 2014, 10:43 AM

Title: PrintPage parsebbc doesnt know postid
Post by: CerealGuy on October 16th, 2014, 10:43 AM

In PrintPage parsebbc gets no info about the processed post id.
$context['posts'] = array();
while ($row = wesql::fetch_assoc($request))
{
// Censor the subject and message.
censorText($row['subject']);
censorText($row['body']);

$context['posts'][] = array(
'subject' => $row['subject'],
'member' => $row['poster_name'],
'on_time' => on_timeformat($row['poster_time'], false),
'timestamp' => $row['poster_time'],
'body' => parse_bbc($row['body'], 'post', array('print' => true)),
);

if (!isset($context['topic_subject']))
$context['topic_subject'] = $row['subject'];
}
Add id_msg to selected fields in query and 'body' => parse_bbc($row['body'], 'post', array('print' => true, 'cache' => $row['id_msg'])),

Title: Re: PrintPage parsebbc doesnt know postid
Post by: Nao on October 18th, 2014, 08:18 PM

It's a free call, so I'm adding it.
Why don't you simply do pull requests..? That way, implementing would be faster, as long as it follows my guidelines, which it does in this case of course... :^^;:

Title: Re: PrintPage parsebbc doesnt know postid
Post by: CerealGuy on October 19th, 2014, 01:05 PM

Thanks for implementing, but you missed adding 'id_msg' to selected fields.
Created a Pull Request for this, but i dont know how to only select one commit, therefore theres another fix in it.
But important too.
https://github.com/Wedge/wedge/pull/22

Title: Re: PrintPage parsebbc doesnt know postid
Post by: Nao on October 22nd, 2014, 01:16 AM

Should be fixed now...