Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: BurkeKnight on October 10th, 2014, 07:08 PM

Title: Skin Selector in Main Menu
Post by: BurkeKnight on October 10th, 2014, 07:08 PM
Skin Selector in Main Menu under Profile.
If skin selection is turned off, this still shows.

I see why, there is nothing about the setting in the show part in the code: Subs.php

Code: [Select]
'skin' => array(
'title' => $txt['change_skin'],
'href' => 'http://wedge.org/do/skin/',
'show' => allowedTo(array('profile_extra_any', 'profile_extra_own')),
),
'',

Seems it should be something like:


Code: [Select]
'skin' => array(
'title' => $txt['change_skin'],
'href' => 'http://wedge.org/do/skin/',
'show' => allowedTo(array('profile_extra_any', 'profile_extra_own') && empty($settings['theme_allow'])),
),
'',

However, that leaves the line below it still showing.


Also, I wonder, is there any real reason to keep this in the menu?
If skin selection is enabled, then there's the drop down selector in sidebar.
Title: Re: Skin Selector in Main Menu
Post by: Nao on October 11th, 2014, 03:18 PM
But it's a plugin..?
Title: Re: Skin Selector in Main Menu
Post by: BurkeKnight on October 11th, 2014, 04:59 PM
Nope. No plugin.
Default install.
Title: Re: Skin Selector in Main Menu
Post by: CerealGuy on October 11th, 2014, 09:06 PM
By default you dont have a skin selector in the sidebar.
Title: Re: Skin Selector in Main Menu
Post by: BurkeKnight on October 11th, 2014, 10:39 PM
Thought you did...LOL
Shows how often I leave set to let members change theme....LOL