Wedge
Public area => Bug reports => The Pub => Archived fixes => Topic started by: CerealGuy on May 30th, 2014, 11:52 PM
-
Found some bugs with allow_guestAccess set to false.
They all appear when the user is a guest.
#1
Guests can not switch the skin, because 'skin' is not an allowed action (index.php).
Fix:
Change
elseif (empty($settings['allow_guestAccess']) && we::$is_guest && (empty($action) || !in_array($action, array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'verification'))))
to
elseif (empty($settings['allow_guestAccess']) && we::$is_guest && (empty($action) || !in_array($action, array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'verification', 'skin'))))
#2 Guest sees a searchbox, but he needs to be registered to search, therefore an ugly frame appears. I think the best is to just disable the searchbox for guests when allow_guestAccess is false.
#3 Same for the quick access sidebar element.
https://github.com/C3realGuy/wedge/commit/49b250e9c18c54a6a6e3a05aed33383b0cf37f10
-
#2 The admin needs to take away the 'Search for posts and topics' permission for Guests. Likewise if Guest has permission to look at the Media Gallery or the Member List then these appear on the menus but do nothing.
-
This is still unsolved.
@Farjo allow_guestAccess = False has the effect that guests only can login. Nothing else. So changing the permissions is only a workaround.
-
@CerealGuy Not sure I've mentioned allow_guestAccess, but it was 9 months ago. I was pointing out a workaround in lieu of a permanent fix, and pointing out a couple of other bugs of the same nature.
-
@Farjo do you have any links are any more details on those bugs?
-
@CerealGuy no I don't.
-
Got fixed too:
https://github.com/Wedge/wedge/commit/3e4d49b8bf7499c58f204261146dd56c8b2db0cb
-
But there's a code box overflow bug... Shoot ;)
(First post in this topic.)
-
Not for me, but those overflows happen often in firefox. In Chrome i never had one (except for the mobile version).
-
But there's a code box overflow bug... Shoot ;)
(First post in this topic.)
Setting on .postheader does the magic for me.