Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: CerealGuy on May 30th, 2014, 11:52 PM

Title: Some bugs with allow_guestAccess
Post by: CerealGuy on May 30th, 2014, 11:52 PM
Found some bugs with allow_guestAccess set to false.
They all appear when the user is a guest.

#1
Guests can not switch the skin, because 'skin' is not an allowed action (index.php).
Fix:
Change
Code: [Select]
elseif (empty($settings['allow_guestAccess']) && we::$is_guest && (empty($action) || !in_array($action, array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'verification'))))

to
Code: [Select]
elseif (empty($settings['allow_guestAccess']) && we::$is_guest && (empty($action) || !in_array($action, array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'verification', 'skin'))))

#2 Guest sees a searchbox, but he needs to be registered to search, therefore an ugly frame appears. I think the best is to just disable the searchbox for guests when allow_guestAccess is false.

#3 Same for the quick access sidebar element.

https://github.com/C3realGuy/wedge/commit/49b250e9c18c54a6a6e3a05aed33383b0cf37f10
Title: Re: Some bugs with allow_guestAccess
Post by: Farjo on June 7th, 2014, 04:51 PM
#2 The admin needs to take away the 'Search for posts and topics' permission for Guests. Likewise if Guest has permission to look at the Media Gallery or the Member List then these appear on the menus but do nothing.
Title: Re: Some bugs with allow_guestAccess
Post by: CerealGuy on March 19th, 2015, 07:36 AM
This is still unsolved.
@Farjo allow_guestAccess = False has the effect that guests only can login. Nothing else. So changing the permissions is only a workaround.
Title: Re: Some bugs with allow_guestAccess
Post by: Farjo on March 22nd, 2015, 03:48 PM
@CerealGuy Not sure I've mentioned allow_guestAccess, but it was 9 months ago. I was pointing out a workaround in lieu of a permanent fix, and pointing out a couple of other bugs of the same nature.
Title: Re: Some bugs with allow_guestAccess
Post by: CerealGuy on March 23rd, 2015, 07:31 PM
@Farjo do you have any links are any more details on those bugs?
Title: Re: Some bugs with allow_guestAccess
Post by: Farjo on March 23rd, 2015, 11:50 PM
@CerealGuy no I don't.
Title: Re: Some bugs with allow_guestAccess
Post by: CerealGuy on January 9th, 2016, 04:42 PM
Got fixed too:
https://github.com/Wedge/wedge/commit/3e4d49b8bf7499c58f204261146dd56c8b2db0cb
Title: Re: Some bugs with allow_guestAccess
Post by: Nao on February 1st, 2016, 12:03 PM
But there's a code box overflow bug... Shoot ;)
(First post in this topic.)
Title: Re: Some bugs with allow_guestAccess
Post by: CerealGuy on February 5th, 2016, 12:27 AM
Not for me, but those overflows happen often in firefox. In Chrome i never had one (except for the mobile version).
Title: Re: Some bugs with allow_guestAccess
Post by: CerealGuy on February 8th, 2016, 12:11 AM
Quote from Nao on February 1st, 2016, 12:03 PM
But there's a code box overflow bug... Shoot ;)
(First post in this topic.)
Setting
Code: [Select]
width: 75%;
on .postheader does the magic for me.