Wedge
Public area => Bug reports => The Pub => Archived fixes => Topic started by: txcas on February 20th, 2014, 04:20 PM
-
I clicked on the HTML5 link that is at the bottom of each page and got this:
(http://www.carloss.us/pictures/html5.jpg)
Not sure if this is a problem at all, but I am posting it just in case.
-
What page did you get this on..?
-
On the home page http://wedge.org.
-
I got this too from an install this evening. I've now applied the two changed files and get this:
 |
Validation |
The full sentence is "Element br not allowed as child of element ul in this context. (Suppressing further errors from this subtree.)"
-
First error is due to my saving a useless allowedTo() query just for a field validation. Basically, guests will get incorrect HTML if no thoughts have been entered so far, and only guests, and it doesn't even break the layout at all.
Dunno if it's worth adding the test...
Second one... What's the HTML around it? Because I don't see that in my code...
Oh BTW, the other errors are fixed. (See New Revs topic.)
-
<section>
<header class="title">
<div class="feed_icon">Latest Posts Feed</div>
</header>
<dl id="feed">
<dt>All:</dt>
<dd><a href="?action=feed">posts</a> / <a href="/index.php?action=feed;sa=news">topics</a></dd>
</dl>
</section>
</div></aside>
</div>
</div></div>
<div id="footer"><div class="frame">
<ul class="reset">
<li class="copyright">Powered by <a href="//wedge.org/" target="_blank" class="new_win">Wedge</a></li><br class="clear">
<li class="links">
<a id="site_credits" href="/index.php?action=credits">Website credits</a> |
<a id="button_html5" href="//validator.w3.org/check?uri=referer" target="_blank" class="new_win" title="Valid HTML5!">HTML5</a>
</li>
</ul>
</div></div>
</div>
<script>
Will have a bash with the new code. I would have noticed!
-
Having applied the new files there is only the one message remaining :)
-
Yup, and even that is fixed locally, but I'm not committing for now because I suspect I'll rewrite the whole thing before soon. Wanna get rid of those list tags, because I think it's a waste of bandwidth to add classes to each of them, when it's unlikely anyone will ever touch them, at least intentionally. I don't know.
-
How about you committing and me putting the item in the post-alpha section of the list, so you don't forget?
-
No! :P
Seriously, it's just a quick commit (move the <br> line right before the </li> tag before it), I'm simply trying to do it more elegantly.
-
Thanks, understood :cool:
-
From the home page, this is given:
No character encoding information was found within the document, either in an HTML meta element or an XML declaration. It is often recommended to declare the character encoding in the document itself, especially if there is a chance that the document will be read from or saved to disk, CD, etc.
...but not from a topic page. The sources show that the topic page has (meta charset="utf-8") whereas index does not.
Is this something to be 'fixed' or is it irrelevant?
-
As this topic is in 'Archived' I need to add an @Nao :)
-
*lol*
Just a view minutes ago I added a comitt to this on GH :)
-<head>', empty($topic) ? '' : '
+<head> https://github.com/Pandos/wedge/commit/5351e1fc59ad8badb2f176da2ea50e338efb0d31
-
You no longer need to mention me, I've readded this boars to my list anyway.
As for this, it's normal.
Setting utf in the header saves a few bytes. I'm setting it in the head tag for topics because they're more likely to get saved to your hard drive. And in this case, you need it to be in the HTML.
I think I mentioned this last year or so...
-
I probably didn't understand it then either ;) But it's now marked as Solved :cool: