Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: txcas on February 8th, 2014, 06:12 AM

Title: Changes to settings won't stick under Member Options->Default Options
Post by: txcas on February 8th, 2014, 06:12 AM

I can't change any settings.  For example I want to change the popup settings to Yes, but as soon as I click Save everything reverts back to Keeps Members' own choices.  I checked a few profiles and the notifications settings for personal messages did not change after clicking Save.
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Farjo on March 3rd, 2014, 05:13 PM
I can get it to switch members' options to Yes, but not to No.
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Nao on March 3rd, 2014, 05:25 PM
Ah, yes (or no), I forgot to deal with this one...

Gimme a sec though, more like an hour, I'm taking a break... Posted a long message(http://www.theadminzone.com/forums/showpost.php?p=739995&postcount=17) somewhere and lost too much time. :P
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Farjo on March 3rd, 2014, 09:56 PM
Maybe you know this already, but none of the wedge_themes options can be updated from the member's profile. All the options show what is the setting for guests/new members.

So txcas if you change the default option to Yes (and ignore the 'existing members' drop-down) then everyone's option for that item will be 'Yes'.
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Nao on March 3rd, 2014, 10:42 PM
Can you reformulate..?

I *did* make several changes to member options, BTW, when I dropped theme support.
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Nao on March 3rd, 2014, 10:55 PM
Oh... Interesting. Indeed, the profile page doesn't allow me to change my settings. I'll look into it.
Surprising that no one reported this in a whole month... :^^;:
Posted: March 3rd, 2014, 10:47 PM

Problem is due to variable being updated, THEN being erased entirely from the database immediately after that, ah ah...

I need to remember the difference between id_theme=1 and id_theme!=1 in the theme settings table... -_- It'll come back to me.
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Nao on March 3rd, 2014, 11:00 PM
'kay, got it...
What was being erased, was the specific per-theme settings of a member apart from the default theme, once a default setting was changed.
It doesn't make a lot of sense. I've always hated theme-specific options, at least the way they're implemented in SMF, I mean... I really, really need to reappropriate that.
Anyway, fixed! (Profile pages.)
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Farjo on March 4th, 2014, 12:15 AM
Yes I think that has fixed everything. It now works, albeit in a different way, as SMF does. Which is thus:


If a member has not yet set any options then he will get the default option i.e. what is set "For guests/new members". The "For existing members" dropdown will not change these members' options.

If a member has saved any setting on his Look & Layout, Notifications or Personal Messaging screens then that screen's options are now saved in the database and will be changed by the "For existing members" dropdown but not "For guests/new members". However the other screens' options will be changed as in the paragraph above.


Therefore if txcas (or anyone else) wants all their members' pop-up option to be Yes then he should change the default "For guests/new members" to Yes and select the 'Set to *Yes* for everyone' option for "For existing members".


I doubt if this is clear so perhaps best if you ask questions, which I will answer tomorrow :)
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Nao on March 10th, 2014, 03:39 PM
Quote from Farjo on March 4th, 2014, 12:15 AM
Yes I think that has fixed everything. It now works, albeit in a different way, as SMF does. Which is thus:
What is SMF's way? This way, or something else?
Quote from Farjo on March 4th, 2014, 12:15 AM
If a member has not yet set any options then he will get the default option i.e. what is set "For guests/new members". The "For existing members" dropdown will not change these members' options.

If a member has saved any setting on his Look & Layout, Notifications or Personal Messaging screens then that screen's options are now saved in the database and will be changed by the "For existing members" dropdown but not "For guests/new members".
And it makes sense. If you change a setting in your profile page, there's no way to know if you didn't change the other settings because you agreed with them (therefore, you want them to stay that way), or you didn't bother (therefore, they should remain 'default'.)
The only fix for that would be to replace checkboxes with select boxes that say "Default (Yes)" (or "Default (No)"), "Yes", and "No". To me, it's... Less usable, I'd say.
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: Farjo on March 10th, 2014, 05:16 PM
Quote from Nao on March 10th, 2014, 03:39 PM
Quote from Farjo on March 4th, 2014, 12:15 AM
Yes I think that has fixed everything. It now works, albeit in a different way, as SMF does. Which is thus:
What is SMF's way? This way, or something else?
The admin screen is different, but the results are the same.
Quote from Nao on March 10th, 2014, 03:39 PM
Quote from Farjo on March 4th, 2014, 12:15 AM
If a member has not yet set any options then he will get the default option i.e. what is set "For guests/new members". The "For existing members" dropdown will not change these members' options.

If a member has saved any setting on his Look & Layout, Notifications or Personal Messaging screens then that screen's options are now saved in the database and will be changed by the "For existing members" dropdown but not "For guests/new members".
And it makes sense. If you change a setting in your profile page, there's no way to know if you didn't change the other settings because you agreed with them (therefore, you want them to stay that way), or you didn't bother (therefore, they should remain 'default'.)
The only fix for that would be to replace checkboxes with select boxes that say "Default (Yes)" (or "Default (No)"), "Yes", and "No". To me, it's... Less usable, I'd say.
It doesn't need 'fixing' but an explanation will be useful when someone else asks the same question.

Oi @txcas is this good??
Title: Re: Changes to settings won't stick under Member Options->Default Options
Post by: txcas on March 10th, 2014, 08:10 PM
All good, closing.