Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Arantor on August 23rd, 2013, 09:17 PM

Title: Language search fouls up with plugins with subfolders
Post by: Arantor on August 23rd, 2013, 09:17 PM
If you try to search in the language editor, plugins whose language files aren't in their top level folder (where plugin-info.xml is) throw errors as well as not being added to the results list.
Title: Re: Language search fouls up with plugins with subfolders
Post by: live627 on August 29th, 2013, 10:56 PM
This should be fixed as of rev 2231.
Title: Re: Language search fouls up with plugins with subfolders
Post by: Nao on August 31st, 2013, 04:46 PM
Are you positive..? I don't remember anyone working on this..?
If yes, please move to Archived fixes. ;)
Title: Re: Language search fouls up with plugins with subfolders
Post by: live627 on September 1st, 2013, 01:18 AM
whoops I hit up the wrong topic :(
Title: Re: Language search fouls up with plugins with subfolders
Post by: Nao on September 2nd, 2013, 03:32 PM
So, what was the right one...?

As for this bug, can you fix it on your side? You know I'm not well acquainted with the plugin codebase yet, so... It'd be helpful, kthx.
Title: Re: Language search fouls up with plugins with subfolders
Post by: live627 on September 3rd, 2013, 02:24 AM
Quote
I'm not well acquainted with the plugin codebase yet
Are you going to learn it, or rely on others to maintain it? I need to know what is expected of me.

Code: [Select]
/Sources/ManageLanguages.php Mon Sep  2 17:15:09 2013
@@ -447,7 +447,7 @@
  foreach ($objects as $name => $object)
  if (is_dir($name))
  {
- $local_path = str_replace($plugin_path, '', $name) . '|';
+ $local_path = str_replace($plugin_path, '', $name) . '/';
  $lang_dirs[$plugin_id][$local_path] = $name;
  }
 
Title: Re: Language search fouls up with plugins with subfolders
Post by: Nao on September 3rd, 2013, 04:50 PM
Okay, applied your fix to the file. (And made it all into one line... No need to use a temp variable for that, is there...?)
Thanks!

I'll learn the system if nobody steps up to maintain it and it turns out that I absolutely need to fix things. Otherwise, frankly, I have too much on my plate right now to start looking into learning things that Pete left hanging. I believe he fixed 99% of what he needed to fix everywhere, so I think I can safely leave these things aside until needed. Right now... Nope.

What I'm expecting of you? I'm expecting nothing of you. If I were expecting something of you, that might influence you to work on things, and then get upset with me for some reason. I only want you to do what you're willing to do for Wedge. So, basically, if you want to take over whatever Pete was working on and that you know better than I do, by all means, please do it. If you're not willing to, then it's just fine as well. I'm certainly not going to put the pressure on anyone; it is up to me, and me alone, to carry the Weight of Wedge until it gets released.
Title: Re: Language search fouls up with plugins with subfolders
Post by: live627 on September 4th, 2013, 10:49 PM

This should be fixed as of rev 2236.