Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: live627 on June 15th, 2013, 08:28 AM

Title: Undefinded function: sendemail()
Post by: live627 on June 15th, 2013, 08:28 AM
Class-Notification.php, line 231.
Title: Re: Undefinded function: sendemail()
Post by: live627 on June 15th, 2013, 08:39 AM
This should explain why I'm not getting my email notification.

@Nao> There may be a related error in your log.
Title: Re: Undefinded function: sendemail()
Post by: Dragooon on June 15th, 2013, 10:59 AM
Oops, should be sendmail. That line only handles e-mails when there's a notification bump, instant e-mail for new notification works, if you've set your notifications on periodical then I fixed that in my previous patch.
Title: Re: Undefinded function: sendemail()
Post by: Nao on June 15th, 2013, 06:17 PM
Lulz... That explains a lot.

And nope, nothing in the error log... Which can only mean one thing: Wedge never even gets to that point, meaning there's another error left...

Dragooon is the champion of super-cool features that are totally, completely, utterly untested... :niark:
Title: Re: Undefinded function: sendemail()
Post by: Dragooon on June 15th, 2013, 06:19 PM
Quote from Nao on June 15th, 2013, 06:17 PM
Lulz... That explains a lot.

And nope, nothing in the error log... Which can only mean one thing: Wedge never even gets to that point, meaning there's another error left...

Dragooon is the champion of super-cool features that are totally, completely, utterly untested... :niark:
It doesn't get to the point because generally nothing takes it to the point. That line handles notification emails for which there already exists a notification, for example if someone liked your post and another person likes the same post and you had an old notification, that old notification will be bumped. Here currently nothing is bumping old notification really so it doesn't email anything. Although AFAIK that line *is* untested so fat chance it might actually be broken :P.
Title: Re: Undefinded function: sendemail()
Post by: Nao on June 15th, 2013, 06:23 PM
It's you who's broken!

(Sorry, a favorite saying of my girl...)
Title: Re: Undefinded function: sendemail()
Post by: live627 on June 15th, 2013, 08:10 PM
Quote
And nope, nothing in the error log... Which can only mean one thing: Wedge never even gets to that point, meaning there's another error left...
Crap.
Quote
It doesn't get to the point because generally nothing takes it to the point. That line handles notification emails for which there already exists a notification, for example if someone liked your post and another person likes the same post and you had an old notification, that old notification will be bumped.
That's right.
Quote
Here currently nothing is bumping old notification really so it doesn't email anything.
Wrong..

It works . I got an email for a second like, and not the first.
Title: Re: Undefinded function: sendemail()
Post by: Arantor on June 16th, 2013, 12:26 AM
Well, I have 39 unread notifications and no emails :(
Title: Re: Undefinded function: sendemail()
Post by: live627 on June 16th, 2013, 12:37 AM
Email option?
Title: Re: Undefinded function: sendemail()
Post by: Arantor on June 16th, 2013, 12:39 AM
Set to periodical.
Title: Re: Undefinded function: sendemail()
Post by: live627 on June 16th, 2013, 12:49 AM
Then no emaill. This is only if you set to instant. Set likes to notify instantly and wait until one of your posts get liked twice or more.
Title: Re: Undefinded function: sendemail()
Post by: Arantor on June 16th, 2013, 12:56 AM
But I don't want instant notifications for everything :P
Title: Re: Undefinded function: sendemail()
Post by: live627 on June 16th, 2013, 01:11 AM
lol

Not even for testing?
Title: Re: Undefinded function: sendemail()
Post by: Arantor on June 16th, 2013, 01:13 AM
I was testing periodical notifications :P
Title: Re: Undefinded function: sendemail()
Post by: live627 on June 16th, 2013, 01:26 AM
All periodical notifications are disabled here :P


   public function handleMultiple(Notification $notification, array &$data, array &$emaiL_data)
   {
      return false;
   }

That means "disable periodical notifications for this notification".
Title: Re: Undefinded function: sendemail()
Post by: Arantor on June 16th, 2013, 01:28 AM
Well, crap.

Wait, handleMultiple isn't for periodical notification, is it? I thought it was for if you had multiple notifications to the same thing (e.g. multiple notifications for likes on the same post)
Title: Re: Undefinded function: sendemail()
Post by: live627 on June 16th, 2013, 02:21 AM
That's part if it, I think.

If handleMultiple returns false then a new notification is not created but the current one's time is updated.

I just reviewed the code again. It is seriously broken, Sorry Dragooon. The bug  found in the OP is only the icing on top of the cake.

Commencing spam.
Title: Re: Undefinded function: sendemail()
Post by: Dragooon on June 16th, 2013, 07:30 AM
handleMultiple doesn't affect periodical, it has nothing to do with it. Let us know of any issues you find.
Title: Re: Undefinded function: sendemail()
Post by: Nao on June 17th, 2013, 06:39 PM
Silly question...
How am I supposed to make e-mail sending work, on my local install..?
Is there a tutorial, somewhere?
Posted: June 17th, 2013, 06:35 PM

Alright, managed to make it work... ;) Using my ISP's.
Title: Re: Undefinded function: sendemail()
Post by: Arantor on June 18th, 2013, 07:20 AM
I don't bother. I just tell it to use the mail queue and check it appears in there as it should ;)
Title: Re: Undefinded function: sendemail()
Post by: Nao on June 18th, 2013, 03:11 PM
On my setup, mail queue was enabled, and set to '0' maximum e-mails... That probably didn't help! Since I don't remember touching this... Maybe it's a bug in the Wedge install process, I don't know..?
Anyway, [yesterday] I disabled the mail queue as a test, and it still didn't work, then I modified the php.ini file and restarted, and then it worked. So, right now, mail queue is disabled for me...
Title: Re: Undefinded function: sendemail()
Post by: Arantor on June 18th, 2013, 06:26 PM
Eh, I use the mail queue for the fact I can see all the details that are supposed to be outgoing (other than headers but that's a trivial thing to check), it works for me.
Title: Re: Undefinded function: sendemail()
Post by: Nao on June 19th, 2013, 06:09 PM
I dunno where I can view the mail queue, but all I know is that the settings I had for it, were: disabled, 0 and 0 (for the two numeric options). Looking at the code, it should have been 5, so... I don't know what's happening, I guess...

Also, did you ever find time to look into the error in the profile area, that I mentioned last week or so..? Because I still haven't uploaded to here IIRC, precisely for that reason, so you could test again, or something...
Title: Re: Undefinded function: sendemail()
Post by: Arantor on June 19th, 2013, 09:30 PM
Admin > type in 'browse queue' into the search, click first result.

What error exactly?