Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: live627 on June 7th, 2013, 01:44 AM

Title: Thoughts colloring error
Post by: live627 on June 7th, 2013, 01:44 AM
See attached
Title: Re: Thoughts colloring error
Post by: Arantor on June 7th, 2013, 02:10 AM
The links missing colours (which are all the other side of the >> from what I can see)... do they also still contain <URL> in them too?
Title: Re: Thoughts colloring error
Post by: live627 on June 7th, 2013, 02:35 AM
No.
Title: Re: Thoughts colloring error
Post by: Arantor on June 7th, 2013, 02:44 AM
That's odd, then, because if the parser is finding and replacing the <URL> there is no reason why it wouldn't also get the action=profile link... are the links prettified?

(See, the weird thing is, I can't reproduce it, it works as expected for me...)
Title: Re: Thoughts colloring error
Post by: live627 on June 7th, 2013, 02:52 AM
Yes, they are prettified.

Oh, wait, maybe you aren't looking in the right place. This is All Thoughts.
Title: Re: Thoughts colloring error
Post by: Arantor on June 7th, 2013, 02:54 AM
Ah yes, that makes sense, I can reproduce and I see exactly why it is so. I will fix this in my next commit.
Title: Re: Thoughts colloring error
Post by: Arantor on June 7th, 2013, 03:54 AM
Should be fixed in r2158. If you'll notice, it's not that the link is not coloured, it is actually pointing to the wrong page entirely. (And because it's the wrong link, it gets the wrong colouring.)

What's happening is that it was pulling the parent thought's owner as the child thought's owner id and building the link off that even though it has the right name to work off (because *that* join is correct)
Title: Re: Thoughts colloring error
Post by: Nao on June 7th, 2013, 04:25 PM
Quote from Arantor on June 7th, 2013, 03:54 AM
Should be fixed in r2158. If you'll notice, it's not that the link is not coloured, it is actually pointing to the wrong page entirely. (And because it's the wrong link, it gets the wrong colouring.)
That's odd, I'm not seeing wrong links..?
Quote from Arantor on June 7th, 2013, 03:54 AM
What's happening is that it was pulling the parent thought's owner as the child thought's owner id and building the link off that even though it has the right name to work off (because *that* join is correct)
Yes, that one's my fault. Last month, as I implemented 'correct' privacy for thoughts, I had to rename h_parent to just 'h' so that I could access query_see_thoughts correctly, or the other way around, or whatever -- and I failed to properly renamed the only occurrence of h_parent in the param list. Silly me..! Anyway, your fix should be all good now.
Title: Re: Thoughts colloring error
Post by: Arantor on June 7th, 2013, 04:28 PM
Yeah, you had to go into All Thoughts to see it. Then look for, say, the ones where xrunner is replying to one of mine. Or even ones where you're replying to me - the @ link in the reply is the wrong link.
Title: Re: Thoughts colloring error
Post by: Nao on June 7th, 2013, 04:44 PM
Ah... Yes, confirmed! Silly-silly-silly-me! :lol:
Title: Re: Thoughts colloring error
Post by: Arantor on June 7th, 2013, 05:08 PM
Yeah, took me a while to realise what was going on too but fortunately not a huge thing to fix :)