Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Arantor on April 15th, 2013, 04:50 PM

Title: Something is screwy with the main menu
Post by: Arantor on April 15th, 2013, 04:50 PM

I don't know why this is but it's seriously messed up right now.

I was clicking on the Home button repeatedly (here, just now) and some page loads it would show I had a PM outstanding, some it would show no PMs outstanding, some it would show a dropdown for the Home menu, some it wouldn't.

Oh. It just occurred to me. SMF bug strikes again.


Why are we caching the menu again? This is why it's messed up - caching at level 2 (which is what we're set to) stores the menu for the groups the user is in with the language. It's entirely possible that you have multiple members with the same groups with different information.

I don't really think we need to cache it...?

Title: Re: Something is screwy with the main menu
Post by: Nao on April 15th, 2013, 05:12 PM

The reason cache level 2 was activated is, I guess, because this morning I tried to flush the non-file cache (mentioned that in the thoughts area), and I figured it might work if I switched to level 2 and then back to level 1... I guess either there's a bug with switching between levels, or I simply forgot to switch back to level 1.

Anyway, if level 2 is broken... It should be fixed, I guess ;)
Switched back to level 1 for now...

Title: Re: Something is screwy with the main menu
Post by: Arantor on April 15th, 2013, 05:21 PM

Quote

Anyway, if level 2 is broken... It should be fixed, I guess

This has been broken for literally years: http://wedge.org/pub/bugs/7173/smf-bug-4763-menu-hook-doesn-t-work-properly-when-caching-level-2/ (filed in 2011)

I just think it should be uncached. Mind you with what I have in mind, that won't be a problem anyway ;)

Title: Re: Something is screwy with the main menu
Post by: Nao on April 15th, 2013, 05:29 PM

Hmm... Didn't even remember a single post of this conversation.... :whistle:

Yes, I think caching the menus isn't going to improve performance enough to justify the problems it creates.
And I'm the one saying that... So, do whatever you feel you have to do, eh ;)

Title: Re: Something is screwy with the main menu
Post by: Arantor on April 15th, 2013, 05:39 PM

Already removed ;)

It only even comes into effect on level 2 and to be honest the load of the menu is really not that big a deal.

Title: Re: Something is screwy with the main menu
Post by: Yoshi2889 on April 15th, 2013, 05:49 PM

Good! :)

I also noticed I didn't get any number beside the menu button. Hope that's fixed with this :)

Title: Re: Something is screwy with the main menu
Post by: spoogs on April 15th, 2013, 06:27 PM

So my mind wasnt playing tricks me, had this happen with the Media button a few times as well.

Title: Re: Something is screwy with the main menu
Post by: Arantor on April 15th, 2013, 08:50 PM

I just realised I only took part of it out (the important bit) though in my last commit, I'll tackle the rest in my next commit.