Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: icari on March 14th, 2013, 02:32 PM

Title: flexbox and opera 12.14
Post by: icari on March 14th, 2013, 02:32 PM
In all themes but warm and wireless there is an issue with the new flexbox layout

(http://imageshack.us/a/img4/232/image005m.png)

looks like in some threads/posts that the signature of the post above will bleed over into the next post. This makes the next post a bit more difficult to read. Most of the time it seems to happen with Arantor's sigature, but I can also see it here http://wedge.org/pub/plugins/7986/the-whole-core-feature-thing/ with Dragooon's signature in the first post into the second.
Title: Re: flexbox and opera 12.14
Post by: Nao on March 14th, 2013, 03:38 PM
That's interesting, I was sure I'd tested in all major browsers...
Can reproduce. Will look into it right now.

:edit: Hmm... Browser bug? The error disappeared once I got page to the page...
Posted: March 14th, 2013, 03:12 PM

Okay, definitely a browser bug... In the post you mention, I have no problem. But Pete's first post in that topic gets the signature bug.
I disabled all CSS except for the flex, and it was still broken... Then I removed the first quote from his post (through Dragonfly), and it got fixed. Then I re-added it, and it was still working...

When something is so inconsistently broken, it's a flawed implementation.
Given how much time I spent on making it work in Firefox and Chrome, and given how Opera is doomed to be extinct in a couple of years (to my great disappointment), I don't see a reason to spend more time working on 'fixing' their own bugs.

So... I could remove Opera from the list of browsers that support flexbox (the can_flex variable), or add Opera-specific hacks to prevent it from using flexbox (i.e. @if can_flex && !opera), or just let it go.
What do you think, guys..?

Unless someone can find a reason for the bug... :-/
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 14th, 2013, 04:06 PM
I've seen other issues in Chrome with flexbox but they all seem to be randomly reproducible not consistently so >_<
Title: Re: flexbox and opera 12.14
Post by: MultiformeIngegno on March 14th, 2013, 06:06 PM
I'd remove Opera from flex browsers support
Title: Re: flexbox and opera 12.14
Post by: icari on March 22nd, 2013, 11:00 AM
@Nao any progress on fixing this? I want to see if fixing this also fixes a scroll bar issue I am seeing with private messages using opera.
Title: Re: flexbox and opera 12.14
Post by: icari on March 25th, 2013, 08:07 PM
Quote from icari on March 22nd, 2013, 11:00 AM
@Nao any progress on fixing this? I want to see if fixing this also fixes a scroll bar issue I am seeing with private messages using opera.
@Nao any progress on this?
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 25th, 2013, 08:12 PM
There has not been any progress. This site is always using close-to-if-not-actually-current SVN, and if it's still happening then it's still broken. You could always check the SVN changelog which has been public for years.
Title: Re: flexbox and opera 12.14
Post by: icari on March 25th, 2013, 09:37 PM
that does not mean he has not done a local change though right? one that has not yet made it into svn. and yes i did check the changelog for a chance.
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 25th, 2013, 10:14 PM
Sure, there's always the remote chance that a major bug fix gets applied here before it gets put into SVN, but normally it's very obvious that's the case and an SVN commit follows a day or so later - but since it does not appear to be fixed, nor is there any mention in SVN, that would imply it is not fixed, yes?
Title: Re: flexbox and opera 12.14
Post by: icari on March 25th, 2013, 10:36 PM
yes it would, so then the question would be for Nao as to when he plans if at all to fix this. it is making reading posts very difficult.

[i am assuming from comments above that it will be fixed at some point]
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 25th, 2013, 10:42 PM
Well, yes, it will get fixed at some point. But we do have other things that need work right now, it is not our #1 item to fix as at this moment in time.
Title: Re: flexbox and opera 12.14
Post by: Nao on March 26th, 2013, 12:46 AM
Quote from icari on March 22nd, 2013, 11:00 AM
@Nao any progress on fixing this? I want to see if fixing this also fixes a scroll bar issue I am seeing with private messages using opera.
Why would I do anything about it when you didn't give me your opinion on the couple of solutions I suggested..?
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 26th, 2013, 12:51 AM
Because icari is not as technically minded as us. I'd personally declare Opera as no can_flex and be done with it, because as you said, it's going to die sooner or later.

I have noticed it has been more reliable of late, though I'm still having occasional issues with code blocks with a horizontal scrollbar - the scrollbar isn't draggable with a mouse and often has vertical alignment issues.
Title: Re: flexbox and opera 12.14
Post by: MultiformeIngegno on March 26th, 2013, 01:47 AM
Shouldn't Opera go with WebKit soon? Its share is already ridiculous, when the browser engine will change this wont be a problem anymore.
I think this should be a not-a-bug / won't fix
Title: Re: flexbox and opera 12.14
Post by: icari on March 26th, 2013, 02:03 AM
i dont think won't fix is the way to go, as it may be a long time before opera changes the engine in the stable version of the browser. those that do use opera should not be forced to use another browser when Nao has already stated it is possible to exclude opera from flexbox and the issue is resolved.
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 26th, 2013, 02:08 AM
Quote from MultiformeIngegno on March 26th, 2013, 01:47 AM
Shouldn't Opera go with WebKit soon? Its share is already ridiculous, when the browser engine will change this wont be a problem anymore.
I think this should be a not-a-bug / won't fix
It will be going with Webkit in the next few versions, they already announced it, but when is another matter entirely?
Quote from icari on March 26th, 2013, 02:03 AM
i dont think won't fix is the way to go, as it may be a long time before opera changes the engine in the stable version of the browser. those that do use opera should not be forced to use another browser when Nao has already stated it is possible to exclude opera from flexbox and the issue is resolved.
It won't be that long, but given how Opera's market share is even smaller than IE6's - and we largely already dropped IE 6 support, it does seem something of a lost cause.
Quote
Nao has already stated it is possible to exclude opera from flexbox and the issue is resolved.
You do realise that IS the "won't fix" solution, right?
Title: Re: flexbox and opera 12.14
Post by: icari on March 26th, 2013, 10:33 AM
but that is still fixing the issue for those that use opera. making the issue not exist is making it fixed imo.
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 26th, 2013, 03:52 PM
You do realise that we move at our pace and not the pace of others, right? It will get fixed in due course.
Title: Re: flexbox and opera 12.14
Post by: Nao on March 26th, 2013, 03:54 PM
I'll be committing that change in my next update.
Quote from Arantor on March 26th, 2013, 02:08 AM
It will be going with Webkit in the next few versions, they already announced it, but when is another matter entirely?
Opera 14.x+ will be WebKit-based. (They're skipping version 13, just like I did for Kyôdai Mahjongg... No kidding :lol:)
But it's not planned to be in beta before at least this summer, IIRC.
And the final version is probably only coming at the end of the year. Which would allow Opera to resume its earlier version numbering system (right before 2011, they released version 11. They did that every year, at least in recent years.)

Also, Presto-based versions will still be out in the wild, and supported for quite some time.
However, I don't know if it's worth bothering. Opera 12+ is so unstable these days, very few power users keep using it. I know I was a die-hard Opera fan (see the topic I posted here about their move to WebKit), and only changed to another browser reluctantly after many weeks of suffering to their various recent versions that would all keep crashing on me -- even when installed fresh.
I know how hard it can be to keep a release stable on so many different machines, but I don't think I have an exotic rig at all.

And these days, I've started using Sleipnir, perhaps because it's Japanese and is based on Norse mythology (I love both cultures..?), or just because after Opera, it's probably the best browser for multi-tab support. It has grouped tabs, and vertical tabs. It's only missing the ability to scroll a vertical list, it will only reduce individual tab heights, but it's still better than using Opera and having to restart it every hour or so.... :-/

Yep, Sleipnir is a pretty good Chromium fork.
Quote
It won't be that long, but given how Opera's market share is even smaller than IE6's - and we largely already dropped IE 6 support, it does seem something of a lost cause.
Let's just say, I've wasted way too much time on IE6, not because of its market share, but because I had a strong belief that if I was supporting Opera first thing, then I should be supporting to any browser that has a higher market share. Well, in the case of IE6, if you remove China from the picture, its market share is now less than Opera, so there's your first good reason for dropping support for IE6, but also -- I've made so many changes to Wess over the years, and every time I had to patch it for IE & co... One day, not so long ago, I realized I'd better support the most widely used browser (i.e. a WebKit-based one), and then, *when we go public*, fix bugs as they're reported on other browsers.
I'm not effectively doing that, but let's just say I'm in a better shape now that I stopped worrying and learned to love the chrome  ;)
Quote
You do realise that IS the "won't fix" solution, right?
I would venture into saying it isn't.
wontfix means no changes will be made.
notabug is similar, but might imply a change. So this situation would be more of a notabug.
Anyway, since it's a browser bug and it happens so randomly, I'll be removing support for Opera in can_flex. You can always add it yourself in your CSS (i.e. "@if (can_flex, opera[12.1-])"...)

Another thing I'd like to point out, is that even Firefox and Chrome weren't cooperating with me when it came to adding flex support. The basic version failed to work when I would add a code block inside a post. I managed to patch them, but only because I found hints online about making them behave. NOT because I'd done something incorrectly in the first place, which is a bit worrying...

so, flexbox is a feature I love, but if it's not 'stable' by next year, might be worth considering to drop it entirely...
Title: Re: flexbox and opera 12.14
Post by: Nao on March 26th, 2013, 06:10 PM
Pete, I just noticed reply #17 from yours... Posted 2 minutes before mine.
I can certify I never got a mention about it being posted in the meantime.

This really, really should be looked into, because it's been a problem for a long time, and I hate the idea of missing a post...!

If it helps, my post was sent from the regular post box (it's easy to tell with me -- if it's a long post with quotes, it's the post page, otherwise it's likely to be a quick reply, like here.)
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 26th, 2013, 07:08 PM
Quote
This really, really should be looked into, because it's been a problem for a long time, and I hate the idea of missing a post...!
I will investigate, but I wasn't able to reproduce it when making changes to it recently.
Title: Re: flexbox and opera 12.14
Post by: Nao on March 26th, 2013, 07:21 PM
Done.
One of the things I noticed, is that the Reply button has a last_msg param, instead of 'last'. Thus, it won't go through the code path for last post checks... (I think.)
Now, in Post2.php, it checks for $_POST['last']. I double-checked, and guess what..? Post pages don't have that one. They have (drum roll)... last_msg!

So, I'm thinking at some point I renamed last_msg to last, and forgot to rename all of them.
It's in rev 1112, by the way.
What should I do...? Rename the rest?
Title: Re: flexbox and opera 12.14
Post by: Arantor on March 26th, 2013, 07:25 PM
That makes a lot of sense. If you're going to rename them, be consistent. I have no aversion to it being either last_msg or last, so whichever you want to do. Personally I'd put them all back to last_msg as that's more descriptive than last (last what, exactly?) but I'm not bothered if you want to make them all 'last'.
Title: Re: flexbox and opera 12.14
Post by: Nao on March 26th, 2013, 07:33 PM
I renamed last_msg to last everywhere (sorry, that was before I saw your post). Checked against [^_]last_msg to make sure I caught everything. There was a surprising amount of crap that was left over. Heck, there was even a reference to that form entry in post.js...! Meaning Preview wouldn't tell us about new posts, either.

I'll commit once I'm done with my current work. I've got tons of things to commit, actually... And in all areas! (Fixes in Skeleton code, fixes in Notifications, template changes for Notifications, now this...)

PS: I prefer last to last_msg personally, perhaps because I have an aversion for underscores in 'visible' HTML code, as you may have noticed today, ah ah... Also, err, I think 'last', as a variable, is ONLY used in this situation. So there shouldn't be any conflicts...
Title: Re: flexbox and opera 12.14
Post by: icari on March 28th, 2013, 09:09 PM
so far i dont see the issue occurring, so i will mark this solved. thanks.