Wedge
Public area => Bug reports => The Pub => Archived fixes => Topic started by: live627 on February 23rd, 2013, 01:03 AM
-
My own post shows the tooltip over the number of likes, but other people's posts have it over the actual link. Tested on this website.
-
That's because on your own posts you don't have a link to click on ;)
I've not been satisfied with the whole tooltip thing since we dropped the text from being inline in the first place. See, if you remember, originally it would state the "You, x, y and z others like this" inline. Then we dropped it for just the number.
So before worrying about where the tooltip is, we should be asking whether we even need the tooltip... do we?
(If not, a lot of things suddenly get simpler.)
-
Oh, it seemed to me the tooltip was supposed to be over the number, seemed logical to me.
TBH with you, I don't think anybody uses it, much less notice it's been removed. It's one of those features that nobody knows about unless told.
-
Oh, I use it occasionally if I can't be arsed actually loading the popup (e.g. only one like) but yeah, that's what I'm thinking too.
Would be nice to trim all the surrounding language strings that I spent so long figuring out hahahahaha
-
I don't even use the tooltip any more... before I remove it I'd like some more comments about it.
-
I normally just click for popup.
-
Why is the " broken in that post above? Oh... I know, it's an old post from before I fixed that crap.
-
I don't even use the tooltip any more... before I remove it I'd like some more comments about it.
However, you may want to keep it for newbies... But really, it doesn't matter that much.
-
The only benefit to the tooltip is that you can see the first couple of likes without actually selecting it. But if we drop the tooltip we can save some effort both in terms of language strings and not having to fetch the names from the DB... and if we're not fetching the names we simplify a ton of code and make the query faster to boot.
-
Then we could replace with a name-free equivalent... "2 people liked this." that way, everybody's happy I guess!
We can even do it in js, eheh....
-
That works for me. Though we would still need to replace it with the following:
1 person liked this.
2 people liked this.
You liked this.
You and 1 other person liked this.
You and 2 other people liked this.
But that's still simpler than what we currently have. I'll tackle this shortly if you like?
-
Is it just me, or do all those statements sound better with the "have" helper in them?
1 person has liked this.
2 people have liked this.
You have liked this.
You and 1 other person have liked this.
You and 2 other people have liked this.
-
Works for me. I was just slinging it out quickly to confirm exactly what would be needed.
-
Implemented though I didn't use quite the same wording.