Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: emanuele on November 28th, 2012, 10:10 AM

Title: Non-static method weMoDe::isMobile()
Post by: emanuele on November 28th, 2012, 10:10 AM
Search doesn't give any result so I assume it has not yet been reported.
Not sure if it is useful to report either, but better have it twice rather than none. :P

Code: [Select]
Strict Standards: Non-static method weMoDe::isMobile() should not be called statically in /home/xxxxxx/www/xxxxxx/wedge/Sources/Load.php on line 378
in:
http://wedge.org/license/
the first time the page is loaded (easy to see using private tabs).
Title: Re: Non-static method weMoDe::isMobile()
Post by: Nao on November 28th, 2012, 11:19 AM
Thank you, fixed ;)
This class was basically taken from a web snippet, and I didn't bother to check the method type.
It only shows up on first load because the contents of the function is cached for the duration of the session.

Which reminds me that last week I had planned to rewrite detectBrowser() into a part of this object... To benefit from the session cache ;)
Then I stopped midway through it, because of cache filename considerations... Which have yet to be addressed. -_-
Title: Re: Non-static method weMoDe::isMobile()
Post by: emanuele on November 29th, 2012, 07:50 PM
Quote from Nao on November 28th, 2012, 11:19 AM
It only shows up on first load because the contents of the function is cached for the duration of the session.
Yep, I imagined that.
Quote from Nao on November 28th, 2012, 11:19 AM
Which reminds me that last week I had planned to rewrite detectBrowser() into a part of this object... To benefit from the session cache ;)
Then I stopped midway through it, because of cache filename considerations... Which have yet to be addressed. -_-
I think I know (at least part of) the feeling... :P
Title: Re: Non-static method weMoDe::isMobile()
Post by: Nao on November 30th, 2012, 06:01 PM
Yup!

Just for the pleasure of posting from my new phone... :niark: